[REF] account_invoice_overdue_reminder: modernize ORM writes and cleanup readonly flags

- Replace write() calls with recordset assignment/update
- Remove readonly flags from model fields to avoid unnecessary restrictions,
  defining readonly behavior in views instead.

Author: NICO-SOLUTIONS

account_invoice_overdue_reminder/models/account_invoice_overdue_reminder.py

@@ -14,9 +14,7 @@ class AccountInvoiceOverdueReminder(models.Model):
     # For the link to invoice: why a M2O and not a M2M ?
     # Because of the "counter" field: a single reminder action for a customer,
     # the "counter" may not be the same for each invoice
-    invoice_id = fields.Many2one(
-        "account.move", string="Invoice", ondelete="cascade", readonly=True
-    )
+    invoice_id = fields.Many2one("account.move", string="Invoice", ondelete="cascade")
     action_id = fields.Many2one(
         "overdue.reminder.action", string="Overdue Reminder Action", ondelete="cascade"
     )
@@ -32,13 +30,11 @@ class AccountInvoiceOverdueReminder(models.Model):
     action_result_id = fields.Many2one(related="action_id.result_id", readonly=False)
     action_result_notes = fields.Html(related="action_id.result_notes", readonly=False)
     action_mail_id = fields.Many2one(related="action_id.mail_id")
-    action_mail_cc = fields.Char(
-        related="action_id.mail_id.email_cc", readonly=True, string="Cc"
-    )
+    action_mail_cc = fields.Char(related="action_id.mail_id.email_cc", string="Cc")
     action_mail_state = fields.Selection(
         related="action_id.mail_id.state", string="E-mail Status"
     )
-    counter = fields.Integer(readonly=True)
+    counter = fields.Integer()
     company_id = fields.Many2one(related="invoice_id.company_id", store=True)
 
     _sql_constraints = [
@@ -48,10 +44,7 @@ class AccountInvoiceOverdueReminder(models.Model):
     @api.constrains("invoice_id")
     def invoice_id_check(self):
         for action in self:
-            if action.invoice_id and action.invoice_id.move_type not in [
-                "out_invoice",
-                "out_refund",
-            ]:
+            if action.invoice_id and not action.invoice_id.is_sale_document():
                 raise ValidationError(
                     _(
                         "An overdue reminder can only be attached "

account_invoice_overdue_reminder/models/overdue_reminder_action.py

@@ -13,7 +13,6 @@ class OverdueReminderAction(models.Model):
 
     commercial_partner_id = fields.Many2one(
         "res.partner",
-        readonly=True,
         string="Customer",
         index=True,
         domain=[("parent_id", "=", False)],

account_invoice_overdue_reminder/views/account_invoice_overdue_reminder.xml

@@ -11,7 +11,11 @@
         <field name="arch" type="xml">
             <form>
                 <group name="main">
-                    <field name="counter" invisible="action_reminder_type == 'phone'" />
+                    <field
+                        name="counter"
+                        readonly="1"
+                        invisible="action_reminder_type == 'phone'"
+                    />
                     <field
                         name="action_commercial_partner_id"
                         invisible="not context.get('overdue_reminder_main_view')"
@@ -52,20 +56,28 @@
         <field name="arch" type="xml">
             <form>
                 <group name="main">
-                    <field name="invoice_id" />
+                    <field name="invoice_id" readonly="1" />
                     <field name="action_reminder_type" invisible="1" />
-                    <field name="counter" invisible="action_reminder_type == 'phone'" />
+                    <field
+                        name="counter"
+                        readonly="1"
+                        invisible="action_reminder_type == 'phone'"
+                    />
                 </group>
             </form>
         </field>
     </record>
 
     <record id="account_invoice_overdue_reminder_tree" model="ir.ui.view">
-        <field name="name">account.invoice.overdue.reminder.tree</field>
+        <field name="name">account.invoice.overdue.reminder.list</field>
         <field name="model">account.invoice.overdue.reminder</field>
         <field name="arch" type="xml">
             <tree create="0">
-                <field name="counter" invisible="action_reminder_type == 'phone'" />
+                <field
+                    name="counter"
+                    readonly="1"
+                    invisible="action_reminder_type == 'phone'"
+                />
                 <field name="action_date" />
                 <field
                     name="action_partner_id"
@@ -104,8 +116,8 @@
         <field name="priority">100</field>
         <field name="arch" type="xml">
             <tree create="0">
-                <field name="invoice_id" />
-                <field name="counter" />
+                <field name="invoice_id" readonly="1" />
+                <field name="counter" readonly="1" />
             </tree>
         </field>
     </record>

account_invoice_overdue_reminder/views/overdue_reminder_action.xml

@@ -12,7 +12,7 @@
             <form>
                 <sheet>
                     <group name="main">
-                        <field name="commercial_partner_id" />
+                        <field name="commercial_partner_id" readonly="1" />
                         <field name="partner_id" context="{'show_email': True}" />
                         <field name="date" />
                         <field name="user_id" />
@@ -44,7 +44,7 @@
         <field name="arch" type="xml">
             <tree>
                 <field name="date" />
-                <field name="commercial_partner_id" />
+                <field name="commercial_partner_id" readonly="1" />
                 <field name="user_id" widget="many2one_avatar_user" optional="show" />
                 <field
                     name="reminder_type"

account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py

@@ -451,7 +451,7 @@ def goto_list_view(self):
         return action
 
     def skip(self):
-        self.write({"state": "skipped"})
+        self.update({"state": "skipped"})
         if len(self) == 1:
             if self.interface == "onebyone":
                 action = self.next_step()
@@ -520,7 +520,7 @@ def validate(self):
             orao.create(vals)
             if rec.create_activity:
                 mao.create(self._prepare_mail_activity())
-        self.write({"state": "done"})
+        self.state = "done"
         if len(self) == 1:
             if self.interface == "onebyone":
                 action = self.next_step()
@@ -587,7 +587,7 @@ def generate_mail_vals(self):
         mail = self.env["mail.mail"].sudo().create(mvals)
         if self.company_id.overdue_reminder_attach_invoice:
             attachment_ids = self._get_attachment_ids(mail)
-            mail.write({"attachment_ids": [Command.set(attachment_ids)]})
+            mail.attachment_ids = [Command.set(attachment_ids)]
         vals = {"mail_id": mail.id}
         return vals
 
@@ -652,7 +652,7 @@ def _prepare_overdue_reminder_action(self, vals):
 
     def print_letter(self):
         self.check_warnings()
-        self.write({"letter_printed": True})
+        self.letter_printed = True
         action = action = (
             self.env.ref(MOD + ".overdue_reminder_step_report")
             .with_context(discard_logo_check=True)
@@ -720,5 +720,5 @@ def run(self):
         elif self.update_action == "reminder_type":
             if not self.reminder_type:
                 raise UserError(_("You must select the new reminder type."))
-            actions.write({"reminder_type": self.reminder_type})
+            actions.reminder_type = self.reminder_type
         return

account_invoice_overdue_reminder/wizard/overdue_reminder_wizard_view.xml

@@ -113,7 +113,7 @@
             <form>
                 <group name="main">
                     <group name="main-left">
-                        <field name="commercial_partner_id" />
+                        <field name="commercial_partner_id" readonly="1" />
                         <field
                             name="partner_id"
                             domain="[('id', 'child_of', commercial_partner_id)]"
@@ -123,7 +123,7 @@
                         <field name="company_id" invisible="1" />
                     </group>
                     <group name="main-right">
-                        <field name="counter" />
+                        <field name="counter" readonly="1" />
                         <field name="partner_phone" widget="phone" />
                         <field name="partner_mobile" widget="phone" />
                     </group>
@@ -276,9 +276,9 @@
                         string="Skip"
                     />
                 </header>
-                <field name="commercial_partner_id" decoration-bf="1" />
+                <field name="commercial_partner_id" readonly="1" decoration-bf="1" />
                 <field name="partner_id" />
-                <field name="counter" />
+                <field name="counter" readonly="1" />
                 <field
                     name="reminder_type"
                     widget="badge"