[MIG] sale_financial_risk: Migration to 19.0

Author: pablo-cort-s73

sale_financial_risk/README.rst

@@ -21,13 +21,13 @@ Sale Financial Risk
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcredit--control-lightgray.png?logo=github
-    :target: https://github.com/OCA/credit-control/tree/18.0/sale_financial_risk
+    :target: https://github.com/OCA/credit-control/tree/19.0/sale_financial_risk
     :alt: OCA/credit-control
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-sale_financial_risk
+    :target: https://translation.odoo-community.org/projects/credit-control-19-0/credit-control-19-0-sale_financial_risk
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/credit-control&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/credit-control&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -61,7 +61,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/credit-control/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/credit-control/issues/new?body=module:%20sale_financial_risk%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/credit-control/issues/new?body=module:%20sale_financial_risk%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -76,15 +76,18 @@ Authors
 Contributors
 ------------
 
-- `Tecnativa <https://www.tecnativa.com>`__:
+-  `Tecnativa <https://www.tecnativa.com>`__:
 
-  - Carlos Dauden
-  - Pedro M. Baeza
-  - Ernesto Tejeda
-  - Stefan Ungureanu
+   -  Carlos Dauden
+   -  Pedro M. Baeza
+   -  Ernesto Tejeda
+   -  Stefan Ungureanu
 
-- Agathe Mollé <agathe.molle@savoirfairelinux.com>
-- Ugne Sinkeviciene <ugne@versada.eu>
+-  Agathe Mollé <agathe.molle@savoirfairelinux.com>
+-  Ugne Sinkeviciene <ugne@versada.eu>
+-  `Studio73 <https://www.studio73.es/>`__:
+
+   -  Pablo Cortés
 
 Maintainers
 -----------
@@ -99,6 +102,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/credit-control <https://github.com/OCA/credit-control/tree/18.0/sale_financial_risk>`_ project on GitHub.
+This module is part of the `OCA/credit-control <https://github.com/OCA/credit-control/tree/19.0/sale_financial_risk>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_financial_risk/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Sale Financial Risk",
     "summary": "Manage partner risk in sales orders",
-    "version": "18.0.1.0.6",
+    "version": "19.0.1.0.0",
     "category": "Sales Management",
     "license": "AGPL-3",
     "author": "Tecnativa, Odoo Community Association (OCA)",

sale_financial_risk/models/payment.py

@@ -7,11 +7,11 @@
 class PaymentTransaction(models.Model):
     _inherit = "payment.transaction"
 
-    def _set_authorized(self):
+    def _set_authorized(self, **kwargs):
         """Bypass risk for sale confirmation triggered by this method"""
         return super(
             PaymentTransaction, self.with_context(bypass_risk=True)
-        )._set_authorized()
+        )._set_authorized(**kwargs)
 
     def _post_process(self):
         """Bypass risk for sale confirmation and invoice creation triggered

sale_financial_risk/models/res_partner.py

@@ -2,6 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 from odoo import api, fields, models
+from odoo.fields import Domain
 
 
 class ResPartner(models.Model):
@@ -25,10 +26,21 @@ class ResPartner(models.Model):
 
     def _get_risk_sale_order_domain(self):
         risk_states = self.env["sale.order"]._get_risk_states()
-        return self._get_risk_company_domain() + [
-            ("state", "in", risk_states),
-            ("risk_partner_id", "in", self.mapped("commercial_partner_id").ids),
-        ]
+        return Domain.AND(
+            [
+                self._get_risk_company_domain(),
+                Domain(
+                    [
+                        ("state", "in", risk_states),
+                        (
+                            "risk_partner_id",
+                            "in",
+                            self.mapped("commercial_partner_id").ids,
+                        ),
+                    ]
+                ),
+            ]
+        )
 
     @api.depends(
         "sale_order_ids.order_line.risk_amount",

sale_financial_risk/models/sale.py

@@ -105,7 +105,7 @@ def _compute_risk_amount(self):
                 qty = max(qty, line.qty_delivered)
             risk_qty = float_round(
                 qty - line.qty_invoiced,
-                precision_rounding=line.product_uom.rounding or 0.01,
+                precision_rounding=line.product_uom_id.rounding or 0.01,
             )
             # There is no risk if the line hasn't stock moves to deliver
             # Added hasattr condition because fails in post-migration compute

sale_financial_risk/readme/CONTRIBUTORS.md

@@ -5,3 +5,5 @@
   - Stefan Ungureanu
 - Agathe Mollé \<<agathe.molle@savoirfairelinux.com>\>
 - Ugne Sinkeviciene \<<ugne@versada.eu>\>
+- [Studio73](https://www.studio73.es/):
+  - Pablo Cortés

sale_financial_risk/static/description/index.html

@@ -374,7 +374,7 @@ <h1>Sale Financial Risk</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:e01c8b7e6ffe45c71c56e0b59574a8cfb43644087f75958793cd0a2244e82fac
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/credit-control/tree/18.0/sale_financial_risk"><img alt="OCA/credit-control" src="https://img.shields.io/badge/github-OCA%2Fcredit--control-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-sale_financial_risk"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/credit-control&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/credit-control/tree/19.0/sale_financial_risk"><img alt="OCA/credit-control" src="https://img.shields.io/badge/github-OCA%2Fcredit--control-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/credit-control-19-0/credit-control-19-0-sale_financial_risk"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/credit-control&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Extends Partner Financial Risk to manage sales orders.</p>
 <p>Adds a new risk amount field in sale order line to compute risk based on
 the difference between ordered quantity (or delivered in some cases) and
@@ -408,7 +408,7 @@ <h2><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/credit-control/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/credit-control/issues/new?body=module:%20sale_financial_risk%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/credit-control/issues/new?body=module:%20sale_financial_risk%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -431,6 +431,10 @@ <h3><a class="toc-backref" href="#toc-entry-5">Contributors</a></h3>
 </li>
 <li>Agathe Mollé &lt;<a class="reference external" href="mailto:agathe.molle&#64;savoirfairelinux.com">agathe.molle&#64;savoirfairelinux.com</a>&gt;</li>
 <li>Ugne Sinkeviciene &lt;<a class="reference external" href="mailto:ugne&#64;versada.eu">ugne&#64;versada.eu</a>&gt;</li>
+<li><a class="reference external" href="https://www.studio73.es/">Studio73</a>:<ul>
+<li>Pablo Cortés</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -442,7 +446,7 @@ <h3><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h3>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/credit-control/tree/18.0/sale_financial_risk">OCA/credit-control</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/credit-control/tree/19.0/sale_financial_risk">OCA/credit-control</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

sale_financial_risk/tests/test_partner_sale_risk.py

@@ -1,7 +1,7 @@
 # Copyright 2016-2018 Tecnativa - Carlos Dauden
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import fields
+from odoo import Command, fields
 
 from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT, BaseCommon
 
@@ -11,17 +11,38 @@ class TestPartnerSaleRisk(BaseCommon):
     def setUpClass(cls):
         super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
-        cls.env.user.groups_id |= cls.env.ref(
+        cls.env.user.group_ids |= cls.env.ref(
             "account_financial_risk.group_account_financial_risk_manager"
         )
+        cls.account_income = cls.env["account.account"].create(
+            {
+                "name": "Test Income Account",
+                "code": "TESTINC",
+                "account_type": "income",
+                "company_ids": [Command.set([cls.env.company.id])],
+            }
+        )
+        cls.account_receivable = cls.env["account.account"].create(
+            {
+                "name": "Test Receivable Account",
+                "code": "TESTREC",
+                "account_type": "asset_receivable",
+                "company_ids": [Command.set([cls.env.company.id])],
+            }
+        )
         cls.partner = cls.env["res.partner"].create(
-            {"name": "Partner test", "customer_rank": 1}
+            {
+                "name": "Partner test",
+                "customer_rank": 1,
+                "property_account_receivable_id": cls.account_receivable.id,
+            }
         )
         cls.product = cls.env["product.product"].create(
             {
                 "sale_ok": True,
                 "taxes_id": [],
                 "name": "Test Product",
+                "property_account_income_id": cls.account_income.id,
             }
         )
         cls.product.invoice_policy = "order"
@@ -33,6 +54,14 @@ def setUpClass(cls):
         cls.USD = cls.env.ref("base.USD")
         cls.sale_order = cls.create_sale_order(cls.main_currency, cls.env.company)
         cls.env.user.lang = "en_US"
+        cls.journal = cls.env["account.journal"].create(
+            {
+                "name": "Test Sale Journal",
+                "code": "TSJ",
+                "type": "sale",
+                "company_id": cls.env.company.id,
+            }
+        )
 
     @classmethod
     def create_sale_order(cls, currency, company):
@@ -43,16 +72,14 @@ def create_sale_order(cls, currency, company):
                 "currency_id": currency.id,
                 "company_id": company.id,
                 "order_line": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "name": cls.product.name,
                             "product_id": cls.product.id,
                             "product_uom_qty": 1,
-                            "product_uom": cls.product.uom_id.id,
+                            "product_uom_id": cls.product.uom_id.id,
                             "price_unit": 115.0,
-                            "tax_id": False,
+                            "tax_ids": False,
                             "company_id": company.id,
                         },
                     )
@@ -155,7 +182,8 @@ def test_compute_risk_amount(self):
             [
                 ("type", "=", "sale"),
                 ("company_id", "=", self.env.company.id),
-            ]
+            ],
+            limit=1,
         )
         ref_wiz_obj = self.env["account.move.reversal"].with_context(
             active_model="account.move", active_ids=[invoice.id]