Skip to content

Commit 609eb5b

Browse files
author
Hadrien Huvelle
committed
Fix unreadable log and error message.
1 parent 9a0849a commit 609eb5b

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

delivery_carrier_label_batch/wizard/generate_labels.py

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,21 @@ def retriable_send_to_shipper(self, picking):
8686
try:
8787
picking.send_to_shipper()
8888
except OperationalError as oe:
89-
_logger.error("Error sending to shipper: %s", oe.diag)
89+
diag = getattr(oe, "diag", None)
90+
message = str(oe)
91+
if diag:
92+
parts = []
93+
for attr in ("message_primary", "detail", "hint", "context"):
94+
value = getattr(diag, attr, None)
95+
if value:
96+
parts.append(value)
97+
if parts:
98+
message = " | ".join(parts)
99+
else:
100+
message = message or repr(diag)
101+
_logger.error("Error sending to shipper: %s", message)
90102
raise RetryableJobError(
91-
oe.diag,
103+
message,
92104
seconds=3,
93105
# ignore_retry=True,
94106
) from oe
@@ -295,9 +307,9 @@ def _concat_files(self, file_type, files):
295307
return assemble_pdf(files)
296308
if file_type == "zpl2":
297309
zpl2_single_images = safe_eval(
298-
self.env["ir.config_parameter"].get_param(
299-
"zpl2.assembler.single.images"
300-
)
310+
self.env["ir.config_parameter"]
311+
.sudo()
312+
.get_param("zpl2.assembler.single.images")
301313
)
302314
if zpl2_single_images:
303315
return assemble_zpl2_single_images(files)

0 commit comments

Comments
 (0)