[FIX] dms_import: fallback too large image error

Author: xaviedoanhduy

dms_import/__init__.py

@@ -1,3 +1,4 @@
 from . import models
 
 from .hooks import post_init_hook
+from .hooks import post_load_hook

dms_import/__manifest__.py

@@ -14,4 +14,5 @@
     "depends": ["dms"],
     "external_dependencies": {"python": ["pathvalidate", "openupgradelib"]},
     "post_init_hook": "post_init_hook",
+    "post_load": "post_load_hook",
 }

dms_import/hooks.py

@@ -9,12 +9,16 @@
 
 from openupgradelib import openupgrade
 from pathvalidate import sanitize_filename
+from PIL import Image
 from psycopg2.sql import SQL, Identifier
 
 from odoo import SUPERUSER_ID, Command, api, models
+from odoo.exceptions import UserError
 from odoo.tools import table_exists
 from odoo.tools.misc import get_lang, split_every
 
+from odoo.addons.dms.models.dms_file import File
+
 from .tools import file
 
 _logger = logging.getLogger(__name__)
@@ -416,12 +420,24 @@ def migrate_documents_files(cr, env, folder_mapping, tag_mapping, batch_size):
                 continue
             original_name = doc["name"]
             batch_original_names.append(original_name)
-            sanitized_name = sanitize_filename(original_name, replacement_text="_")
-            if not sanitized_name:
-                sanitized_name = "Unnamed Document"
+            if original_name.startswith(".") and len(original_name) > 1:
+                base_name = "Unnamed Document"
+                extension = original_name
+            else:
+                base_name, extension = os.path.splitext(original_name)
+                if not extension and base_name.startswith("."):
+                    base_name = "Unnamed Document"
+                    extension = original_name
+                elif not base_name:
+                    base_name = "Unnamed Document"
+            sanitized_base = sanitize_filename(base_name, replacement_text="_")
+            sanitized_ext = sanitize_filename(extension, replacement_text="_")
+            if not sanitized_base:
+                sanitized_base = "Unnamed Document"
+            sanitized_name = f"{sanitized_base}{sanitized_ext}"
             if original_name != sanitized_name:
                 _logger.debug(
-                    "Sanitized filename: '%s' -> '%s'", original_name, sanitized_name
+                    "Sanitized filename: '%s' to '%s'", original_name, sanitized_name
                 )
             names_in_directory = existing_names_by_dir[directory_id]
             unique_name = file.unique_name_new(
@@ -432,15 +448,13 @@ def migrate_documents_files(cr, env, folder_mapping, tag_mapping, batch_size):
             mimetype = att_data.get("mimetype") if att_data else None
             file_size = att_data.get("file_size") if att_data else 0
             checksum = att_data.get("checksum") if att_data else None
-            extension = None
-            if mimetype:
+            extension_str = sanitized_ext[1:].strip().lower() if sanitized_ext else ""
+            if not extension_str and mimetype:
                 guessed_ext = mimetypes.guess_extension(mimetype)
                 if guessed_ext:
-                    extension = guessed_ext[1:].strip().lower()
-            if not extension and original_name:
-                extension = os.path.splitext(original_name)[1][1:].strip().lower()
-            if not extension:
-                extension = "bin"
+                    extension_str = guessed_ext[1:].strip().lower()
+            if not extension_str:
+                extension_str = "bin"
             file_vals = {
                 "name": unique_name,
                 "directory_id": directory_id,
@@ -488,7 +502,7 @@ def migrate_documents_files(cr, env, folder_mapping, tag_mapping, batch_size):
                     """
                     ).format(cases=SQL(" ").join(case_clauses))
 
-                    openupgrade.logged_query(cr, query, params)
+                    cr.execute(query, params)
             except Exception:
                 _logger.exception("A critical error occurred during batch creation")
                 for name in batch_original_names:
@@ -532,3 +546,31 @@ def post_init_hook(cr, registry):
     except Exception:
         _logger.exception("Migration from 'documents' to 'dms' failed!")
         raise
+
+
+def post_load_hook():
+    @api.depends("mimetype", "content")
+    def _compute_image_1920_new(self):
+        """Provide thumbnail automatically if possible."""
+        for one in self.filtered("mimetype"):
+            if one.mimetype != "application/pdf" and one.mimetype in (
+                *Image.MIME.values(),
+                "image/svg+xml",
+            ):
+                # catch this error: https://github.com/odoo/odoo/blob/c27d978a/odoo/tools/image.py#L94
+                # start hooks
+                try:
+                    one.image_1920 = one.content
+                except (UserError, TypeError) as e:
+                    _logger.warning(
+                        "Failed to generate image_1920 for file %s (ID %s): ",
+                        one.name,
+                        one.id,
+                        str(e),
+                    )
+                    one.image_1920 = False
+                # end hooks
+
+    if not hasattr(File, "_compute_image_1920_origin"):
+        File._compute_image_1920_origin = File._compute_image_1920
+    File._compute_image_1920 = _compute_image_1920_new