[MIG] hr_dms_field: Migration to 18.0

TT55524

Author: victoralmau

hr_dms_field/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
     "name": "Add dms field for employees",
-    "version": "16.0.1.1.0",
+    "version": "18.0.1.0.0",
     "category": "Human Resources",
     "website": "https://github.com/OCA/dms",
     "author": "Tecnativa, Odoo Community Association (OCA)",

hr_dms_field/demo/dms_data.xml

@@ -13,5 +13,9 @@
         <field name="model_id" ref="hr.model_hr_employee" />
         <field name="user_field_id" ref="hr.field_hr_employee__user_id" />
         <field name="group_ids" eval="[(4, ref('read_access_hr_employee_group'))]" />
+        <!-- We need to define a different directory name because the existing partner
+        template will have caused a partner with the same name to be created when the
+        employee was created. !-->
+        <field name="directory_format_name">{{object.display_name}} (employee)</field>
     </record>
 </odoo>

hr_dms_field/i18n/es.po

@@ -67,6 +67,3 @@ msgstr "Empleado Público"
 #: model:ir.model.fields,field_description:hr_dms_field.field_res_config_settings__group_hr_public_dms
 msgid "Show DMS Documents to logged employees"
 msgstr "Mostrar documentos DMS a las empleados logeados"
-
-#~ msgid "Dms Field Template"
-#~ msgstr "Plantilla de Campo Dms"

hr_dms_field/i18n/it.po

@@ -66,6 +66,3 @@ msgstr "Dipendente pubblico"
 #: model:ir.model.fields,field_description:hr_dms_field.field_res_config_settings__group_hr_public_dms
 msgid "Show DMS Documents to logged employees"
 msgstr "Mostra i documenti DMS ai dipendenti collegati"
-
-#~ msgid "Dms Field Template"
-#~ msgstr "Modello campo DMS"

hr_dms_field/static/src/js/base/dms_list_controller.esm.js

@@ -1,16 +1,20 @@
-/** @odoo-module **/
-
-import {DMSListControllerObject} from "@dms_field/views/dms_list/dms_list_controller.esm";
+import {DmsListController} from "@dms_field/views/dms_list/dms_list_controller.esm";
+import {X2ManyField} from "@web/views/fields/x2many/x2many_field";
 import {patch} from "@web/core/utils/patch";
 
-patch(DMSListControllerObject, "hr_dms_field.DMSListControllerObject", {
-    // A basic user does not have access to hr.employee, only to hr.employee.public
-    // (Employee Directory), we have to get the data from hr.employee because that
-    // is where it is actually linked.
-    sanitizeDMSModel: function (model) {
-        if (model === "hr.employee.public") {
-            return "hr.employee";
-        }
-        return this._super(...arguments);
-    },
-});
+function getSanitizeDMSModel() {
+    return {
+        // A basic user does not have access to hr.employee, only to hr.employee.public
+        // (Employee Directory), we have to get the data from hr.employee because that
+        // is where it is actually linked.
+        sanitizeDMSModel(model) {
+            if (model === "hr.employee.public") {
+                return "hr.employee";
+            }
+            return super.sanitizeDMSModel(...arguments);
+        },
+    };
+}
+
+patch(DmsListController.prototype, getSanitizeDMSModel());
+patch(X2ManyField.prototype, getSanitizeDMSModel());

hr_dms_field/tests/test_hr_dms_field.py

@@ -1,6 +1,6 @@
-# Copyright 2024 Tecnativa - Víctor Martínez
+# Copyright 2024-2025 Tecnativa - Víctor Martínez
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
-
+from odoo import Command
 from odoo.tests import new_test_user
 from odoo.tools import mute_logger
 
@@ -70,8 +70,8 @@ def test_employee_write_custom(self):
         )
         read_access_hr_employee_group.write(
             {
-                "group_ids": [(5, 0)],
-                "explicit_user_ids": [(6, 0, self.env.ref("base.user_admin").ids)],
+                "group_ids": [Command.set([])],
+                "explicit_user_ids": [Command.set(self.env.ref("base.user_admin").ids)],
             }
         )
         employee = self.employee_model.create({"name": "Test employee"})
@@ -84,6 +84,7 @@ def test_employee_write_custom(self):
         # Use the demo user to modify the employee and link the user, it does not
         # have access to the directory.
         demo = self.env.ref("base.user_demo")
+        demo.write({"groups_id": [Command.link(self.env.ref("hr.group_hr_user").id)]})
         employee = employee.with_user(demo)
         employee.invalidate_recordset()
         employee.write({"user_id": self.user.id})

hr_dms_field/views/hr_employee_view.xml

@@ -6,11 +6,7 @@
         <field name="inherit_id" ref="hr.view_employee_form" />
         <field name="arch" type="xml">
             <notebook position="inside">
-                <page
-                    name="dms"
-                    string="Documents"
-                    attrs="{'invisible': [('id', '=', False)]}"
-                >
+                <page name="dms" string="Documents" invisible="not id">
                     <field name="dms_directory_ids" mode="dms_list" />
                 </page>
             </notebook>
@@ -33,7 +29,7 @@
                 <page
                     name="dms"
                     string="Documents"
-                    attrs="{'invisible': [('is_logged', '=', False)]}"
+                    invisible="not is_logged"
                     groups="hr_dms_field.group_hr_public_dms"
                 >
                     <field name="dms_directory_ids" mode="dms_list" />

hr_dms_field/views/res_config_settings_view.xml

@@ -6,10 +6,7 @@
         <field name="priority" eval="70" />
         <field name="inherit_id" ref="hr.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <xpath
-                expr="//div[@name='employee_rights_setting_container']"
-                position="inside"
-            >
+            <block name="employee_rights_setting_container" position="inside">
                 <div
                     class="col-12 col-lg-6 o_setting_box"
                     title="Allow employees to access their DMS Documents."
@@ -24,7 +21,7 @@
                         </div>
                     </div>
                 </div>
-            </xpath>
+            </block>
         </field>
     </record>
 </odoo>