[MIG] edi_purchase_oca: Migration to 18.0

Author: phucph

edi_purchase_oca/README.rst

@@ -65,11 +65,15 @@ Authors
 -------
 
 * ForgeFlow
+* Camptocamp
 
 Contributors
 ------------
 
-- Lois Rilo <lois.rilo@forgeflow.com>
+- Lois Rilo lois.rilo@forgeflow.com
+- Simone Orsi simone.orsi@camptocamp.com
+
+- Phan Hong Phuc <phucph@trobz.com>
 
 Maintainers
 -----------

edi_purchase_oca/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "EDI Purchase",
     "summary": """
         Define EDI Configuration for Purchase Orders""",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "LGPL-3",
     "author": "ForgeFlow, Camptocamp, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/edi-framework",

edi_purchase_oca/data/edi_configuration.xml

@@ -1,13 +1,13 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-  <!-- Generic state change -->
-  <record
+    <!-- Generic state change -->
+    <record
         id="edi_conf_trigger_purchase_order_state_change"
         model="edi.configuration.trigger"
     >
-    <field name="name">On PO state change</field>
-    <field name="code">on_edi_purchase_order_state_change</field>
-    <field name="description">Trigger when a purchase order state changes</field>
-    <field name="model_id" ref="purchase.model_purchase_order" />
-  </record>
+        <field name="name">On PO state change</field>
+        <field name="code">on_edi_purchase_order_state_change</field>
+        <field name="description">Trigger when a purchase order state changes</field>
+        <field name="model_id" ref="purchase.model_purchase_order" />
+    </record>
 </odoo>

edi_purchase_oca/demo/edi_exchange_type.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <odoo>
-
     <record id="demo_edi_exc_type_order_out" model="edi.exchange.type">
         <field name="backend_type_id" ref="demo_edi_backend_type_purchase" />
         <field name="backend_id" ref="demo_edi_backend" />
@@ -10,5 +9,4 @@
         <field name="exchange_filename_pattern">{record_name}-{type.code}-{dt}</field>
         <field name="exchange_file_ext">xml</field>
     </record>
-
 </odoo>

edi_purchase_oca/models/purchase_order.py

@@ -1,6 +1,8 @@
 # Copyright 2022 ForgeFlow S.L. (https://www.forgeflow.com)
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
 
+from contextlib import contextmanager
+
 from odoo import models
 
 
@@ -12,17 +14,19 @@ class PurchaseOrder(models.Model):
     ]
 
     def button_confirm(self):
-        res = super().button_confirm()
-        # DEPRECATED: rely on `on_edi_purchase_order_state_change`
-        # provided automatically by edi.consumer.mixin
-        if self:  # TODO: is this check necessary?
-            self._event("on_button_confirm_purchase_order").notify(self)
-        return res
+        with self._edi_purchase_order_state_change_trigger():
+            result = super().button_confirm()
+        return result
 
     def button_cancel(self):
-        result = super().button_cancel()
-        # DEPRECATED: rely on `on_edi_purchase_order_state_change`
-        # provided automatically by edi.consumer.mixin
-        if self:
-            self._event("on_button_cancel_purchase_order").notify(self)
+        with self._edi_purchase_order_state_change_trigger():
+            result = super().button_cancel()
         return result
+
+    @contextmanager
+    def _edi_purchase_order_state_change_trigger(self):
+        for order in self:
+            order._event("on_edi_purchase_order_state_change").notify(
+                order, state=order.state
+            )
+        yield

edi_purchase_oca/readme/CONTRIBUTORS.md

@@ -1 +1,3 @@
-- Lois Rilo \<<lois.rilo@forgeflow.com>\>
+* Lois Rilo <lois.rilo@forgeflow.com>
+* Simone Orsi <simone.orsi@camptocamp.com>
+- Phan Hong Phuc \<<phucph@trobz.com>\>

edi_purchase_oca/readme/CONTRIBUTORS.rst

@@ -408,12 +408,15 @@ <h1><a class="toc-backref" href="#toc-entry-2">Credits</a></h1>
 <h2><a class="toc-backref" href="#toc-entry-3">Authors</a></h2>
 <ul class="simple">
 <li>ForgeFlow</li>
+<li>Camptocamp</li>
 </ul>
 </div>
 <div class="section" id="contributors">
 <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 <ul class="simple">
-<li>Lois Rilo &lt;<a class="reference external" href="mailto:lois.rilo&#64;forgeflow.com">lois.rilo&#64;forgeflow.com</a>&gt;</li>
+<li>Lois Rilo <a class="reference external" href="mailto:lois.rilo&#64;forgeflow.com">lois.rilo&#64;forgeflow.com</a></li>
+<li>Simone Orsi <a class="reference external" href="mailto:simone.orsi&#64;camptocamp.com">simone.orsi&#64;camptocamp.com</a></li>
+<li>Phan Hong Phuc &lt;<a class="reference external" href="mailto:phucph&#64;trobz.com">phucph&#64;trobz.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

edi_purchase_oca/readme/DESCRIPTION.rst

@@ -3,6 +3,8 @@
 
 from unittest import mock
 
+from odoo import Command
+
 from odoo.addons.edi_oca.tests.common import EDIBackendCommonComponentTestCase
 
 
@@ -21,24 +23,24 @@ def setUpClass(cls):
         cls.edi_conf = cls.env.ref("edi_purchase_oca.demo_edi_configuration_confirmed")
         cls.partner.edi_purchase_conf_ids = cls.edi_conf
 
-    @mock.patch("odoo.addons.edi_oca.models.edi_backend.EDIBackend._validate_data")
-    @mock.patch("odoo.addons.edi_oca.models.edi_backend.EDIBackend._exchange_generate")
-    @mock.patch("odoo.addons.edi_oca.models.edi_backend.EDIBackend._exchange_send")
+    @mock.patch("odoo.addons.edi_core_oca.models.edi_backend.EDIBackend._validate_data")
+    @mock.patch(
+        "odoo.addons.edi_core_oca.models.edi_backend.EDIBackend._exchange_generate"
+    )
+    @mock.patch("odoo.addons.edi_core_oca.models.edi_backend.EDIBackend._exchange_send")
     def test_order_confirm(self, mock_send, mock_generate, mock_validate):
         mock_generate.return_value = "TEST PO OUT"
         order = self.purchase_order.create(
             {
                 "partner_id": self.partner.id,
                 "order_line": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "product_id": self.product.id,
                             "product_qty": 10,
                             "price_unit": 100.0,
-                        },
-                    )
+                        }
+                    ),
                 ],
             }
         )