[FIX] l10n_it_edi_doi_extension: removed check on DOI tax to accept also other taxes

This PR is created to accept other taxes than DOI(for example inarcassa)
removed also on odoo core odoo/odoo@b88caf8

Author: micheledic

l10n_it_edi_doi_extension/README.rst

@@ -56,8 +56,8 @@ for the Declaration of Intent for incoming vendor bills.
 In the contacts, you can create a Declaration of Intent by choosing
 between two types:
 
-- "Issued from company": for declarations issued by the company.
-- "Received from customer": for declarations received from suppliers.
+-  "Issued from company": for declarations issued by the company.
+-  "Received from customer": for declarations received from suppliers.
 
 **Italiano**
 
@@ -66,8 +66,9 @@ dedicata alla Dichiarazione di Intento per le fatture in ingresso. Nei
 contatti è possibile creare una Dichiarazione di Intento scegliendo tra
 due tipologie:
 
-- "Issued from company": per le dichiarazioni emesse dall'azienda.
-- "Received from customer": per le dichiarazioni ricevute dai fornitori.
+-  "Issued from company": per le dichiarazioni emesse dall'azienda.
+-  "Received from customer": per le dichiarazioni ricevute dai
+   fornitori.
 
 Bug Tracker
 ===========
@@ -90,7 +91,10 @@ Authors
 Contributors
 ------------
 
-- Nextev S.r.l<odoo@nextev.it>
+-  Nextev S.r.l<odoo@nextev.it>
+-  `Stesi Consulting <https://www.stesi.consulting>`__:
+
+   -  Michele Di Croce <dicroce.m@stesi.consulting>
 
 Maintainers
 -----------

l10n_it_edi_doi_extension/models/account_move.py

@@ -37,14 +37,15 @@ def _compute_l10n_it_edi_doi_amount(self):
         other_move_ids = self - purchase_move_ids
         super(AccountMove, other_move_ids)._compute_l10n_it_edi_doi_amount()
         for move in purchase_move_ids:
-            tax = move.company_id.l10n_it_edi_doi_bill_tax_id
-            if not tax or not move.l10n_it_edi_doi_id:
+            l10n_it_edi_doi_bill_tax_ids = move.company_id.l10n_it_edi_doi_bill_tax_id
+            if not l10n_it_edi_doi_bill_tax_ids or not move.l10n_it_edi_doi_id:
                 move.l10n_it_edi_doi_amount = 0
                 continue
             declaration_lines = move.invoice_line_ids.filtered(
-                # The declaration tax cannot be used with other taxes on a single line
-                # (checked in `_post`)
-                lambda line, tax=tax: line.tax_ids.ids == tax.ids
+                lambda line,
+                l10n_it_edi_doi_bill_tax_ids=l10n_it_edi_doi_bill_tax_ids: all(
+                    tax in line.tax_ids for tax in l10n_it_edi_doi_bill_tax_ids
+                )
             )
             move.l10n_it_edi_doi_amount = sum(declaration_lines.mapped("price_total"))
         return  # W8110
@@ -97,13 +98,7 @@ def _post(self, soft=True):
                         doi_bill_tax.name,
                     )
                 )
-            if any(line.tax_ids != doi_bill_tax for line in declaration_lines):
-                errors.append(
-                    _(
-                        "A line using tax %s should not contain any other taxes",
-                        doi_bill_tax.name,
-                    )
-                )
+
         if errors:
             raise UserError("\n".join(errors))
         return super()._post(soft)

l10n_it_edi_doi_extension/readme/CONTRIBUTORS.md

@@ -1 +1,4 @@
 - Nextev S.r.l\<<odoo@nextev.it>\>
+- [Stesi Consulting](https://www.stesi.consulting):
+  - Michele Di Croce \<<dicroce.m@stesi.consulting>\>
+  

l10n_it_edi_doi_extension/static/description/index.html

@@ -409,7 +409,8 @@ <h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
 due tipologie:</p>
 <ul class="simple">
 <li>“Issued from company”: per le dichiarazioni emesse dall’azienda.</li>
-<li>“Received from customer”: per le dichiarazioni ricevute dai fornitori.</li>
+<li>“Received from customer”: per le dichiarazioni ricevute dai
+fornitori.</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
@@ -432,6 +433,10 @@ <h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Nextev S.r.l&lt;<a class="reference external" href="mailto:odoo&#64;nextev.it">odoo&#64;nextev.it</a>&gt;</li>
+<li><a class="reference external" href="https://www.stesi.consulting">Stesi Consulting</a>:<ul>
+<li>Michele Di Croce &lt;<a class="reference external" href="mailto:dicroce.m&#64;stesi.consulting">dicroce.m&#64;stesi.consulting</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

l10n_it_edi_doi_extension/tests/test_doi_issued_from_company.py

@@ -22,13 +22,13 @@ def _create_declaration(cls, type_doi):
                 "start_date": fields.Date.today(),
                 "end_date": fields.Date.today() + relativedelta(months=2),
                 "threshold": 5000,
-                "protocol_number_part1": "123",
-                "protocol_number_part2": "456",
+                "protocol_number_part1": f"123{type_doi}",
+                "protocol_number_part2": f"456{type_doi}",
             }
         )
 
     @classmethod
-    def _create_invoice(cls, name, partner, tax=False, date=False, in_type=False):
+    def _create_invoice(cls, name, partner, taxes=False, date=False, in_type=False):
         invoice_form = Form(
             cls.env["account.move"].with_context(
                 default_move_type="in_invoice" if in_type else "out_invoice",
@@ -39,20 +39,21 @@ def _create_invoice(cls, name, partner, tax=False, date=False, in_type=False):
         invoice_form.invoice_payment_term_id = cls.env.ref(
             "account.account_payment_term_advance"
         )
-        cls._add_invoice_line_id(invoice_form, tax=tax, in_type=in_type)
+        cls._add_invoice_line_id(invoice_form, taxes=taxes, in_type=in_type)
         invoice = invoice_form.save()
         return invoice
 
     @classmethod
-    def _add_invoice_line_id(cls, invoice_form, tax=False, in_type=False):
+    def _add_invoice_line_id(cls, invoice_form, taxes=False, in_type=False):
         with invoice_form.invoice_line_ids.new() as invoice_line:
             invoice_line.product_id = cls.env.ref("product.product_product_5")
             invoice_line.quantity = 10.00
             invoice_line.name = "test line"
             invoice_line.price_unit = 90.00
-            if tax:
+            if taxes:
                 invoice_line.tax_ids.clear()
-                invoice_line.tax_ids.add(tax)
+                for tax in taxes:
+                    invoice_line.tax_ids.add(tax)
 
     @classmethod
     def setUpClass(cls):
@@ -81,7 +82,29 @@ def setUpClass(cls):
         cls.env.company.l10n_it_edi_doi_bill_tax_id = cls.tax
 
     def test_in_invoice_under_declaration_limit(self):
-        invoice = self._create_invoice("1", self.partner, tax=self.tax, in_type=True)
+        invoice = self._create_invoice("1", self.partner, taxes=self.tax, in_type=True)
+        previous_used_amount = self.doi_in.invoiced
+        invoice.action_post()
+        used_amount = self.doi_in.invoiced
+        self.assertNotEqual(previous_used_amount, used_amount)
+        self.assertEqual(used_amount, invoice.amount_total)
+        self.assertEqual(self.doi_in.state, "active")
+
+    def test_out_invoice_with_two_taxes(self):
+        tax2 = self.tax_model.create(
+            {
+                "l10n_it_exempt_reason": "N4",
+                "l10n_it_law_reference": "Dumb tax for test",
+                "type_tax_use": "purchase",
+                "name": "0% dumb tax",
+                "amount": 0,
+                "tax_group_id": self.tax_group.id,
+            }
+        )
+        invoice = self._create_invoice(
+            "1", self.partner, taxes=self.tax | tax2, in_type=True
+        )
+
         previous_used_amount = self.doi_in.invoiced
         invoice.action_post()
         used_amount = self.doi_in.invoiced