[FIX] l10n_es_vat_prorate: Check that bill with prorate has prorate lines

MT-13468

Author: Andrii Kompaniiets

l10n_es_vat_prorate/i18n/es.po

@@ -6,9 +6,9 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 16.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: \n"
-"PO-Revision-Date: 2025-07-16 18:22+0200\n"
-"Last-Translator: Pedro M. Baeza <pedro.baeza@tecnativa.com>\n"
+"POT-Creation-Date: 2026-01-28 09:36+0000\n"
+"PO-Revision-Date: 2026-01-28 10:37+0100\n"
+"Last-Translator: Andrii Kompaniiets <andrii@moduon.team>\n"
 "Language-Team: none\n"
 "Language: es\n"
 "MIME-Version: 1.0\n"
@@ -69,17 +69,27 @@ msgstr "ID (identificación)"
 
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,help:l10n_es_vat_prorate.field_res_company_vat_prorate__special_vat_prorate_default
+#, fuzzy
+#| msgid ""
+#| "If the Special VAT Prorate is enabled, this value indicates whether all "
+#| "the invoice lines will be prorated by default"
 msgid ""
 "If the Special VAT Prorate is enabled, this value indicates whether all the "
-"invoice lines will be prorated by default"
+"invoice lines will be prorated by default. On the other hand, all the "
+"invoice lines will be not prorated by default."
 msgstr ""
 "Si la prorrata especial de IVA esta establecida, este valor indica si todas "
 "las líneas de factura serán prorrateadas por defecto"
 
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,help:l10n_es_vat_prorate.field_res_company_vat_prorate__type
+#, fuzzy
+#| msgid ""
+#| "If the special prorate is enabled, you will be able to select which "
+#| "invoice lines will be prorated."
 msgid ""
-"If the special prorate is enabled, you will be able to select which invoice "
+"If the general prorate is enabled, all invoice lines will be prorated. If "
+"the special prorate is enabled, you will be able to select which invoice "
 "lines will be prorated."
 msgstr ""
 "Si la prorrata especial esta establecida, podrás seleccionar que lineas de "
@@ -121,7 +131,6 @@ msgstr "Última Actualización el"
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_bank_statement_line__prorate_id
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_move__prorate_id
-#: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_payment__prorate_id
 msgid "Prorate"
 msgstr "Prorrata"
 
@@ -130,6 +139,13 @@ msgstr "Prorrata"
 msgid "Prorate Account"
 msgstr "Cuenta prorrateada"
 
+#. module: l10n_es_vat_prorate
+#: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_move_line__prorate_line_ids
+#, fuzzy
+#| msgid "Prorate"
+msgid "Prorate Line"
+msgstr "Prorrata"
+
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields.selection,name:l10n_es_vat_prorate.selection__res_company_vat_prorate__type__special
 msgid "Special"
@@ -145,16 +161,21 @@ msgstr "Prorrata especial de IVA por defecto"
 msgid "Tax"
 msgstr "Impuesto"
 
+#. module: l10n_es_vat_prorate
+#. odoo-python
+#: code:addons/l10n_es_vat_prorate/models/account_move.py:0
+msgid ""
+"The invoice [ID %(invoice_id)s] cannot be posted. It is necessary to verify "
+"that the VAT prorate has been applied correctly."
+msgstr ""
+"No se puede confirmar la factura [ID %(invoice_id)s] es necesario comprobar "
+"que la prorrata del IVA se ha aplicado correctamente."
+
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,help:l10n_es_vat_prorate.field_account_move_line__vat_prorate
 msgid "The line is a vat prorate"
 msgstr "La línea es una prorrata de IVA"
 
-#. module: l10n_es_vat_prorate
-#: model:ir.model.fields,help:l10n_es_vat_prorate.field_account_move_line__with_vat_prorate
-msgid "The line will create a vat prorate"
-msgstr "La línea creará una prorrata de IVA"
-
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_res_company_vat_prorate__type
 msgid "Type"
@@ -172,44 +193,49 @@ msgstr "Tabla de prorrateo del IVA"
 
 #. module: l10n_es_vat_prorate
 #: model:ir.model.constraint,message:l10n_es_vat_prorate.constraint_res_company_vat_prorate_vat_prorate_percent_amount
-msgid "VAT prorate must be between 0.01 and 100!"
+#, fuzzy
+#| msgid "VAT prorate must be between 0.01 and 100!"
+msgid "VAT prorate must be between 0.01 and 99.9!"
 msgstr "¡La prorrata del IVA debe estar comprendida entre 0,01 y 100!"
 
-#. module: l10n_es_vat_prorate
-#: model_terms:ir.ui.view,arch_db:l10n_es_vat_prorate.account_move_form_view
-msgid "VAT prorate?"
-msgstr "¿Prorrata IVA?"
-
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_res_company__vat_prorate_ids
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_res_company_vat_prorate__vat_prorate
+#: model_terms:ir.ui.view,arch_db:l10n_es_vat_prorate.account_move_form_view
 msgid "Vat Prorate"
 msgstr "Prorrata del IVA"
 
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_bank_statement_line__with_special_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_move__with_special_vat_prorate
-#: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_payment__with_special_vat_prorate
 msgid "With Special Vat Prorate"
 msgstr "Con prorrata especial de IVA"
 
 #. module: l10n_es_vat_prorate
-#: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_move_line__with_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_tax__with_vat_prorate
 #: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_res_company__with_vat_prorate
 msgid "With VAT Prorate"
 msgstr "Con prorrata de IVA"
 
 #. module: l10n_es_vat_prorate
-#. odoo-python
-#: code:addons/l10n_es_vat_prorate/models/res_company.py:0
-#, python-format
-msgid "You can't have a special VAT prorrate of 100%"
-msgstr "No puede tener una prorrata especial de IVA del 100%"
+#: model:ir.model.fields,field_description:l10n_es_vat_prorate.field_account_move_line__with_vat_prorate
+#, fuzzy
+#| msgid "With VAT Prorate"
+msgid "With Vat Prorate"
+msgstr "Con prorrata de IVA"
 
 #. module: l10n_es_vat_prorate
 #. odoo-python
 #: code:addons/l10n_es_vat_prorate/models/res_company.py:0
-#, python-format
 msgid "You must complete VAT prorate information"
 msgstr "Debe cumplimentar la información sobre el prorrateo del IVA"
+
+#~ msgid "The line will create a vat prorate"
+#~ msgstr "La línea creará una prorrata de IVA"
+
+#~ msgid "VAT prorate?"
+#~ msgstr "¿Prorrata IVA?"
+
+#, python-format
+#~ msgid "You can't have a special VAT prorrate of 100%"
+#~ msgstr "No puede tener una prorrata especial de IVA del 100%"

l10n_es_vat_prorate/i18n/l10n_es_vat_prorate.pot

@@ -4,8 +4,10 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 18.0\n"
+"Project-Id-Version: Odoo Server 18.0+e\n"
 "Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2026-01-28 09:36+0000\n"
+"PO-Revision-Date: 2026-01-28 09:36+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -141,6 +143,14 @@ msgstr ""
 msgid "Tax"
 msgstr ""
 
+#. module: l10n_es_vat_prorate
+#. odoo-python
+#: code:addons/l10n_es_vat_prorate/models/account_move.py:0
+msgid ""
+"The invoice [ID %(invoice_id)s] cannot be posted. It is necessary to verify "
+"that the VAT prorate has been applied correctly."
+msgstr ""
+
 #. module: l10n_es_vat_prorate
 #: model:ir.model.fields,help:l10n_es_vat_prorate.field_account_move_line__vat_prorate
 msgid "The line is a vat prorate"

l10n_es_vat_prorate/models/account_move.py

@@ -4,6 +4,7 @@
 
 
 from odoo import api, fields, models
+from odoo.exceptions import ValidationError
 from odoo.tools import float_round
 
 
@@ -255,6 +256,39 @@ def write(self, vals):
                 move._apply_vat_prorate()
         return res
 
+    def _check_prorate_applied(self):
+        self.ensure_one()
+        if (
+            self.company_id.with_vat_prorate
+            and self.prorate_id
+            and self.prorate_id.type == "general"
+            and any(
+                [
+                    invoice_line.with_vat_prorate
+                    for invoice_line in self.invoice_line_ids
+                ]
+            )
+            and any(self.invoice_line_ids.tax_ids.mapped("with_vat_prorate"))
+            and not [line for line in self.line_ids if line.vat_prorate]
+        ):
+            return False
+        return True
+
+    def _post(self, soft):
+        for invoice in self.filtered_domain(
+            [("move_type", "in", ["in_invoice", "in_refund"])]
+        ):
+            if not invoice._check_prorate_applied():
+                raise ValidationError(
+                    self.env._(
+                        "The invoice [ID %(invoice_id)s] cannot be posted. "
+                        "It is necessary to verify that the VAT prorate "
+                        "has been applied correctly.",
+                        invoice_id=invoice.id,
+                    )
+                )
+        return super()._post(soft)
+
 
 class AccountMoveLine(models.Model):
     _inherit = "account.move.line"

l10n_es_vat_prorate/views/account_move_views.xml

@@ -24,6 +24,7 @@
                 <field
                     name="with_vat_prorate"
                     string="Vat Prorate"
+                    readonly="not parent.with_special_vat_prorate or parent.move_type not in ['in_invoice', 'in_refund']"
                     column_invisible="not parent.with_special_vat_prorate or parent.move_type not in ['in_invoice', 'in_refund']"
                 />
             </xpath>