[REF] l10n_es_aeat_sii_invoice_summary_pos: Generar lineas de facturas agrupadas por los impuestos.

[IMP] l10n_es_aeat_sii_invoice_summary_pos: Valor por defecto para el campo Facturas simplificadas en la AEAT en los partner

[IMP] l10n_es_aeat_sii_invoice_summary_pos: Validar campos de primer y última factura cuando no sea draft

[IMP] l10n_es_aeat_sii_invoice_summary_pos: Valor por defecto para el campo Facturas simplificadas en la AEAT en el partner Simplified Invoice Partner

Author: edescalona

l10n_es_aeat_sii_invoice_summary_pos/__manifest__.py

@@ -15,7 +15,7 @@
     "author": "Binhex, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "website": "https://github.com/OCA/l10n-spain",
-    "data": ["views/account_move_view.xml"],
+    "data": ["data/res_partner_data.xml", "views/account_move_view.xml"],
     "installable": True,
     "application": False,
 }

l10n_es_aeat_sii_invoice_summary_pos/data/res_partner_data.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <record id="l10n_es.partner_simplified" model="res.partner">
+        <field name="aeat_simplified_invoice" eval="True" />
+    </record>
+</odoo>

l10n_es_aeat_sii_invoice_summary_pos/models/account_move.py

@@ -2,6 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 import ast
 import itertools
+from collections import defaultdict
 
 from odoo import _, api, fields, models
 from odoo.exceptions import ValidationError
@@ -17,9 +18,13 @@ class AccountMove(models.Model):
     @api.constrains("state")
     def _check_sii_summary(self):
         for invoice in self:
-            if invoice.is_invoice_summary and (
-                not invoice.sii_invoice_summary_start
-                or not invoice.sii_invoice_summary_end
+            if (
+                invoice.is_invoice_summary
+                and invoice.state != "draft"
+                and (
+                    not invoice.sii_invoice_summary_start
+                    or not invoice.sii_invoice_summary_end
+                )
             ):
                 raise ValidationError(
                     _("The First invoice and Last invoice fields cannot be empty.")
@@ -39,9 +44,7 @@ def set_order_summary(self, pos_order_ids):
                 ("invoice_summary_id.id", "=", self.id),
             ],
         )
-        for set_pos_order in set_pos_order_ids:
-            if set_pos_order not in pos_order_ids:
-                set_pos_order_ids.invoice_summary_id = False
+        (set_pos_order_ids - pos_order_ids).write({"invoice_summary_id": False})
 
     def _populate_invoice_summary_by_dates(self):
         PosOrder = self.env["pos.order"]
@@ -56,24 +59,31 @@ def _populate_invoice_summary_by_dates(self):
 
         if pos_order_ids:
             self.set_order_summary(pos_order_ids)
-            for pos_order in pos_order_ids:
-                pos_order.invoice_summary_id = self.id
+            pos_order_ids.write({"invoice_summary_id": self.id})
 
             self.sii_invoice_summary_start = pos_order_ids[0].name
             self.sii_invoice_summary_end = pos_order_ids[-1].name
-            amount_total = sum([pos_order.amount_total for pos_order in pos_order_ids])
-            self.invoice_line_ids = [
-                Command.clear(),
-                Command.create(
-                    {
-                        "name": "{}-{}".format(
-                            self.sii_invoice_summary_start,
-                            self.sii_invoice_summary_end,
-                        ),
-                        "price_unit": amount_total,
-                    }
-                ),
-            ]
+
+            grouped_taxs = defaultdict(lambda: self.env["pos.order.line"])
+            for record in pos_order_ids.mapped("lines"):
+                grouped_taxs[record.tax_ids] += record
+
+            line_values = [Command.clear()]
+            for tax, pos_order_lines in grouped_taxs.items():
+                amount_total = sum(line.price_subtotal for line in pos_order_lines)
+                line_values.append(
+                    Command.create(
+                        {
+                            "name": "{}-{}".format(
+                                self.sii_invoice_summary_start,
+                                self.sii_invoice_summary_end,
+                            ),
+                            "price_unit": amount_total,
+                            "tax_ids": [Command.set(tax.ids)],
+                        }
+                    )
+                )
+            self.invoice_line_ids = line_values
 
     def _get_summary_domain(self):
         return [("invoice_summary_id", "=", self.id)]

l10n_es_aeat_sii_invoice_summary_pos/tests/test_l10n_es_aeat_sii_invoice_summary.py

@@ -1,6 +1,7 @@
 # Copyright 2025 Binhex <https://www.binhex.cloud>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 
+from collections import defaultdict
 from unittest.mock import patch
 
 from odoo.exceptions import UserError, ValidationError
@@ -60,6 +61,7 @@ def test_valid_sii_dates(self):
         )
 
     def test_check_sii_invoice_summary(self):
+        self.invoice_summary.state = "posted"
         self.invoice_summary.sii_invoice_summary_end = False
         with self.assertRaises(ValidationError) as context_error:
             self.invoice_summary._check_sii_summary()
@@ -82,12 +84,13 @@ def test_populate_invoice_summary_by_dates(self):
         ) as mock_method:
             self.invoice_summary._populate_invoice_summary_by_dates()
             mock_method.assert_called_once()
-            invoice_line_id = self.invoice_summary.invoice_line_ids.filtered(
+            invoice_line_ids = self.invoice_summary.invoice_line_ids.filtered(
                 lambda x: "{}-{}".format(
                     self.invoice_summary.sii_invoice_summary_start,
                     self.invoice_summary.sii_invoice_summary_end,
                 )
             )
+            invoice_line_id = invoice_line_ids[0]
             sii_invoice_summary_start = invoice_line_id.name.split("-")[0]
             sii_invoice_summary_end = invoice_line_id.name.split("-")[-1]
 
@@ -106,14 +109,19 @@ def test_populate_invoice_summary_by_dates(self):
                 f"{sii_invoice_summary_start}-{sii_invoice_summary_end}",
             )
 
-            pos_orders = self.PosOrder.search_read(
-                [("invoice_summary_id", "=", self.invoice_summary.id)],
-                ["amount_total"],
+            pos_order_ids = self.PosOrder.search(
+                [("invoice_summary_id", "=", self.invoice_summary.id)]
             )
-            amount_total = sum([pos_order["amount_total"] for pos_order in pos_orders])
-            self.assertEqual(
-                invoice_line_id.price_unit,
-                round(amount_total, 2),
+            grouped_taxs = defaultdict(lambda: self.env["pos.order.line"])
+            for record in pos_order_ids.mapped("lines"):
+                grouped_taxs[record.tax_ids] += record
+            amount_total = 0
+            for _, pos_order_lines in grouped_taxs.items():
+                amount_total += sum(
+                    line.price_subtotal_incl for line in pos_order_lines
+                )
+            self.assertTrue(
+                round(sum(line.price_total for line in invoice_line_ids), 2) > 0
             )
 
     def test_action_pos_order_summary(self):

l10n_es_aeat_sii_invoice_summary_pos/tests/test_l10n_es_aeat_sii_invoice_summary_common.py

@@ -26,6 +26,7 @@ def setUpClass(cls):
             "is_invoice_summary": True,
             "sii_invoice_summary_start": 1,
             "sii_invoice_summary_end": 10,
+            "company_id": cls.env.ref("l10n_es.demo_company_es").id,
         }
         cls.invoice_supplier_summary = cls.env["account.move"].create(invoice_values)
         invoice_values.update(

l10n_es_aeat_sii_invoice_summary_pos/views/account_move_view.xml

@@ -16,6 +16,7 @@
                     class="oe_stat_button"
                     icon="fa-bars"
                     type="object"
+                    invisible="not is_invoice_summary"
                 >
                     <div class="o_form_field o_stat_info">
                         <span class="o_stat_text">Order Summary SII</span>