[MIG] mail_tracking: Migration to 19.0

Author: quoc-pn

mail_tracking/README.rst

@@ -21,13 +21,13 @@ Email tracking
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github
-    :target: https://github.com/OCA/mail/tree/18.0/mail_tracking
+    :target: https://github.com/OCA/mail/tree/19.0/mail_tracking
     :alt: OCA/mail
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_tracking
+    :target: https://translation.odoo-community.org/projects/mail-19-0/mail-19-0-mail_tracking
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/mail&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/mail&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -113,18 +113,18 @@ records with messages in failed status and that needs an user action.
 
   |image2|
 
-.. |unknown| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/unknown.png
-.. |waiting| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/waiting.png
-.. |error| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/error.png
-.. |sent| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/sent.png
-.. |delivered| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/delivered.png
-.. |opened| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/opened.png
-.. |cc| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/cc.png
-.. |noemail| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/no_email.png
-.. |anonuser| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/src/img/anon_user.png
-.. |image| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/img/failed_message_discuss.png
-.. |image1| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/img/failed_message_widget.png
-.. |image2| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_tracking/static/img/failed_message_filter.png
+.. |unknown| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/unknown.png
+.. |waiting| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/waiting.png
+.. |error| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/error.png
+.. |sent| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/sent.png
+.. |delivered| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/delivered.png
+.. |opened| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/opened.png
+.. |cc| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/cc.png
+.. |noemail| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/no_email.png
+.. |anonuser| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/src/img/anon_user.png
+.. |image| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/img/failed_message_discuss.png
+.. |image1| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/img/failed_message_widget.png
+.. |image2| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_tracking/static/img/failed_message_filter.png
 
 Known issues / Roadmap
 ======================
@@ -139,7 +139,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/mail/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/mail/issues/new?body=module:%20mail_tracking%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/mail/issues/new?body=module:%20mail_tracking%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -175,6 +175,10 @@ Contributors
 
   - Tris Doan
 
+- `Komit <https://komit-consulting.com>`__:
+
+  - Quoc Pham Ngoc
+
 Other credits
 -------------
 
@@ -194,6 +198,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/mail <https://github.com/OCA/mail/tree/18.0/mail_tracking>`_ project on GitHub.
+This module is part of the `OCA/mail <https://github.com/OCA/mail/tree/19.0/mail_tracking>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

mail_tracking/__init__.py

@@ -1,3 +1,2 @@
 from . import controllers
 from . import models
-from . import wizards

mail_tracking/__manifest__.py

@@ -7,7 +7,7 @@
 {
     "name": "Email tracking",
     "summary": "Email tracking system for all mails sent",
-    "version": "18.0.1.0.8",
+    "version": "19.0.1.0.0",
     "category": "Social Network",
     "website": "https://github.com/OCA/mail",
     "author": ("Tecnativa, Odoo Community Association (OCA)"),

mail_tracking/controllers/mailbox.py

@@ -7,7 +7,7 @@
 
 
 class MailTrackingMailBoxController(MailboxController):
-    @route("/mail/failed/messages", methods=["POST"], type="json", auth="user")
+    @route("/mail/failed/messages", methods=["POST"], type="jsonrpc", auth="user")
     def discuss_failed_messages(
         self, search_term=None, before=None, after=None, limit=30, around=None
     ):
@@ -23,6 +23,6 @@ def discuss_failed_messages(
         messages = res.pop("messages")
         return {
             **res,
-            "data": Store(messages, for_current_user=True).get_result(),
-            "messages": Store.many_ids(messages),
+            "data": Store().add(messages).get_result(),
+            "messages": messages.ids,
         }

mail_tracking/models/ir_mail_server.py

@@ -38,7 +38,7 @@ def _tracking_img_remove(self, body):
             r'<img[^>]*data-odoo-tracking-email=["\'][0-9]*["\'][^>]*>', "", body
         )
 
-    def build_email(
+    def _build_email__(
         self,
         email_from,
         email_to,
@@ -78,11 +78,11 @@ def build_email(
             # the tracking image in case it's to be disabled
             if self._tracking_img_disabled(tracking_email_id):
                 body = self._tracking_img_remove(body)
-        msg = super().build_email(
-            email_from=email_from,
-            email_to=email_to,
-            subject=subject,
-            body=body,
+        return super()._build_email__(
+            email_from,
+            email_to,
+            subject,
+            body,
             email_cc=email_cc,
             email_bcc=email_bcc,
             reply_to=reply_to,
@@ -95,7 +95,6 @@ def build_email(
             body_alternative=body_alternative,
             subtype_alternative=subtype_alternative,
         )
-        return msg
 
     def _tracking_email_get(self, message):
         try:

mail_tracking/models/mail_alias.py

@@ -15,7 +15,9 @@ def get_aliases(self):
             x["display_name"]
             for x in self.search_read([("alias_name", "!=", False)], ["display_name"])
         }
-        mail_alias_domain = self.env["mail.alias.domain"].search([])
+        mail_alias_domain = self.env["mail.alias.domain"].search_fetch(
+            [], field_names=["catchall_email", "default_from", "default_from_email"]
+        )
         catchall_emails = set(mail_alias_domain.mapped("catchall_email"))
         default_from_emails = set(
             mail_alias_domain.filtered("default_from").mapped("default_from_email")

mail_tracking/models/mail_mail.py

@@ -28,16 +28,17 @@ def _tracking_email_prepare(self, email):
             "sender": self.email_from,
         }
 
-    def _prepare_outgoing_list(
-        self, mail_server=False, recipients_follower_status=None
-    ):
+    def _prepare_outgoing_list(self, mail_server=False, doc_to_followers=None):
         """Creates the mail.tracking.email record and adds the image tracking
         to the email. Please note that because we can't add mail headers in this
         function, the added tracking image will later (IrMailServer.build_email)
         also be used to extract the mail.tracking.email record id and to set the
         X-Odoo-MailTracking-ID header there.
         """
-        emails = super()._prepare_outgoing_list(mail_server, recipients_follower_status)
+        emails = super()._prepare_outgoing_list(
+            mail_server=mail_server,
+            doc_to_followers=doc_to_followers,
+        )
         tracking_vals_list = [self._tracking_email_prepare(email) for email in emails]
         trackings = self.env["mail.tracking.email"].sudo().create(tracking_vals_list)
         for email, tracking in zip(emails, trackings, strict=True):

mail_tracking/models/mail_message.py

@@ -5,7 +5,7 @@
 from email.utils import getaddresses
 
 from odoo import api, fields, models
-from odoo.osv import expression
+from odoo.fields import Domain
 from odoo.tools import email_split
 
 from odoo.addons.mail.tools.discuss import Store
@@ -22,7 +22,7 @@ class MailMessage(models.Model):
     mail_tracking_ids = fields.One2many(
         comodel_name="mail.tracking.email",
         inverse_name="mail_message_id",
-        auto_join=True,
+        bypass_search_access=True,
         string="Mail Trackings",
     )
     mail_tracking_needs_action = fields.Boolean(
@@ -73,7 +73,7 @@ def _search_is_failed_message(self, operator, operand):
         )
         self.env["mail.notification"].flush_model(["mail_message_id", "res_partner_id"])
         self.env["mail.tracking.email"].flush_model(["state"])
-        is_involve = expression.OR(
+        is_involve = Domain.OR(
             [
                 [
                     ("notification_ids.res_partner_id", "=", pid),
@@ -83,7 +83,7 @@ def _search_is_failed_message(self, operator, operand):
                 ],
             ]
         )
-        domain = expression.AND(
+        domain = Domain.AND(
             [
                 [
                     (
@@ -177,7 +177,7 @@ def tracking_status(self):
                     "recipient": recipient,
                     "partner_id": tracking.partner_id.id,
                     "isCc": False,
-                    "tracking_delta": "%i-%i" % (self.id, tracking_delta),
+                    "tracking_delta": f"{self.id}-{tracking_delta}",
                 }
             )
             if tracking.partner_id:
@@ -218,7 +218,7 @@ def tracking_status(self):
                     "recipient": partner.name,
                     "partner_id": partner.id,
                     "isCc": isCc,
-                    "tracking_delta": "%i-%i" % (self.id, tracking_delta),
+                    "tracking_delta": f"{self.id}-{tracking_delta}",
                 }
             )
             partner_trackings.append(tracking_status)
@@ -232,7 +232,7 @@ def tracking_status(self):
                         "recipient": email,
                         "partner_id": False,
                         "isCc": cc,
-                        "tracking_delta": "%i-%i" % (self.id, tracking_delta),
+                        "tracking_delta": f"{self.id}-{tracking_delta}",
                     }
                 )
                 partner_trackings.append(tracking_status)

mail_tracking/models/mail_thread.py

@@ -6,7 +6,7 @@
 from lxml import etree
 
 from odoo import api, fields, models
-from odoo.tools.mail import email_split, email_split_and_format
+from odoo.tools.mail import email_split_and_format_normalize
 
 
 class MailThread(models.AbstractModel):
@@ -62,42 +62,27 @@ def _routing_handle_bounce(self, email_message, message_dict):
             mail_trackings.event_create("soft_bounce", message_dict)
         return super()._routing_handle_bounce(email_message, message_dict)
 
-    def _message_get_suggested_recipients(self):
-        """Adds email 'extra' recipients as suggested recipients.
-
-        If the recipient has a res.partner, use it.
-        """
-        res = super()._message_get_suggested_recipients()
-        self._add_extra_recipients_suggestions(res, "email_cc", self.env._("Cc"))
-        self._add_extra_recipients_suggestions(res, "email_to", self.env._("Anon. To"))
-        return res
-
-    def _add_extra_recipients_suggestions(self, suggestions, field_mail, reason):
-        ResPartnerObj = self.env["res.partner"]
-        aliases = self.env["mail.alias"].get_aliases()
-        email_extra_formated_list = []
+    def _message_add_suggested_recipients(self, force_primary_email=False):
+        suggested = super()._message_add_suggested_recipients(
+            force_primary_email=force_primary_email
+        )
         for record in self:
-            emails_extra = record.message_ids.mapped(field_mail)
-            for email in emails_extra:
-                email_extra_formated_list.extend(email_split_and_format(email))
-        email_extra_formated_list = set(email_extra_formated_list)
-        email_extra_list = [x[1] for x in getaddresses(email_extra_formated_list)]
-        partners_info = self.sudo()._message_partner_info_from_emails(email_extra_list)
-        for pinfo in partners_info:
-            partner_id = pinfo["partner_id"]
-            email_formed = email_split(pinfo["full_name"])
-            email = email_formed and email_formed[0].lower()
-            if not partner_id:
-                if email not in aliases:
-                    self._message_add_suggested_recipient(
-                        suggestions, email=email, reason=reason
-                    )
-            else:
-                partner = ResPartnerObj.browse(partner_id)
-                if partner.email not in aliases:
-                    self._message_add_suggested_recipient(
-                        suggestions, partner=partner, reason=reason
-                    )
+            self._add_extra_recipients_suggestions(record, suggested, "email_cc")
+            self._add_extra_recipients_suggestions(record, suggested, "email_to")
+        return suggested
+
+    def _add_extra_recipients_suggestions(self, record, suggestions, field_mail):
+        email_extra_formatted_list = []
+        emails_extra = record.message_ids.mapped(field_mail)
+        for email in emails_extra:
+            email_extra_formatted_list.extend(email_split_and_format_normalize(email))
+        email_extra_formatted_list = set(email_extra_formatted_list)
+        email_extra_list = [x[1] for x in getaddresses(email_extra_formatted_list)]
+        for email in email_extra_list:
+            if email not in suggestions[record.id]["email_to_lst"]:
+                suggestions[record.id]["email_to_lst"] += (
+                    email_split_and_format_normalize(email)
+                )
 
     @api.model
     def get_view(self, view_id=None, view_type="form", **options):

mail_tracking/models/mail_tracking_email.py

@@ -140,18 +140,14 @@ def write(self, vals):
         return res
 
     @api.model
-    def _search(
-        self,
-        domain,
-        offset=0,
-        limit=None,
-        order=None,
-    ):
+    def _search(self, domain, offset=0, limit=None, order=None, **kwargs):
         """Override that adds specific access rights of mail.tracking.email, to remove
         ids uid could not see according to our custom rules. Please refer to
         _check_access() for more details about those rules.
         """
-        query = super()._search(domain, offset, limit, order)
+        query = super()._search(
+            domain, offset=offset, limit=limit, order=order, **kwargs
+        )
         if not self.env.is_superuser():
             records = self.browse(query)
             allowed_ids = self._get_allowed_ids(records.ids)
@@ -289,12 +285,12 @@ def _email_last_tracking_state(self, email):
     def email_score_from_email(self, email):
         if not email:
             return 0.0
-        data = self.sudo().read_group(
-            [("recipient_address", "=", email.lower())],
-            ["recipient_address", "state"],
-            ["state"],
+        groups = self.sudo()._read_group(
+            domain=[("recipient_address", "=", email.lower())],
+            groupby=["state"],
+            aggregates=["recipient_address:count"],
         )
-        mapped_data = {state["state"]: state["state_count"] for state in data}
+        mapped_data = {state: count for (state, count) in groups}
         return self.with_context(mt_states=mapped_data).sudo().email_score()
 
     @api.model