[MIG] mail_tracking_mass_mailing: Migration to 19.0

Author: quoc-pn

mail_tracking_mass_mailing/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 ==============================
 Mail tracking for mass mailing
 ==============================
@@ -13,17 +17,17 @@ Mail tracking for mass mailing
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github
-    :target: https://github.com/OCA/mail/tree/18.0/mail_tracking_mass_mailing
+    :target: https://github.com/OCA/mail/tree/19.0/mail_tracking_mass_mailing
     :alt: OCA/mail
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_tracking_mass_mailing
+    :target: https://translation.odoo-community.org/projects/mail-19-0/mail-19-0-mail_tracking_mass_mailing
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/mail&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/mail&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -64,7 +68,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/mail/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/mail/issues/new?body=module:%20mail_tracking_mass_mailing%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/mail/issues/new?body=module:%20mail_tracking_mass_mailing%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -94,6 +98,10 @@ Contributors
   - nguyenhk <nguyenhk@trobz.com>
   - Tris Doan <tridm@trobz.com>
 
+- `Komit <https://komit-consulting.com>`__:
+
+  - Quoc Pham Ngoc <quoc-pn@komit-consulting.com>
+
 Other credits
 -------------
 
@@ -113,6 +121,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/mail <https://github.com/OCA/mail/tree/18.0/mail_tracking_mass_mailing>`_ project on GitHub.
+This module is part of the `OCA/mail <https://github.com/OCA/mail/tree/19.0/mail_tracking_mass_mailing>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

mail_tracking_mass_mailing/__manifest__.py

@@ -7,7 +7,7 @@
 {
     "name": "Mail tracking for mass mailing",
     "summary": "Improve mass mailing email tracking",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "category": "Social Network",
     "website": "https://github.com/OCA/mail",
     "author": "Tecnativa, Odoo Community Association (OCA)",

mail_tracking_mass_mailing/models/mail_mail.py

@@ -24,7 +24,7 @@ def _get_tracking_url(self):
         return False
 
     def _postprocess_sent_message(
-        self, success_pids, failure_reason=False, failure_type=None
+        self, success_pids, success_emails, failure_reason=False, failure_type=None
     ):
         """Set mailing traces in error according to mail tracking state
 
@@ -59,5 +59,5 @@ def _postprocess_sent_message(
             MailMail,
             self.with_context(_ignore_write_trace_postprocess_ids=processed_ids),
         )._postprocess_sent_message(
-            success_pids, failure_reason=failure_reason, failure_type=failure_type
+            success_pids, success_emails, failure_reason, failure_type
         )

mail_tracking_mass_mailing/readme/CONTRIBUTORS.md

@@ -10,3 +10,6 @@
 - [Trobz](https://trobz.com):
   - nguyenhk \<<nguyenhk@trobz.com>\>
   - Tris Doan \<<tridm@trobz.com>\>
+
+- [Komit](https://komit-consulting.com):
+  - Quoc Pham Ngoc \<<quoc-pn@komit-consulting.com>\>

mail_tracking_mass_mailing/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>Mail tracking for mass mailing</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
@@ -360,16 +360,21 @@
 </style>
 </head>
 <body>
-<div class="document" id="mail-tracking-for-mass-mailing">
-<h1 class="title">Mail tracking for mass mailing</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="mail-tracking-for-mass-mailing">
+<h1>Mail tracking for mass mailing</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:4c0589bdbbc642fc4bb1bf93ef961b1af0bd5820a6aee9a0218de746e537f869
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/mail/tree/18.0/mail_tracking_mass_mailing"><img alt="OCA/mail" src="https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_tracking_mass_mailing"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/mail&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/mail/tree/19.0/mail_tracking_mass_mailing"><img alt="OCA/mail" src="https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/mail-19-0/mail-19-0-mail_tracking_mass_mailing"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/mail&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Links mail statistics objects with mail tracking objects.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -387,12 +392,12 @@ <h1 class="title">Mail tracking for mass mailing</h1>
 </ul>
 </div>
 <div class="section" id="installation">
-<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Installation</a></h2>
 <p>This addon will be automatically installed when <tt class="docutils literal">mail_tracking</tt> and
 <tt class="docutils literal">mass_mailing</tt> are both installed.</p>
 </div>
 <div class="section" id="usage">
-<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Usage</a></h2>
 <p>From mail statistic object, you can see:</p>
 <ul class="simple">
 <li>Email tracking state</li>
@@ -408,23 +413,23 @@ <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 mailing.</p>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/mail/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/mail/issues/new?body=module:%20mail_tracking_mass_mailing%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/mail/issues/new?body=module:%20mail_tracking_mass_mailing%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-4">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Authors</a></h3>
 <ul class="simple">
 <li>Tecnativa</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-6">Contributors</a></h3>
 <ul class="simple">
 <li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:<ul>
 <li>Pedro M. Baeza</li>
@@ -441,26 +446,31 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Tris Doan &lt;<a class="reference external" href="mailto:tridm&#64;trobz.com">tridm&#64;trobz.com</a>&gt;</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://komit-consulting.com">Komit</a>:<ul>
+<li>Quoc Pham Ngoc &lt;<a class="reference external" href="mailto:quoc-pn&#64;komit-consulting.com">quoc-pn&#64;komit-consulting.com</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
-<h2><a class="toc-backref" href="#toc-entry-7">Other credits</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-7">Other credits</a></h3>
 <p>The migration of this module from 17.0 to 18.0 was financially supported
 by Camptocamp.</p>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
 </a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/mail/tree/18.0/mail_tracking_mass_mailing">OCA/mail</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/mail/tree/19.0/mail_tracking_mass_mailing">OCA/mail</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

mail_tracking_mass_mailing/tests/test_mass_mailing.py

@@ -9,13 +9,13 @@
 from odoo.tests.common import TransactionCase, tagged
 from odoo.tools import mute_logger
 
-from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
+from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT, MockSmtplibCase
 
-mock_send_email = "odoo.addons.base.models.ir_mail_server.IrMailServer.send_email"
+mock_send_email = "odoo.addons.base.models.ir_mail_server.IrMail_Server.send_email"
 
 
 @tagged("-at_install", "post_install")
-class TestMassMailing(TransactionCase):
+class TestMassMailing(TransactionCase, MockSmtplibCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -47,7 +47,8 @@ def setUpClass(cls):
     def test_smtp_error(self):
         with mock.patch(mock_send_email) as mock_func:
             mock_func.side_effect = Warning("Mock test error")
-            self.mailing.action_send_mail()
+            with self.mock_smtplib_connection():
+                self.mailing.action_send_mail()
             for stat in self.mailing.mailing_trace_ids:
                 if stat.mail_mail_id:
                     stat.mail_mail_id.send()
@@ -63,7 +64,8 @@ def test_smtp_error(self):
             self.assertTrue(self.contact_a.email_bounced)
 
     def test_tracking_email_link(self):
-        self.mailing.action_send_mail()
+        with self.mock_smtplib_connection():
+            self.mailing.action_send_mail()
         for stat in self.mailing.mailing_trace_ids:
             if stat.mail_mail_id:
                 stat.mail_mail_id.send()
@@ -85,7 +87,8 @@ def test_tracking_email_link(self):
             self.assertEqual(stat.trace_status, "open")
 
     def _tracking_email_bounce(self, event_type, state):
-        self.mailing.action_send_mail()
+        with self.mock_smtplib_connection():
+            self.mailing.action_send_mail()
         for stat in self.mailing.mailing_trace_ids:
             if stat.mail_mail_id:
                 stat.mail_mail_id.send()