[18.0][MIG] fetchmail_mail_activity_team_activity: Migration to 18.0

Author: hitesh-erpharbor

fetchmail_mail_activity_team_activity/README.rst

@@ -1,79 +1,35 @@
 ==========================================
-Mail Activity Fetchmail with Team Activity
+Mail Activity Fetchmail With Team Activity
 ==========================================
 
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! This file is generated by oca-gen-addon-readme !!
-   !! changes will be overwritten.                   !!
-   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-
-.. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png
-    :target: https://odoo-community.org/page/development-status
-    :alt: Alpha
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
-    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
-    :alt: License: AGPL-3
-.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsocial-lightgray.png?logo=github
-    :target: https://github.com/OCA/social/tree/15.0/mail_activity_fetchmail
-    :alt: OCA/social
-.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_fetchmail
-    :alt: Translate me on Weblate
-.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/205/15.0
-    :alt: Try me on Runbot
-
-|badge1| |badge2| |badge3| |badge4| |badge5| 
-
-
-**Table of contents**
-
-.. contents::
-   :local:
-
 Usage
-=====
+-----
 
 Uses mail.activity.team to configure automatic activities when mails arrive for the specified models.
 
 The configuration to add RMA and PO models (Settings --> Technical --> Activity Teams menu).
 
-Bug Tracker
-===========
-
-Bugs are tracked on `GitHub Issues <https://github.com/OCA/social/issues>`_.
-In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/social/issues/new?body=module:%20mail_activity_fetchmail%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
-
-Do not contact contributors directly about support or help with technical issues.
-
-Credits
-=======
-
-Authors
-~~~~~~~
-
-* initOS GmbH
-
-Contributors
-~~~~~~~~~~~~
-
-  * isufi kapasi (isufi.kapasi@initos.com)
+Testing
+-------
 
-Maintainers
-~~~~~~~~~~~
+Team Creation:
 
-This module is maintained by the OCA.
+1. Go to: "Settings" -> "Technical" -> "Activity" -> "Activity Teams"
+2. Select or create a new team via the "+ New" button
+3. Fill in the necessary details:
 
-.. image:: https://odoo-community.org/logo.png
-   :alt: Odoo Community Association
-   :target: https://odoo-community.org
+   - Name: e.g., ´Team1´
+   - Team Leader: e.g., ´Person1´
+   - Used models: e.g., ´Sales Order´ (can be more than one model assigned)
+   - There has to be at least one "Member" per team ("Team Leader" is counted by default)
 
-OCA, or the Odoo Community Association, is a nonprofit organization whose
-mission is to support the collaborative development of Odoo features and
-promote its widespread use.
+4. Press Save
 
-This module is part of the `OCA/social <https://github.com/OCA/social/tree/15.0/mail_activity_fetchmail>`_ project on GitHub.
+Testing:
 
-You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
+1. "Sales" -> "Orders" -> "Quotations" -> "+ New"
+2. Fill in the necessary details
+3. Send a message via the chat section in the SO
+4. Check the recipients email inbox, you should have received an email
+5. Reply to it
+6. In Odoo you should see the message from the customer and a generated activity

fetchmail_mail_activity_team_activity/__init__.py

@@ -1,4 +1,3 @@
-# © 2022 initOS GmbH
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from . import models

fetchmail_mail_activity_team_activity/__manifest__.py

@@ -1,22 +1,18 @@
-# © 2022 initOS GmbH
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 {
     "name": "Mail Activity on Fetchmail with Team Activity",
-    "version": "15.0.1.0.0",
-    "development_status": "Alpha",
-    "category": "Hidden",
-    "author": "initOS GmbH, Odoo Community Association (OCA)",
-    "website": "https://github.com/OCA/social",
+    "version": "18.0.1.0.0",
+    "category": "Social Network",
+    "author": "Nitrokey GmbH, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/mail",
     "license": "AGPL-3",
     "summary": """
     * Uses mail.activity.team to configure automatic activities when mails
      arrive for the specified models.
     * The configuration to add RMA and PO models
      (Settings --> Technical --> Activity Teams menu)
      """,
-    "depends": [
-        "mail_activity_team",
-    ],
+    "depends": ["mail_activity_team", "calendar"],
     "installable": True,
 }

fetchmail_mail_activity_team_activity/i18n/fetchmail_mail_activity_team_activity.pot

@@ -1,6 +1,6 @@
 # Translation of Odoo Server.
 # This file contains the translation of the following modules:
-# 	* fetchmail_mail_activity_team_activity
+#   * fetchmail_mail_activity_team_activity
 #
 msgid ""
 msgstr ""

fetchmail_mail_activity_team_activity/models/__init__.py

@@ -1,4 +1,3 @@
-# © 2022 initOS GmbH
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from . import mail_thread

fetchmail_mail_activity_team_activity/models/mail_thread.py

@@ -1,4 +1,3 @@
-# © 2022 initOS GmbH
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo import api, models

fetchmail_mail_activity_team_activity/pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

fetchmail_mail_activity_team_activity/tests/__init__.py

@@ -1,4 +1,3 @@
-# © 2022 initOS GmbH
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from . import test_activity

fetchmail_mail_activity_team_activity/tests/test_activity.py

@@ -1,4 +1,3 @@
-# © 2022 initOS GmbH
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 import logging
@@ -11,9 +10,13 @@
 
 
 class TestActivity(TransactionCase):
+    def setUp(self):
+        super().setUp()
+        # Clean up any existing teams before each test
+        self.env["mail.activity.team"].search([]).unlink()
+
     def generate_reply(self, message):
         return (
-            # "Date: Thu, 22 Sep 2022 12:23:20 +0000",
             "From: ext.partner@example.org\r\n"
             "To: odoo.test@local\r\n"
             f"Message-ID: {uuid.uuid4()}\r\n"
@@ -22,20 +25,35 @@ def generate_reply(self, message):
         )
 
     def test_no_team(self):
+        """Test that no activity is created when no team exists"""
+        # Ensure no teams exist
+        teams = self.env["mail.activity.team"].search([])
+        self.assertEqual(len(teams), 0, "Should have no teams before test")
+
         thread = self.env.user.partner_id
         msg = thread.message_notify(
             partner_ids=self.env.user.partner_id.ids,
             body="Testing",
         )
 
-        messages = thread.message_ids
-        activities = thread.activity_ids
-        reply = self.generate_reply(msg)
+        # Record initial state
+        initial_activities = thread.activity_ids
+        initial_message_count = len(thread.message_ids)
 
+        # Process email reply
+        reply = self.generate_reply(msg)
         thread_id = thread.message_process(thread._name, reply)
-        self.assertTrue(len(messages) < len(thread.message_ids))
-        self.assertEqual(activities, thread.activity_ids)
+
+        # Assertions
         self.assertEqual(thread_id, thread.id)
+        self.assertTrue(len(thread.message_ids) > initial_message_count)
+
+        # CRITICAL: No new activity should be created
+        self.assertEqual(
+            thread.activity_ids.ids,
+            initial_activities.ids,
+            "No activity should be created when no team exists",
+        )
 
     def test_with_team(self):
         thread = self.env.user.partner_id