[IMP]purchase_product_pack: migration to 18.0

Author: matteonext

purchase_product_pack/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 =====================
 Purchase Product Pack
 =====================
@@ -7,13 +11,13 @@ Purchase Product Pack
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:1c37bc5ae3753d96b784bb15fdbed5dcbe70cafb085cb3ddde5960c03d9c85a7
+   !! source digest: sha256:c2dac7004783b8033eccca5252ad883ba2106fc36f774bb5680b539f372092be
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--pack-lightgray.png?logo=github
@@ -78,9 +82,9 @@ Authors
 Contributors
 ------------
 
--  `Trobz <https://www.trobz.com>`__:
+- `Trobz <https://www.trobz.com>`__:
 
-   -  Duong (Tran Quoc)
+  - Duong (Tran Quoc)
 
 Other credits
 -------------
@@ -89,7 +93,7 @@ Inspired by *sale_product_pack*
 
 The development of this module has been financially supported by:
 
--  Camptocamp
+- Camptocamp
 
 Maintainers
 -----------

purchase_product_pack/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 {
     "name": "Purchase Product Pack",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Purchase",
     "summary": "This module allows you to buy product packs",
     "website": "https://github.com/OCA/product-pack",

purchase_product_pack/i18n/purchase_product_pack.pot

@@ -4,7 +4,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 16.0\n"
+"Project-Id-Version: Odoo Server 18.0\n"
 "Report-Msgid-Bugs-To: \n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -78,7 +78,6 @@ msgstr ""
 #. module: purchase_product_pack
 #. odoo-python
 #: code:addons/purchase_product_pack/models/purchase_order_line.py:0
-#, python-format
 msgid "Parent Product"
 msgstr ""
 
@@ -102,6 +101,11 @@ msgstr ""
 msgid "Purchase Order Line"
 msgstr ""
 
+#. module: purchase_product_pack
+#: model:ir.model.fields,help:purchase_product_pack.field_purchase_order_line__do_no_expand_pack_lines
+msgid "Technical field in order to check if pack lines has to be expanded"
+msgstr ""
+
 #. module: purchase_product_pack
 #: model:ir.model.fields,help:purchase_product_pack.field_purchase_order_line__pack_parent_line_id
 msgid "The pack that contains this product."
@@ -112,16 +116,9 @@ msgstr ""
 msgid "The parent pack is modifiable"
 msgstr ""
 
-#. module: purchase_product_pack
-#: model:ir.model.fields,help:purchase_product_pack.field_purchase_order_line__do_no_expand_pack_lines
-msgid ""
-"This is a technical field in order to check if pack lines has to be expanded"
-msgstr ""
-
 #. module: purchase_product_pack
 #. odoo-python
 #: code:addons/purchase_product_pack/models/purchase_order_line.py:0
-#, python-format
 msgid ""
 "You can not change this line because is part of a pack included in this "
 "order"
@@ -130,7 +127,6 @@ msgstr ""
 #. module: purchase_product_pack
 #. odoo-python
 #: code:addons/purchase_product_pack/models/purchase_order.py:0
-#, python-format
 msgid ""
 "You cannot delete this line because is part of a pack in this purchase "
 "order. In order to delete this line you need to delete the pack itself"

purchase_product_pack/models/purchase_order.py

@@ -25,7 +25,7 @@ def copy_data(self, default=None):
 
     @api.onchange("order_line")
     def check_pack_line_unlink(self):
-        # At least on embeded tree editable view odoo returns a recordset on
+        # At least on embeded list editable view odoo returns a recordset on
         # origin.order_line only when lines are unlinked and this is exactly
         # what we need
         origin_line_ids = self._origin.order_line.ids

purchase_product_pack/models/purchase_order_line.py

@@ -34,7 +34,7 @@ class PurchaseOrderLine(models.Model):
 
     do_no_expand_pack_lines = fields.Boolean(
         compute="_compute_do_no_expand_pack_lines",
-        help="This is a technical field in order to check if pack lines has to be expanded",
+        help="Technical field in order to check if pack lines has to be expanded",
     )
 
     @api.depends_context("update_prices", "update_pricelist")
@@ -63,7 +63,8 @@ def expand_pack_line(self, write=False):
                 if write:
                     existing_subline = first(
                         self.pack_child_line_ids.filtered(
-                            lambda child: child.product_id == subline.product_id
+                            lambda child, subline=subline: child.product_id
+                            == subline.product_id
                         )
                     )
                     # if subline already exists we update, if not we create
@@ -128,7 +129,7 @@ def action_open_parent_pack_product_view(self):
             "type": "ir.actions.act_window",
             "res_model": "product.product",
             "view_type": "form",
-            "view_mode": "tree,form",
+            "view_mode": "list,form",
             "domain": domain,
         }
 
@@ -157,10 +158,11 @@ def _compute_price_unit_and_date_planned_and_name(self):
             if not prices:
                 continue
             cost = prices[line.product_id.id]
-            # If not seller, use the standard price. It needs a proper currency conversion.
+            # If not seller, use the standard price. It needs a proper
+            # currency conversion.
             if not seller:
                 unavailable_seller = line.product_id.seller_ids.filtered(
-                    lambda s: s.partner_id == line.order_id.partner_id
+                    lambda s, line=line: s.partner_id == line.order_id.partner_id
                 )
                 if (
                     not unavailable_seller
@@ -169,7 +171,8 @@ def _compute_price_unit_and_date_planned_and_name(self):
                 ):
                     # Avoid to modify the price unit if there is no price list
                     # for this partner and
-                    # the line has already one to avoid to override unit price set manually.
+                    # the line has already one to avoid to override
+                    # unit price set manually.
                     continue
                 po_line_uom = line.product_uom or line.product_id.uom_po_id
                 # Using new cost to compute the price_unit

purchase_product_pack/static/description/index.html

@@ -3,15 +3,16 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>Purchase Product Pack</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -274,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -359,16 +360,21 @@
 </style>
 </head>
 <body>
-<div class="document" id="purchase-product-pack">
-<h1 class="title">Purchase Product Pack</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="purchase-product-pack">
+<h1>Purchase Product Pack</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:1c37bc5ae3753d96b784bb15fdbed5dcbe70cafb085cb3ddde5960c03d9c85a7
+!! source digest: sha256:c2dac7004783b8033eccca5252ad883ba2106fc36f774bb5680b539f372092be
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-pack/tree/18.0/purchase_product_pack"><img alt="OCA/product-pack" src="https://img.shields.io/badge/github-OCA%2Fproduct--pack-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-pack-18-0/product-pack-18-0-purchase_product_pack"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-pack&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-pack/tree/18.0/purchase_product_pack"><img alt="OCA/product-pack" src="https://img.shields.io/badge/github-OCA%2Fproduct--pack-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-pack-18-0/product-pack-18-0-purchase_product_pack"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-pack&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds <em>Product Pack</em> functionality to purchase orders. You
 can choose a <em>Pack</em> in <em>purchase order lines</em> and see different
 behaviors depending on “Pack type” and “Pack component price” fields
@@ -388,7 +394,7 @@ <h1 class="title">Purchase Product Pack</h1>
 </ul>
 </div>
 <div class="section" id="usage">
-<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Usage</a></h2>
 <p>To use this module, you need to:</p>
 <ol class="arabic simple">
 <li>Go to <em>Purchase &gt; Products &gt; Products</em>, create or select a product
@@ -407,23 +413,23 @@ <h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
 </ol>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/product-pack/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
 <a class="reference external" href="https://github.com/OCA/product-pack/issues/new?body=module:%20purchase_product_pack%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-3">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-4">Authors</a></h3>
 <ul class="simple">
 <li>Camptocamp</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Contributors</a></h3>
 <ul class="simple">
 <li><a class="reference external" href="https://www.trobz.com">Trobz</a>:<ul>
 <li>Duong (Tran Quoc)</li>
@@ -432,17 +438,19 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 </ul>
 </div>
 <div class="section" id="other-credits">
-<h2><a class="toc-backref" href="#toc-entry-6">Other credits</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-6">Other credits</a></h3>
 <p>Inspired by <em>sale_product_pack</em></p>
 <p>The development of this module has been financially supported by:</p>
 <ul class="simple">
 <li>Camptocamp</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
@@ -451,5 +459,6 @@ <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

purchase_product_pack/views/product_pack_line_views.xml

@@ -7,7 +7,7 @@
         <field name="inherit_id" ref="purchase.purchase_order_form" />
         <field name="arch" type="xml">
             <xpath
-                expr="//field[@name='order_line']/tree//field[@name='price_subtotal']"
+                expr="//field[@name='order_line']/list//field[@name='price_subtotal']"
                 position="after"
             >
                 <field name="pack_modifiable" invisible="True" />