tests: create users in tests; drop base.user_demo

- Add setUpClass user in test classes\n- Replace base.user_demo references\n- Remove test demo XML; revert manifest demo\n- Scope: tests only (no functional changes)

Author: Milan Topuzov

queue_job/tests/test_json_field.py

@@ -14,8 +14,23 @@
 
 
 class TestJson(common.TransactionCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(
+            {
+                "name": "Demo User (Queue)",
+                "login": "queue_demo_user",
+                "company_id": main_company.id,
+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],
+            }
+        )
     def test_encoder_recordset(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         context = demo_user.context_get()
         partner = self.env(user=demo_user, context=context).ref("base.main_partner")
         value = partner
@@ -33,7 +48,7 @@ def test_encoder_recordset(self):
         self.assertEqual(json.loads(value_json), expected)
 
     def test_encoder_recordset_list(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         context = demo_user.context_get()
         partner = self.env(user=demo_user, context=context).ref("base.main_partner")
         value = ["a", 1, partner]
@@ -55,7 +70,7 @@ def test_encoder_recordset_list(self):
         self.assertEqual(json.loads(value_json), expected)
 
     def test_decoder_recordset(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         context = demo_user.context_get()
         partner = self.env(user=demo_user).ref("base.main_partner")
 
@@ -76,7 +91,7 @@ def test_decoder_recordset(self):
         self.assertEqual(demo_user, expected.env.user)
 
     def test_decoder_recordset_list(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         context = demo_user.context_get()
         partner = self.env(user=demo_user).ref("base.main_partner")
         value_json = json.dumps(

test_queue_job/tests/test_job.py

@@ -32,6 +32,22 @@
 class TestJobsOnTestingMethod(JobCommonCase):
     """Test Job"""
 
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(
+            {
+                "name": "Demo User (Queue)",
+                "login": "queue_demo_user_3",
+                "company_id": main_company.id,
+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],
+            }
+        )
+
     def test_new_job(self):
         """
         Create a job
@@ -387,6 +403,22 @@ def test_job_identity_key_func_exact(self):
 class TestJobs(JobCommonCase):
     """Test jobs on other methods or with different job configuration"""
 
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(
+            {
+                "name": "Demo User (Queue)",
+                "login": "queue_demo_user_4",
+                "company_id": main_company.id,
+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],
+            }
+        )
+
     def test_description(self):
         """If no description is given to the job, it
         should be computed from the function
@@ -490,7 +522,7 @@ def test_job_with_mutable_arguments(self):
         self.assertEqual({"mutable_kwarg": {"a": 1}}, job_instance.kwargs)
 
     def test_store_env_su_no_sudo(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         self.env = self.env(user=demo_user)
         delayable = self.env["test.queue.job"].with_delay()
         test_job = delayable.testing_method()
@@ -500,7 +532,7 @@ def test_store_env_su_no_sudo(self):
         self.assertTrue(job_instance.user_id, demo_user)
 
     def test_store_env_su_sudo(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         self.env = self.env(user=demo_user)
         delayable = self.env["test.queue.job"].sudo().with_delay()
         test_job = delayable.testing_method()
@@ -511,6 +543,21 @@ def test_store_env_su_sudo(self):
 
 
 class TestJobModel(JobCommonCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(
+            {
+                "name": "Demo User (Queue)",
+                "login": "queue_demo_user_5",
+                "company_id": main_company.id,
+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],
+            }
+        )
     def test_job_change_state(self):
         stored = self._create_job()
         stored._change_job_state(DONE, result="test")
@@ -639,7 +686,7 @@ def test_override_channel(self):
         self.assertEqual("root.sub.sub", test_job.channel)
 
     def test_job_change_user_id(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         stored = self._create_job()
         stored.user_id = demo_user
         self.assertEqual(stored.records.env.uid, demo_user.id)

test_queue_job/tests/test_json_field.py

@@ -11,17 +11,32 @@
 
 
 class TestJsonField(common.TransactionCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(
+            {
+                "name": "Demo User (Queue)",
+                "login": "queue_demo_user_2",
+                "company_id": main_company.id,
+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],
+            }
+        )
     # TODO: when migrating to 16.0, adapt checks in queue_job/tests/test_json_field.py
     # to verify the context keys are encoded and remove these
     def test_encoder_recordset_store_context(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         user_context = {"lang": "en_US", "tz": "Europe/Brussels"}
         test_model = self.env(user=demo_user, context=user_context)["test.queue.job"]
         value_json = json.dumps(test_model, cls=JobEncoder)
         self.assertEqual(json.loads(value_json)["context"], user_context)
 
     def test_encoder_recordset_context_filter_keys(self):
-        demo_user = self.env.ref("base.user_demo")
+        demo_user = self.demo_user
         user_context = {"lang": "en_US", "tz": "Europe/Brussels"}
         tampered_context = dict(user_context, foo=object())
         test_model = self.env(user=demo_user, context=tampered_context)[