[MIG] sale_order_report_hide_tax: Migration to 18.0

Author: sabrinaRMartin

sale_order_report_hide_tax/README.rst

@@ -1,7 +1,3 @@
-.. image:: https://odoo-community.org/readme-banner-image
-   :target: https://odoo-community.org/get-involved?utm_source=readme
-   :alt: Odoo Community Association
-
 ==================================
 Sale order line hide tax in report
 ==================================
@@ -17,17 +13,17 @@ Sale order line hide tax in report
 .. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png
     :target: https://odoo-community.org/page/development-status
     :alt: Alpha
-.. |badge2| image:: https://img.shields.io/badge/license-LGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/licence-LGPL--3-blue.png
     :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
     :alt: License: LGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--reporting-lightgray.png?logo=github
-    :target: https://github.com/OCA/sale-reporting/tree/16.0/sale_order_report_hide_tax
+    :target: https://github.com/OCA/sale-reporting/tree/18.0/sale_order_report_hide_tax
     :alt: OCA/sale-reporting
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/sale-reporting-16-0/sale-reporting-16-0-sale_order_report_hide_tax
+    :target: https://translation.odoo-community.org/projects/sale-reporting-18-0/sale-reporting-18-0-sale_order_report_hide_tax
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-reporting&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-reporting&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -67,7 +63,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-reporting/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/sale-reporting/issues/new?body=module:%20sale_order_report_hide_tax%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/sale-reporting/issues/new?body=module:%20sale_order_report_hide_tax%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -82,7 +78,8 @@ Authors
 Contributors
 ------------
 
-- David Vidal (``Moduon <https://www.moduon.team/>``\ \_\_)
+- David Vidal (`Moduon <https://www.moduon.team/>`__)
+- Sabrina Rodriguez (`Moduon <https://www.moduon.team/>`__)
 
 Maintainers
 -----------
@@ -108,6 +105,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-chienandalu| |maintainer-rafaelbn| 
 
-This module is part of the `OCA/sale-reporting <https://github.com/OCA/sale-reporting/tree/16.0/sale_order_report_hide_tax>`_ project on GitHub.
+This module is part of the `OCA/sale-reporting <https://github.com/OCA/sale-reporting/tree/18.0/sale_order_report_hide_tax>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_order_report_hide_tax/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Sale order line hide tax in report",
     "summary": "Hide taxes column when they don't add value",
-    "version": "16.0.1.0.1",
+    "version": "18.0.1.0.1",
     "development_status": "Alpha",
     "category": "Sales",
     "website": "https://github.com/OCA/sale-reporting",

sale_order_report_hide_tax/models/sale_order.py

@@ -14,9 +14,8 @@ def _compute_show_tax_column_in_report(self):
         self.show_tax_column_in_report = True
         for order in self.filtered("order_line"):
             order_lines = order.order_line.filtered(lambda x: not x.display_type)
-            # Can be a recordset if several taxes apply
             first_line_tax_group = fields.first(order_lines).tax_id.tax_group_id
             # Mixed group taxes, let's show them for clarity
-            order.show_tax_column_in_report = (
-                first_line_tax_group != order_lines.tax_id.tax_group_id
+            order.show_tax_column_in_report = any(
+                first_line_tax_group != line.tax_id.tax_group_id for line in order_lines
             )

sale_order_report_hide_tax/readme/CONTRIBUTORS.md

@@ -1 +1,2 @@
-* David Vidal (`Moduon <https://www.moduon.team/>`__)
+- David Vidal ([Moduon](https://www.moduon.team/))
+- Sabrina Rodriguez ([Moduon](https://www.moduon.team/))

sale_order_report_hide_tax/reports/sale_order_report_template.xml

@@ -3,12 +3,21 @@
     <template
         id="report_saleorder_document"
         inherit_id="sale.report_saleorder_document"
+        priority="999"
     >
         <xpath expr="//th[@name='th_taxes']" position="attributes">
-            <attribute name="t-if">doc.show_tax_column_in_report</attribute>
+            <attribute
+                name="t-if"
+                add="doc.show_tax_column_in_report"
+                separator="and"
+            />
         </xpath>
         <xpath expr="//td[@name='td_taxes']" position="attributes">
-            <attribute name="t-if">doc.show_tax_column_in_report</attribute>
+            <attribute
+                name="t-if"
+                add="doc.show_tax_column_in_report"
+                separator="and"
+            />
         </xpath>
     </template>
 </odoo>

sale_order_report_hide_tax/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>README.rst</title>
+<title>Sale order line hide tax in report</title>
 <style type="text/css">
 
 /*
@@ -360,21 +360,16 @@
 </style>
 </head>
 <body>
-<div class="document">
+<div class="document" id="sale-order-line-hide-tax-in-report">
+<h1 class="title">Sale order line hide tax in report</h1>
 
-
-<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
-<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
-</a>
-<div class="section" id="sale-order-line-hide-tax-in-report">
-<h1>Sale order line hide tax in report</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:c3f8c634c1fae23b76f78082b36599f63225f7b3b09f33d3e5fa90f5b185f557
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/license-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-reporting/tree/16.0/sale_order_report_hide_tax"><img alt="OCA/sale-reporting" src="https://img.shields.io/badge/github-OCA%2Fsale--reporting-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-reporting-16-0/sale-reporting-16-0-sale_order_report_hide_tax"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-reporting&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-reporting/tree/18.0/sale_order_report_hide_tax"><img alt="OCA/sale-reporting" src="https://img.shields.io/badge/github-OCA%2Fsale--reporting-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-reporting-18-0/sale-reporting-18-0-sale_order_report_hide_tax"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-reporting&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Hide taxes column in the quotation document that is sent to the
 customer.</p>
 <div class="admonition important">
@@ -398,42 +393,43 @@ <h1>Sale order line hide tax in report</h1>
 </ul>
 </div>
 <div class="section" id="use-cases-context">
-<h2><a class="toc-backref" href="#toc-entry-1">Use Cases / Context</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-1">Use Cases / Context</a></h1>
 <p>When the taxes are the same in every sales line, that information might
 be redundant with the taxes summary and takes valuable space that other
 columns might take.</p>
 <p>This might be event more annoying when there’s tax exemptions like in EU
 intracomunitary operations.</p>
 </div>
 <div class="section" id="usage">
-<h2><a class="toc-backref" href="#toc-entry-2">Usage</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 <p>Whenever the taxes are in the same group for the whole order the column
 won’t be displayed.</p>
 </div>
 <div class="section" id="bug-tracker">
-<h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/sale-reporting/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/sale-reporting/issues/new?body=module:%20sale_order_report_hide_tax%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/sale-reporting/issues/new?body=module:%20sale_order_report_hide_tax%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h2><a class="toc-backref" href="#toc-entry-4">Credits</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
 <div class="section" id="authors">
-<h3><a class="toc-backref" href="#toc-entry-5">Authors</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
 <ul class="simple">
 <li>Moduon</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h3><a class="toc-backref" href="#toc-entry-6">Contributors</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <ul class="simple">
-<li>David Vidal (<tt class="docutils literal">Moduon <span class="pre">&lt;https://www.moduon.team/&gt;</span></tt>__)</li>
+<li>David Vidal (<a class="reference external" href="https://www.moduon.team/">Moduon</a>)</li>
+<li>Sabrina Rodriguez (<a class="reference external" href="https://www.moduon.team/">Moduon</a>)</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
@@ -443,11 +439,10 @@ <h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainers</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/chienandalu"><img alt="chienandalu" src="https://github.com/chienandalu.png?size=40px" /></a> <a class="reference external image-reference" href="https://github.com/rafaelbn"><img alt="rafaelbn" src="https://github.com/rafaelbn.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-reporting/tree/16.0/sale_order_report_hide_tax">OCA/sale-reporting</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-reporting/tree/18.0/sale_order_report_hide_tax">OCA/sale-reporting</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
-</div>
 </body>
 </html>

sale_order_report_hide_tax/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_show_tax_column

sale_order_report_hide_tax/tests/test_show_tax_column.py

@@ -0,0 +1,161 @@
+# Copyright 2025 Moduon Team S.L.
+# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl-3.0)
+from odoo import Command
+
+from odoo.addons.base.tests.common import BaseCommon
+
+
+class TestShowTaxColumnInReport(BaseCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.partner = cls.env["res.partner"].create(
+            {
+                "name": "Test Partner",
+            }
+        )
+        cls.product = cls.env["product.product"].create(
+            {
+                "name": "Test Product",
+            }
+        )
+        cls.tax_group_1 = cls.env["account.tax.group"].create(
+            {
+                "name": "VAT Group 1",
+            }
+        )
+        cls.tax_group_2 = cls.env["account.tax.group"].create(
+            {
+                "name": "VAT Group 2",
+            }
+        )
+        cls.tax_group_3 = cls.env["account.tax.group"].create(
+            {
+                "name": "VAT Group 3",
+            }
+        )
+        cls.tax_1 = cls.env["account.tax"].create(
+            {
+                "name": "Tax 1",
+                "amount": 10,
+                "amount_type": "percent",
+                "tax_group_id": cls.tax_group_1.id,
+            }
+        )
+        cls.tax_2 = cls.env["account.tax"].create(
+            {
+                "name": "Tax 2",
+                "amount": 5,
+                "amount_type": "percent",
+                "tax_group_id": cls.tax_group_2.id,
+            }
+        )
+        cls.tax_3 = cls.env["account.tax"].create(
+            {
+                "name": "Tax 3",
+                "amount": 5,
+                "amount_type": "percent",
+                "tax_group_id": cls.tax_group_2.id,
+            }
+        )
+        cls.order = cls.env["sale.order"].create(
+            {
+                "partner_id": cls.partner.id,
+            }
+        )
+        cls.report = cls.env["ir.actions.report"]._get_report_from_name(
+            "sale.report_saleorder"
+        )
+
+    def test_same_tax_group_hides_tax_column(self):
+        self.order.order_line = [
+            Command.clear(),
+            Command.create(
+                {
+                    "product_id": self.product.id,
+                    "name": "Line 1",
+                    "product_uom_qty": 1,
+                    "price_unit": 100,
+                    "tax_id": [(6, 0, [self.tax_1.id])],
+                }
+            ),
+            Command.create(
+                {
+                    "product_id": self.product.id,
+                    "name": "Line 2",
+                    "product_uom_qty": 1,
+                    "price_unit": 50,
+                    "tax_id": [(6, 0, [self.tax_1.id])],
+                }
+            ),
+        ]
+        result = self.report._render_qweb_html("sale.report_saleorder", [self.order.id])
+        html = result[0].decode("utf-8")
+        self.assertNotIn(
+            "Taxes",
+            html,
+            """Tax column should be hidden when all taxes
+                belong to the same tax group""",
+        )
+
+    def test_mixed_tax_groups_show_tax_column(self):
+        self.order.order_line = [
+            Command.clear(),
+            Command.create(
+                {
+                    "product_id": self.product.id,
+                    "name": "Line 1",
+                    "product_uom_qty": 1,
+                    "price_unit": 100,
+                    "tax_id": [(6, 0, [self.tax_1.id])],
+                }
+            ),
+            Command.create(
+                {
+                    "product_id": self.product.id,
+                    "name": "Line 2",
+                    "product_uom_qty": 1,
+                    "price_unit": 50,
+                    "tax_id": [(6, 0, [self.tax_2.id])],
+                }
+            ),
+        ]
+        result = self.report._render_qweb_html("sale.report_saleorder", [self.order.id])
+        html = result[0].decode("utf-8")
+        self.assertIn(
+            "Taxes",
+            html,
+            """The tax column should be displayed when taxes
+                belong to different tax groups""",
+        )
+
+    def test_mixed_tax_groups_single_line_sow_tax_column(self):
+        self.order.order_line = [
+            Command.clear(),
+            Command.create(
+                {
+                    "product_id": self.product.id,
+                    "name": "Line 1",
+                    "product_uom_qty": 1,
+                    "price_unit": 100,
+                    "tax_id": [(6, 0, [self.tax_1.id, self.tax_2.id])],
+                }
+            ),
+            Command.create(
+                {
+                    "product_id": self.product.id,
+                    "name": "Line 1",
+                    "product_uom_qty": 1,
+                    "price_unit": 100,
+                    "tax_id": [(6, 0, [self.tax_3.id])],
+                }
+            ),
+        ]
+        result = self.report._render_qweb_html("sale.report_saleorder", [self.order.id])
+        html = result[0].decode("utf-8")
+        self.assertIn(
+            "Taxes",
+            html,
+            """The tax column should be displayed when taxes
+                belong to different tax groups""",
+        )