Migration to version 17.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Modules to migrate

• product_sold_by_delivery_week - By @BhaveshHeliconia - [17.0][MIG] product_sold_by_delivery_week: Migration to 17.0 #312
• sale_comment_template - By @RogerSans - [17.0][MIG] sale_comment_template: Migration to 17.0 #279
• sale_layout_category_hide_detail - By @jeroenev - [17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253
• sale_order_line_position - By @xaviedoanhduy - [17.0][MIG] sale_order_line_position: Migration to 17.0  #264
• sale_order_product_recommendation_product_sold_by_delivery_week
• sale_order_report_product_image - By @JoseIbarraHdz - [17.0][MIG] sale_order_report_product_image: Migration to 17.0 #283
• sale_order_weight - By @BhaveshHeliconia - [17.0][MIG] sale_order_weight: Migration to 17.0 #303
• sale_packaging_report - By @BhaveshHeliconia - [17.0][MIG] sale_packaging_report: Migration to 17.0 #308
• sale_report_delivered
• sale_report_delivered_subtotal - By @kobfolson - [17.0][MIG] sale_report_delivered_subtotal: Migration to 17.0 #280
• sale_report_delivered_volume - By @BhaveshHeliconia - [17.0][MIG] sale_report_delivered_volume: Migration to 17.0 #310
• sale_report_salesman - By @juancarlosonate-tecnativa - [17.0][MIG] sale_report_salesman: Migration to 17.0 #319
• sale_report_salesperson_from_partner - By @HeliconiaSolutions - [17.0][MIG] sale_report_salesperson_from_partner: Migration to 17.0 #311

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[jeroenev]

migrated sale_layout_category_hide_detail in #253

[willievmobile]

@jeroenev
i tried to install and test your #253 but it doesnt install if tails with a error (below) and if its forced it crashes odoo when trying to open quotations,
`
RPC_ERROR
Odoo Server Error
Traceback (most recent call last):
File "/cloudclusters/odoo/odoo/http.py", line 1732, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/cloudclusters/odoo/odoo/service/model.py", line 133, in retrying
result = func()
File "/cloudclusters/odoo/odoo/http.py", line 1759, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/cloudclusters/odoo/odoo/http.py", line 1960, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/cloudclusters/odoo/addons/website/models/ir_http.py", line 235, in _dispatch
response = super()._dispatch(endpoint)
File "/cloudclusters/odoo/odoo/addons/base/models/ir_http.py", line 207, in _dispatch
result = endpoint(**request.params)
File "/cloudclusters/odoo/odoo/http.py", line 722, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/cloudclusters/odoo/addons/web/controllers/dataset.py", line 28, in call_button
action = self._call_kw(model, method, args, kwargs)
File "/cloudclusters/odoo/addons/web/controllers/dataset.py", line 20, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/cloudclusters/odoo/odoo/api.py", line 466, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/cloudclusters/odoo/odoo/api.py", line 453, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "", line 2, in button_immediate_install
File "/cloudclusters/odoo/odoo/addons/base/models/ir_module.py", line 75, in check_and_log
return method(self, *args, **kwargs)
File "/cloudclusters/odoo/odoo/addons/base/models/ir_module.py", line 459, in button_immediate_install
return self._button_immediate_function(type(self).button_install)
File "/cloudclusters/odoo/odoo/addons/base/models/ir_module.py", line 583, in _button_immediate_function
registry = modules.registry.Registry.new(self._cr.dbname, update_module=True)
File "", line 2, in new
File "/cloudclusters/odoo/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/cloudclusters/odoo/odoo/modules/registry.py", line 113, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/cloudclusters/odoo/odoo/modules/loading.py", line 480, in load_modules
processed_modules += load_marked_modules(env, graph,
File "/cloudclusters/odoo/odoo/modules/loading.py", line 364, in load_marked_modules
loaded, processed = load_module_graph(
File "/cloudclusters/odoo/odoo/modules/loading.py", line 227, in load_module_graph
load_data(env, idref, mode, kind='data', package=package)
File "/cloudclusters/odoo/odoo/modules/loading.py", line 71, in load_data
tools.convert_file(env, package.name, filename, idref, mode, noupdate, kind)
File "/cloudclusters/odoo/odoo/tools/convert.py", line 627, in convert_file
convert_xml_import(env, module, fp, idref, mode, noupdate)
File "/cloudclusters/odoo/odoo/tools/convert.py", line 693, in convert_xml_import
obj.parse(doc.getroot())
File "/cloudclusters/odoo/odoo/tools/convert.py", line 613, in parse
self._tag_root(de)
File "/cloudclusters/odoo/odoo/tools/convert.py", line 567, in _tag_root
raise ParseError(msg) from None # Restart with "--log-handler odoo.tools.convert:DEBUG" for complete traceback
odoo.tools.convert.ParseError: while parsing None:8
Error while parsing or validating view:

Element '' cannot be located in parent view

View error context:
{'file': '/cloudclusters/odoo/odoo/addons/sale_layout_category_hide_detail/views/invoice_report_templates.xml',
'line': 2,
'name': 'report_invoice_document_hide_detail',
'view': ir.ui.view(2838,),
'view.model': False,
'view.parent': ir.ui.view(717,),
'xmlid': 'report_invoice_document_hide_detail'}

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPCError@https://odoo--0.cloudclusters.net/web/assets/a135007/web.assets_web.min.js:2869:319
makeErrorFromResponse@https://odoo--0.cloudclusters.net/web/assets/a135007/web.assets_web.min.js:2872:163
jsonrpc/promise</<@https://odoo--0.cloudclusters.net/web/assets/a135007/web.assets_web.min.js:2876:34
`

[jeroenev]

Try updating Odoo17 to the latest commit/version, they changed something a week ago in that template
see last commit: d695328
if you're running an Odoo17 commit from a week or 2 ago it will give an error, if you're running the latest version it should work

[pedrobaeza]

Please do this conversation in the corresponding PR, not here.

[xaviedoanhduy]

sale_order_line_position #264

[alan196]

sale_comment_template #265

[RogerSans]

Working on sale_comment_template #279

[JoseIbarraHdz]

sale_order_report_product_image #283

[BhaveshHeliconia]

sale_order_weight #303

[BhaveshHeliconia]

• sale_packaging_report [17.0][MIG] sale_packaging_report: Migration to 17.0 #308
• sale_report_country_state [17.0][MIG] sale_report_country_state: Migration to 17.0 #309
• sale_report_delivered_volume [17.0][MIG] sale_report_delivered_volume: Migration to 17.0 #310
• sale_report_salesperson_from_partner [17.0][MIG] sale_report_salesperson_from_partner: Migration to 17.0 #311
• product_sold_by_delivery_week [17.0][MIG] product_sold_by_delivery_week: Migration to 17.0 #312

[juancarlosonate-tecnativa]

working on sale_report_salesman