[IMP] sale_elaboration: Update elaboration quantities to sale order when quantity_done changes in done moves (unlock picking)

TT55334

Author: carlosdauden

sale_elaboration/models/stock_move.py

@@ -35,6 +35,29 @@ def _prepare_merge_moves_distinct_fields(self):
         distinct_fields += ["elaboration_ids", "elaboration_note"]
         return distinct_fields
 
+    def write(self, vals):
+        # Propagate elaboration quantities to sale order line when quantity_done changes
+        # in done moves (unlock picking)
+        res = False
+        if "quantity" in vals and self[:1].state == "done":
+            moves_with_elaborations = self.filtered(
+                lambda m: m.sale_line_id and m.elaboration_ids
+            )
+            old_quantities = {move: move.quantity for move in moves_with_elaborations}
+            res = super().write(vals)
+            for move in moves_with_elaborations:
+                qty_difference = move.quantity - old_quantities[move]
+                if not qty_difference:
+                    continue
+                for move_elab in move.elaboration_ids:
+                    sale_elab = move.sale_line_id.order_id.order_line.filtered(
+                        lambda x, move_elab=move_elab: x.product_id
+                        == move_elab.product_id
+                    )[:1]
+                    if sale_elab:
+                        sale_elab.product_uom_qty += qty_difference
+        return res or super().write(vals)
+
 
 class StockMoveLine(models.Model):
     _inherit = "stock.move.line"

sale_elaboration/tests/test_sale_elaboration.py

@@ -120,14 +120,6 @@ def test_sale_elaboration_doesnt_change(self):
         self.order.order_line.elaboration_ids = self.elaboration_b
         self.assertEqual(self.order.order_line.elaboration_note, "Some details")
 
-    def test_sale_elaboration_change(self):
-        order_form = Form(self.order)
-        with order_form.order_line.edit(0) as line:
-            line.elaboration_ids.clear()
-            line.elaboration_ids.add(self.elaboration_b)
-        order_form.save()
-        self.assertEqual(self.order.order_line.elaboration_note, "Elaboration B")
-
     def test_sale_elaboration(self):
         self.order.action_confirm()
         self.order.picking_ids.move_ids.quantity = 10.0
@@ -234,3 +226,13 @@ def test_propagation_from_sale_order_to_stock_move(self):
                 },
             ],
         )
+
+    def test_sale_elaboration_done_move_changes(self):
+        self.order.action_confirm()
+        self.order.picking_ids.move_ids.quantity = 10.0
+        self.order.picking_ids.move_ids.picked = True
+        self.order.picking_ids._action_done()
+        self.order.picking_ids.move_ids.quantity = 15.0
+        elaboration_lines = self.order.order_line.filtered("is_elaboration")
+        self.assertEqual(len(elaboration_lines), 1)
+        self.assertEqual(elaboration_lines.product_uom_qty, 15.0)