[MIG] auditlog: Migration to 19.0

Author: lembregtse

auditlog/README.rst

@@ -21,13 +21,13 @@ Audit Log
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github
-    :target: https://github.com/OCA/server-tools/tree/18.0/auditlog
+    :target: https://github.com/OCA/server-tools/tree/19.0/auditlog
     :alt: OCA/server-tools
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auditlog
+    :target: https://translation.odoo-community.org/projects/server-tools-19-0/server-tools-19-0-auditlog
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -74,26 +74,26 @@ auditlogs of individual records through the View Logs action. The second
 group is the Auditlog Manager group. This group additionally has the
 right to configure the auditlog configuration rules.
 
-.. |image| image:: https://raw.githubusercontent.com/OCA/server-tools/18.0/auditlog/static/description/rule.png
-.. |image1| image:: https://raw.githubusercontent.com/OCA/server-tools/18.0/auditlog/static/description/logs.png
-.. |image2| image:: https://raw.githubusercontent.com/OCA/server-tools/18.0/auditlog/static/description/log.png
-.. |image3| image:: https://raw.githubusercontent.com/OCA/server-tools/18.0/auditlog/static/description/autovacuum.png
+.. |image| image:: https://raw.githubusercontent.com/OCA/server-tools/19.0/auditlog/static/description/rule.png
+.. |image1| image:: https://raw.githubusercontent.com/OCA/server-tools/19.0/auditlog/static/description/logs.png
+.. |image2| image:: https://raw.githubusercontent.com/OCA/server-tools/19.0/auditlog/static/description/log.png
+.. |image3| image:: https://raw.githubusercontent.com/OCA/server-tools/19.0/auditlog/static/description/autovacuum.png
 
 Known issues / Roadmap
 ======================
 
-   - log only operations triggered by some users (currently it logs all
-     users)
-   - log read operations does not work on all data models, need
-     investigation
+   -  log only operations triggered by some users (currently it logs all
+      users)
+   -  log read operations does not work on all data models, need
+      investigation
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-tools/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20auditlog%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20auditlog%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -108,24 +108,24 @@ Authors
 Contributors
 ------------
 
-- Sebastien Alix <sebastien.alix@camptocamp.com>
-- Holger Brunn <hbrunn@therp.nl>
-- Holden Rehg <holdenrehg@gmail.com>
-- Eric Lembregts <eric@lembregts.eu>
-- Pieter Paulussen <pieter.paulussen@me.com>
-- Alan Ramos <alan.ramos@jarsa.com.mx>
-- Stefan Rijnhart <stefan@opener.amsterdam>
-- Bhavesh Odedra <bodedra@opensourceintegrators.com>
-- Hardik Suthar <hsuthar@opensourceintegrators.com>
-- Kitti U. <kittiu@ecosoft.co.th>
-- Bogdan Valentin Gabor <valentin.gabor@bt-group.com>
-- Dennis Sluijk d.sluijk@onestein.nl
+-  Sebastien Alix <sebastien.alix@camptocamp.com>
+-  Holger Brunn <hbrunn@therp.nl>
+-  Holden Rehg <holdenrehg@gmail.com>
+-  Eric Lembregts <eric@lembregts.eu>
+-  Pieter Paulussen <pieter.paulussen@me.com>
+-  Alan Ramos <alan.ramos@jarsa.com.mx>
+-  Stefan Rijnhart <stefan@opener.amsterdam>
+-  Bhavesh Odedra <bodedra@opensourceintegrators.com>
+-  Hardik Suthar <hsuthar@opensourceintegrators.com>
+-  Kitti U. <kittiu@ecosoft.co.th>
+-  Bogdan Valentin Gabor <valentin.gabor@bt-group.com>
+-  Dennis Sluijk d.sluijk@onestein.nl
 
 Other credits
 -------------
 
-- Icon: built with different icons from the `Oxygen
-  theme <https://en.wikipedia.org/wiki/Oxygen_Project>`__ (LGPL)
+-  Icon: built with different icons from the `Oxygen
+   theme <https://en.wikipedia.org/wiki/Oxygen_Project>`__ (LGPL)
 
 Maintainers
 -----------
@@ -140,6 +140,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/18.0/auditlog>`_ project on GitHub.
+This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/19.0/auditlog>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

auditlog/__init__.py

@@ -1,3 +1,4 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 from . import models
+from . import wizard

auditlog/__manifest__.py

@@ -3,12 +3,12 @@
 
 {
     "name": "Audit Log",
-    "version": "18.0.2.0.0",
+    "version": "19.0.1.0.0",
     "author": "ABF OSIELL, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "website": "https://github.com/OCA/server-tools",
     "category": "Tools",
-    "depends": ["base"],
+    "depends": ["mail"],
     "data": [
         "security/res_groups.xml",
         "security/ir.model.access.csv",

auditlog/models/__init__.py

@@ -5,4 +5,3 @@
 from . import http_request
 from . import log
 from . import auditlog_log_line_view
-from . import autovacuum

auditlog/models/http_request.py

@@ -31,9 +31,6 @@ def _compute_display_name(self):
                 httprequest.name or "?", fields.Datetime.to_string(tz_create_date)
             )
 
-    def name_get(self):
-        return [(request.id, request.display_name) for request in self]
-
     @api.model
     def current_http_request(self):
         """Create a log corresponding to the current HTTP request, and returns
@@ -59,9 +56,9 @@ def current_http_request(self):
             vals = {
                 "name": httprequest.path,
                 "root_url": httprequest.url_root,
-                "user_id": request.uid,
+                "user_id": request.env.uid,
                 "http_session_id": http_session_model.current_http_session(),
-                "user_context": request.context,
+                "user_context": request.env.context,
             }
             httprequest.auditlog_http_request_id = self.create(vals).id
             return httprequest.auditlog_http_request_id

auditlog/models/http_session.py

@@ -5,7 +5,7 @@
 from odoo.http import request
 
 
-class AuditlogtHTTPSession(models.Model):
+class AuditlogHTTPSession(models.Model):
     _name = "auditlog.http.session"
     _description = "Auditlog - HTTP User session log"
     _order = "create_date DESC"
@@ -27,9 +27,6 @@ def _compute_display_name(self):
                 fields.Datetime.to_string(tz_create_date),
             )
 
-    def name_get(self):
-        return [(session.id, session.display_name) for session in self]
-
     @api.model
     def current_http_session(self):
         """Create a log corresponding to the current HTTP user session, and
@@ -43,11 +40,11 @@ def current_http_session(self):
         httpsession = request.session
         if httpsession:
             existing_session = self.search(
-                [("name", "=", httpsession.sid), ("user_id", "=", request.uid)], limit=1
+                [("name", "=", httpsession.sid), ("user_id", "=", request.env.uid)],
+                limit=1,
             )
             if existing_session:
                 return existing_session.id
-            vals = {"name": httpsession.sid, "user_id": request.uid}
-            httpsession.auditlog_http_session_id = self.create(vals).id
-            return httpsession.auditlog_http_session_id
+            vals = {"name": httpsession.sid, "user_id": request.env.uid}
+            return self.create(vals).id
         return False

auditlog/models/log.py

@@ -1,6 +1,6 @@
 # Copyright 2015 ABF OSIELL <https://osiell.com>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError
 from odoo.tools.safe_eval import safe_eval
 
@@ -36,7 +36,7 @@ def create(self, vals_list):
         """Insert model_name and model_model field values upon creation."""
         for vals in vals_list:
             if not vals.get("model_id"):
-                raise UserError(_("No model defined to create log."))
+                raise UserError(self.env._("No model defined to create log."))
             model = self.env["ir.model"].sudo().browse(vals["model_id"])
             vals.update({"model_name": model.name, "model_model": model.model})
         return super().create(vals_list)
@@ -46,7 +46,7 @@ def write(self, vals):
         changes."""
         if "model_id" in vals:
             if not vals["model_id"]:
-                raise UserError(_("The field 'model_id' cannot be empty."))
+                raise UserError(self.env._("The field 'model_id' cannot be empty."))
             model = self.env["ir.model"].sudo().browse(vals["model_id"])
             vals.update({"model_name": model.name, "model_model": model.model})
         return super().write(vals)
@@ -58,7 +58,7 @@ def show_res_ids(self):
             "view_mode": "list,form",
             "res_model": self.model_id.model,
             "domain": [("id", "in", safe_eval(self.res_ids))],
-            "name": _("Exported Records"),
+            "name": self.env._("Exported Records"),
         }
 
 
@@ -85,7 +85,7 @@ def create(self, vals_list):
         field_description."""
         for vals in vals_list:
             if not vals.get("field_id"):
-                raise UserError(_("No field defined to create line."))
+                raise UserError(self.env._("No field defined to create line."))
             field = self.env["ir.model.fields"].sudo().browse(vals["field_id"])
             vals.update(
                 {"field_name": field.name, "field_description": field.field_description}
@@ -97,7 +97,7 @@ def write(self, vals):
         field_description values."""
         if "field_id" in vals:
             if not vals["field_id"]:
-                raise UserError(_("The field 'field_id' cannot be empty."))
+                raise UserError(self.env._("The field 'field_id' cannot be empty."))
             field = self.env["ir.model.fields"].sudo().browse(vals["field_id"])
             vals.update(
                 {"field_name": field.name, "field_description": field.field_description}

auditlog/models/rule.py

@@ -3,7 +3,8 @@
 
 import copy
 
-from odoo import Command, _, api, fields, models
+from odoo import Command, api, fields, models
+from odoo.api import NewId
 from odoo.exceptions import UserError
 
 FIELDS_BLACKLIST = [
@@ -104,8 +105,7 @@ class AuditlogRule(models.Model):
         "Log Exports",
         default=True,
         help=(
-            "Select this if you want to keep track of exports "
-            "of the model of this rule"
+            "Select this if you want to keep track of exports of the model of this rule"
         ),
     )
     log_type = fields.Selection(
@@ -146,16 +146,11 @@ class AuditlogRule(models.Model):
         string="Fields to Exclude",
     )
 
-    _sql_constraints = [
-        (
-            "model_uniq",
-            "unique(model_id)",
-            (
-                "There is already a rule defined on this model\n"
-                "You cannot define another: please edit the existing one."
-            ),
-        )
-    ]
+    _model_uniq = models.Constraint(
+        "unique(model_id)",
+        "There is already a rule defined on this model\nYou cannot define another: "
+        "please edit the existing one.",
+    )
 
     def _register_hook(self):
         """Get all rules and apply them to log method calls."""
@@ -245,7 +240,7 @@ def create(self, vals_list):
         """Update the registry when a new rule is created."""
         for vals in vals_list:
             if "model_id" not in vals or not vals["model_id"]:
-                raise UserError(_("No model defined to create line."))
+                raise UserError(self.env._("No model defined to create line."))
             model = self.env["ir.model"].sudo().browse(vals["model_id"])
             vals.update({"model_name": model.name, "model_model": model.model})
         new_records = super().create(vals_list)
@@ -258,7 +253,7 @@ def write(self, vals):
         """Update the registry when existing rules are updated."""
         if "model_id" in vals:
             if not vals["model_id"]:
-                raise UserError(_("Field 'model_id' cannot be empty."))
+                raise UserError(self.env._("Field 'model_id' cannot be empty."))
             model = self.env["ir.model"].sudo().browse(vals["model_id"])
             vals.update({"model_name": model.name, "model_model": model.model})
         res = super().write(vals)
@@ -291,7 +286,6 @@ def _make_create(self):
         users_to_exclude = self.mapped("users_to_exclude_ids")
 
         @api.model_create_multi
-        @api.returns("self", lambda value: value.id)
         def create_full(self, vals_list, **kwargs):
             self = self.with_context(auditlog_disabled=True)
             rule_model = self.env["auditlog.rule"]
@@ -324,7 +318,6 @@ def create_full(self, vals_list, **kwargs):
             return new_records
 
         @api.model_create_multi
-        @api.returns("self", lambda value: value.id)
         def create_fast(self, vals_list, **kwargs):
             self = self.with_context(auditlog_disabled=True)
             rule_model = self.env["auditlog.rule"]
@@ -398,7 +391,7 @@ def write_full(self, vals, **kwargs):
             self = self.with_context(auditlog_disabled=True)
             rule_model = self.env["auditlog.rule"]
             fields_list = rule_model.get_auditlog_fields(self)
-            records_write = self.filtered(lambda r: not isinstance(r.id, models.NewId))
+            records_write = self.filtered(lambda r: not isinstance(r.id, NewId))
             if not records_write:
                 return write_full.origin(self, vals, **kwargs)
             old_values = {
@@ -408,8 +401,6 @@ def write_full(self, vals, **kwargs):
                 .read(fields_list)
             }
             # invalidate_recordset method must be called with existing fields
-            if self._name == "res.users":
-                vals = self._remove_reified_groups(vals)
             # Prevent the cache of modified fields from being poisoned by
             # x2many items inaccessible to the current user.
             self.invalidate_recordset(vals.keys())
@@ -775,7 +766,7 @@ def subscribe(self):
                 f"[('model_id', '=', {rule.model_id.id}), ('res_id', '=', active_id)]"
             )
             vals = {
-                "name": _("View logs"),
+                "name": self.env._("View logs"),
                 "res_model": "auditlog.log",
                 "binding_model_id": rule.model_id.id,
                 "domain": domain,

auditlog/security/res_groups.xml

@@ -3,14 +3,19 @@
         <field name="name">Auditlog Rights</field>
     </record>
 
+    <record model="res.groups.privilege" id="security_auditlog_privilege">
+        <field name="name">Auditlog Privilege</field>
+        <field name="category_id" ref="auditlog.security_auditlog_groups" />
+    </record>
+
     <record model="res.groups" id="group_auditlog_user">
         <field name="name">Auditlog User</field>
-        <field name="category_id" ref="auditlog.security_auditlog_groups" />
+        <field name="privilege_id" ref="auditlog.security_auditlog_privilege" />
     </record>
 
     <record model="res.groups" id="group_auditlog_manager">
         <field name="name">Auditlog Manager</field>
-        <field name="category_id" ref="auditlog.security_auditlog_groups" />
+        <field name="privilege_id" ref="auditlog.security_auditlog_privilege" />
         <field name="implied_ids" eval="[(4, ref('auditlog.group_auditlog_user'))]" />
     </record>