[FIX] mail_server_manager: Use simple % formatting for translations

- Fix W8302: use %s with simple % instead of .format()
- Revert to simple positional placeholders

Author: KHALID SAHIH

mail_server_manager/models/mail_account.py

@@ -143,17 +143,18 @@ def _check_email_format(self):
             if not self._EMAIL_REGEX.match(record.email):
                 raise ValidationError(
                     self.env._(
-                        "Invalid email address format: '%(email)s'.\n\n"
+                        "Invalid email address format: '%s'.\n\n"
                         "Only alphanumeric characters, dots, underscores, hyphens, "
                         "and plus signs are allowed."
-                    ).format(email=record.email)
+                    )
+                    % record.email
                 )
 
             # Validate using Odoo's email_normalize
             normalized = email_normalize(record.email)
             if not normalized:
                 raise ValidationError(
-                    self.env._("Invalid email address: '%(email)s'.").format(
+                    self.env._("Invalid email address: '%s'.").format(
                         email=record.email
                     )
                 )
@@ -162,16 +163,13 @@ def _check_email_format(self):
             local_part, domain = record.email.split("@")
             if not local_part or not domain:
                 raise ValidationError(
-                    self.env._(
-                        "Invalid email address: '%(email)s'. Missing username.."
-                    ).format(email=record.email)
+                    self.env._("Invalid email address: '%s'. Missing username..")
+                    % record.email
                 )
 
             if "." not in domain:
                 raise ValidationError(
-                    self.env._(
-                        "Invalid domain: '%(domain)s'. Must contain a dot."
-                    ).format(domain=domain)
+                    self.env._("Invalid domain: '%s'. Must contain a dot.") % domain
                 )
 
     # Note: _get_mail_domain, _get_mail_config_path, _get_smtp_host,
@@ -245,9 +243,8 @@ def _write_to_accounts_file(self, email, password_hash, action="add"):
                         existing = f.read()
                     if email in existing:
                         raise UserError(
-                            self.env._(
-                                "Email address %(email)s already exists."
-                            ).format(email=email)
+                            self.env._("Email address %(email)s already exists.")
+                            % email
                         )
                     # Append by rewriting atomically
                     self._atomic_write(accounts_file, existing + line)
@@ -527,7 +524,7 @@ def _delete_email_alias(self):
                     if not line.startswith(f"{self.email} "):
                         f.write(line)
 
-            _logger.info("Deleted email alias for: %(emails)s", self.email)
+            _logger.info("Deleted email alias for: %s", self.email)
         except Exception as e:
             _logger.warning("Error deleting email alias: %s", e)
 
@@ -549,7 +546,7 @@ def _delete_email_alias_by_email(self, email):
                     if not line.startswith(f"{email} "):
                         f.write(line)
 
-            _logger.info("Deleted email alias for: %(emails)s", email)
+            _logger.info("Deleted email alias for: %s", email)
         except Exception as e:
             _logger.warning("Error deleting email alias for %s: %s", email, e)
 
@@ -644,9 +641,8 @@ def create(self, vals_list):
 
                 record.state = "error"
                 raise UserError(
-                    self.env._(
-                        "Failed to create mail account '%(email)s': %(error)s"
-                    ).format(email=record.email, error=str(e))
+                    self.env._("Failed to create mail account '%s': %(error)s")
+                    % (record.email, str(e))
                 ) from e
 
         # Q35: Send reminder notification for IMAP server confirmation
@@ -666,7 +662,7 @@ def create(self, vals_list):
                             "message": self.env._(
                                 "Please confirm IMAP server(s) in "
                                 "Settings → Technical → Incoming Mail Servers "
-                                "for: %(emails)s"
+                                "for: %s"
                             )
                             % {
                                 "emails": ", ".join(
@@ -715,7 +711,7 @@ def unlink(self):
             try:
                 smtp_servers_to_delete.sudo().unlink()
                 _logger.info(
-                    "Batch deleted %(count)d SMTP servers", len(smtp_servers_to_delete)
+                    "Batch deleted %d SMTP servers", len(smtp_servers_to_delete)
                 )
             except Exception as e:
                 _logger.warning("Failed to batch delete SMTP servers: %s", e)
@@ -826,9 +822,7 @@ def action_sync_from_server(self):
             "tag": "display_notification",
             "params": {
                 "title": self.env._("Sync Completed"),
-                "message": self.env._("%(count)d new accounts imported.").format(
-                    count=synced
-                ),
+                "message": self.env._("%d new accounts imported.").format(count=synced),
                 "type": "success",
             },
         }
@@ -910,9 +904,8 @@ def action_recover_from_error(self):
             except Exception as e:
                 _logger.exception("Failed to recover mail account %s", record.email)
                 raise UserError(
-                    self.env._(
-                        "Failed to recover mail account '%(email)s': %(error)s"
-                    ).format(email=record.email, error=str(e))
+                    self.env._("Failed to recover mail account '%s': %(error)s")
+                    % (record.email, str(e))
                 ) from e
 
         return {
@@ -947,7 +940,7 @@ def action_fix_smtp_owner(self):
                 )
                 fixed_count += 1
                 _logger.info(
-                    "Fixed SMTP server for: %(emails)s (filter: %s)",
+                    "Fixed SMTP server for: %s (filter: %s)",
                     record.email,
                     from_filter,
                 )
@@ -958,8 +951,9 @@ def action_fix_smtp_owner(self):
             "params": {
                 "title": self.env._("SMTP Servers Fixed"),
                 "message": self.env._(
-                    "%(count)d SMTP server(s) updated with correct from_filter."
-                ).format(count=fixed_count),
+                    "%d SMTP server(s) updated with correct from_filter."
+                )
+                % fixed_count,
                 "type": "success",
             },
         }
@@ -987,7 +981,7 @@ def action_fix_all_smtp_owners(self):
             )
             fixed_count += 1
             _logger.info(
-                "Batch fixed SMTP server for: %(emails)s (filter: %s)",
+                "Batch fixed SMTP server for: %s (filter: %s)",
                 account.email,
                 from_filter,
             )
@@ -998,8 +992,9 @@ def action_fix_all_smtp_owners(self):
             "params": {
                 "title": self.env._("Batch Fix Complete"),
                 "message": self.env._(
-                    "%(count)d SMTP server(s) fixed with correct from_filter."
-                ).format(count=fixed_count),
+                    "%d SMTP server(s) fixed with correct from_filter."
+                )
+                % fixed_count,
                 "type": "success",
             },
         }

mail_server_manager/models/mail_mail.py

@@ -136,9 +136,10 @@ def _check_email_limit(self, mail_account):
         if mail_account.emails_sent_today >= limit:
             raise UserError(
                 self.env._(
-                    "Daily email limit reached (%(limit)s emails). "
+                    "Daily email limit reached (%s emails). "
                     "Please try again tomorrow or contact your administrator."
-                ).format(limit=limit)
+                )
+                % limit
             )
 
         return True