[MIG] endpoint_cache_preheat: Migration to 18.0

Author: SilvioC2C

endpoint_cache_preheat/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Endpoint cache pre-heat",
     "summary": """Provide basic pre-caching features for endpoints""",
-    "version": "14.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "LGPL-3",
     "development_status": "Alpha",
     "author": "Camptocamp, Odoo Community Association (OCA)",

endpoint_cache_preheat/data/cron.xml

@@ -6,12 +6,10 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">1</field>
         <field name="interval_type">days</field>
-        <field name="numbercall">-1</field>
         <field
             name="nextcall"
             eval="(datetime.now() + timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')"
         />
-        <field name="doall" eval="False" />
         <field name="model_id" ref="endpoint.model_endpoint_endpoint" />
         <field name="state">code</field>
         <field name="code">model.cron_endpoint_cache_preheat()</field>

endpoint_cache_preheat/models/endpoint_mixin.py

@@ -56,6 +56,7 @@ def _cron_endpoint_cache_preheat(self):
         self.cache_preheat_ts = fields.Datetime.now()
 
     def _endpoint_cache_wipe(self, domain):
+        # pylint: disable=missing-return
         super()._endpoint_cache_wipe(domain)
         self.cache_preheat_ts = False
 

endpoint_cache_preheat/tests/test_endpoint.py

@@ -3,7 +3,9 @@
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
 
 import textwrap
+from datetime import datetime
 
+from dateutil.relativedelta import relativedelta
 from freezegun import freeze_time
 
 from odoo import fields
@@ -16,6 +18,7 @@
 class TestEndpoint(CommonEndpoint):
     @classmethod
     def _setup_records(cls):
+        # pylint: disable=missing-return
         super()._setup_records()
         cls.endpoint1 = cls.env.ref("endpoint.endpoint_demo_1")
         cls.cron = cls.env.ref("endpoint_cache_preheat.cron_endpoint_cache_preheat")
@@ -27,7 +30,7 @@ def _run_cron(self):
     def test_cron_preheat_cache(self):
         self.assertFalse(self.endpoint1.cache_preheat)
         self.assertFalse(self.endpoint1.cache_preheat_ts)
-        now = fields.Datetime.from_string("2025-02-19 23:00:00")
+        now = datetime.now().replace(microsecond=0)
         ep_daily = self.endpoint1.copy({"route": "/daily"})
         ep_daily.cache_preheat = True
         ep_daily.cache_preheat_ts = now
@@ -46,14 +49,15 @@ def test_cron_preheat_cache(self):
         )
         ep_weekly = ep_daily.copy({"route": "/weekly", "cache_policy": "week"})
         ep_monthly = ep_daily.copy({"route": "/monthly", "cache_policy": "month"})
+
         # 1 day later
-        future_date = fields.Datetime.from_string("2025-02-20 20:00:00")
-        with trap_jobs() as trap, freeze_time(future_date), MockRequest(self.env):
+        future_date_1 = now + relativedelta(days=1)
+        with trap_jobs() as trap, freeze_time(future_date_1), MockRequest(self.env):
             self._run_cron()
             trap.assert_jobs_count(1)
             trap.assert_enqueued_job(ep_daily._cron_endpoint_cache_preheat)
             trap.perform_enqueued_jobs()
-            self.assertEqual(ep_daily.cache_preheat_ts, future_date)
+            self.assertEqual(ep_daily.cache_preheat_ts, future_date_1)
             self.assertEqual(ep_weekly.cache_preheat_ts, now)
             self.assertEqual(ep_monthly.cache_preheat_ts, now)
 
@@ -75,22 +79,23 @@ def test_cron_preheat_cache(self):
             ),
             0,
         )
+
         # 2 days later
-        future_date = fields.Datetime.from_string("2025-02-21 21:30:00")
-        with trap_jobs() as trap, freeze_time(future_date), MockRequest(self.env):
+        future_date_2 = now + relativedelta(days=2)
+        with trap_jobs() as trap, freeze_time(future_date_2), MockRequest(self.env):
             self._run_cron()
             trap.assert_jobs_count(1)
             trap.assert_enqueued_job(ep_daily._cron_endpoint_cache_preheat)
             trap.perform_enqueued_jobs()
-            self.assertEqual(ep_daily.cache_preheat_ts, future_date)
+            self.assertEqual(ep_daily.cache_preheat_ts, future_date_2)
             self.assertEqual(ep_weekly.cache_preheat_ts, now)
             self.assertEqual(ep_monthly.cache_preheat_ts, now)
 
         self.assertEqual(
             self.env["ir.attachment"].search_count(
                 ep_daily._endpoint_view_cache_domain()
             ),
-            1,
+            2,
         )
         self.assertEqual(
             self.env["ir.attachment"].search_count(
@@ -104,22 +109,23 @@ def test_cron_preheat_cache(self):
             ),
             0,
         )
+
         # 1 week later
-        future_date = fields.Datetime.from_string("2025-02-26 19:45:00")
-        with trap_jobs() as trap, freeze_time(future_date), MockRequest(self.env):
+        future_date_3 = now + relativedelta(weeks=1)
+        with trap_jobs() as trap, freeze_time(future_date_3), MockRequest(self.env):
             self._run_cron()
             trap.assert_jobs_count(2)
             trap.assert_enqueued_job(ep_daily._cron_endpoint_cache_preheat)
             trap.perform_enqueued_jobs()
-            self.assertEqual(ep_daily.cache_preheat_ts, future_date)
-            self.assertEqual(ep_weekly.cache_preheat_ts, future_date)
+            self.assertEqual(ep_daily.cache_preheat_ts, future_date_3)
+            self.assertEqual(ep_weekly.cache_preheat_ts, future_date_3)
             self.assertEqual(ep_monthly.cache_preheat_ts, now)
 
         self.assertEqual(
             self.env["ir.attachment"].search_count(
                 ep_daily._endpoint_view_cache_domain()
             ),
-            2,
+            3,
         )
         self.assertEqual(
             self.env["ir.attachment"].search_count(
@@ -133,22 +139,23 @@ def test_cron_preheat_cache(self):
             ),
             0,
         )
+
         # 1 month later
-        future_date = fields.Datetime.from_string("2025-03-19 23:45:00")
-        with trap_jobs() as trap, freeze_time(future_date), MockRequest(self.env):
+        future_date_4 = now + relativedelta(months=1)
+        with trap_jobs() as trap, freeze_time(future_date_4), MockRequest(self.env):
             self._run_cron()
             trap.assert_jobs_count(3)
             trap.assert_enqueued_job(ep_daily._cron_endpoint_cache_preheat)
             trap.perform_enqueued_jobs()
-            self.assertEqual(ep_daily.cache_preheat_ts, future_date)
-            self.assertEqual(ep_weekly.cache_preheat_ts, future_date)
-            self.assertEqual(ep_monthly.cache_preheat_ts, future_date)
+            self.assertEqual(ep_daily.cache_preheat_ts, future_date_4)
+            self.assertEqual(ep_weekly.cache_preheat_ts, future_date_4)
+            self.assertEqual(ep_monthly.cache_preheat_ts, future_date_4)
 
         self.assertEqual(
             self.env["ir.attachment"].search_count(
                 ep_daily._endpoint_view_cache_domain()
             ),
-            3,
+            4,
         )
         self.assertEqual(
             self.env["ir.attachment"].search_count(