fix bps bug and ensure running var has value

Author: memalhot

.github/workflows/precommit.yaml

@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v5
       - uses: actions/setup-python@v6
         with:
-          python-version: "3.10"
+          python-version: "3.11"
       - name: Set up uv
         uses: astral-sh/setup-uv@v7
       - name: Install dependencies

batchtools/batchtools.py

@@ -32,6 +32,7 @@ def build_parser(self) -> None:
             "--verbose",
             "-v",
             action="count",
+            default=0,
             help="Increase verbosity of output",
         )
 

batchtools/bps.py

@@ -11,14 +11,16 @@
 
 
 class ListPodsCommandArgs(argparse.Namespace):
-    verbose: int = 0
+    verbose: int | None = 0
     node_names: list[str] = []
 
 
 class ListPodsCommand(Command):
     """
-    List active GPU pods per node. By default prints only BUSY nodes.
-    With -v/--verbose, prints FREE for nodes seen with Running pods but 0 GPUs.
+    batchtools [-v] bps [-h] [node-name [node-name ...]]
+
+    List active GPU pods per node. By default prints only BUSY nodes. So, it all nodes are FREE, it will return empty nodes/
+    With -v/--verbose, prints FREE for nodes that have Running pods but 0 GPUs.
     """
 
     name: str = "bps"
@@ -35,43 +37,45 @@ def build_parser(cls, subparsers: SubParserFactory):
     @override
     def run(args: argparse.Namespace):
         args = cast(ListPodsCommandArgs, args)
+        v = args.verbose or 0  # treat None as 0
+
         try:
             with oc.timeout(120):
                 all_pods = oc.selector("pods", all_namespaces=True).objects()
 
             if args.node_names:
-                # get individual nodes without repeats
+                # filter to Running pods on requested nodes
                 node_set = set(args.node_names)
-                # Filter to Running pods on requested nodes
                 pods_for_nodes = [
                     p
                     for p in all_pods
                     if getattr(p.model.status, "phase", None) == "Running"
                     and (getattr(p.model.spec, "nodeName", None) or "") in node_set
                 ]
+
                 # Group by node
-                pods_by_node = defaultdict(list)
+                pods_by_node: dict[str, list] = defaultdict(list)
                 for p in pods_for_nodes:
                     n = getattr(p.model.spec, "nodeName", None) or ""
                     pods_by_node[n].append(p)
 
+                # Emit per requested node (only those requested)
                 for node in node_set:
-                    lines = summarize_gpu_pods(
-                        pods_by_node.get(node, []), args.verbose > 0
-                    )
-                    if not lines and args.verbose:
+                    lines = summarize_gpu_pods(pods_by_node.get(node, []), v > 0)
+                    if not lines and v > 0:
                         print(f"{node}: FREE")
                     else:
                         for ln in lines:
                             print(ln)
+
             else:
-                # One global summary over all Running pods
+                # Global summary over all Running pods
                 running = [
                     p
                     for p in all_pods
                     if getattr(p.model.status, "phase", None) == "Running"
                 ]
-                for ln in summarize_gpu_pods(running, args.verbose > 0):
+                for ln in summarize_gpu_pods(running, v > 0):
                     print(ln)
 
         except oc.OpenShiftPythonException as e:
@@ -105,7 +109,7 @@ def summarize_gpu_pods(pods, verbose: bool) -> list[str]:
         except Exception:
             continue
 
-    lines = []
+    lines: list[str] = []
     nodes = sorted(seen_nodes or totals.keys())
     for node in nodes:
         total = totals.get(node, 0)

python_batchtools.egg-info/PKG-INFO

@@ -0,0 +1,78 @@
+Metadata-Version: 2.4
+Name: python-batchtools
+Version: 0.1.0
+Summary: Add your description here
+Requires-Python: >=3.11
+Description-Content-Type: text/markdown
+Requires-Dist: openshift-client>=2.0.5
+Requires-Dist: typing-extensions>=4.15.0
+
+# python-batchtools
+
+## Set up your development environment
+
+### Install tools
+
+1. Start by installing `uv`. Depending on your distribution, this may be as simple as:
+
+    ```sh
+    sudo dnf -y install uv
+    ```
+
+    If you would like to run the latest version, you can install the command using `pipx`. First, install `pipx`:
+
+    ```
+    sudo dnf -y install pipx
+    ```
+
+    And then use `pipx` to install `uv`:
+
+    ```
+    pipx install uv
+    ```
+
+2. Next, install `pre-commit`. As with `uv`, you can install this using your system package manager:
+
+    ```
+    sudo dnf -y install pre-commit
+    ```
+
+    Or you can install a possibly more recent version using `pipx`:
+
+    ```
+    pipx install pre-commit
+    ```
+
+
+### Activate pre-commit
+
+Activate `pre-commit` for your working copy of this repository by running:
+
+```
+pre-commit install
+```
+
+This will configure `.git/hooks/pre-commit` to run the `pre-commit` tool every time you make a commit. Running these tests locally ensures that your code is clean and that tests are passing before you share your code with others. To manually run all the checks:
+
+```
+pre-commit run --all-files
+```
+
+
+### Install dependencies
+
+To install the project dependencies, run:
+
+```
+uv sync --all-extras
+```
+
+### Run tests
+
+To run just the unit tests:
+
+```
+uv run pytest
+```
+
+This will generate a test coverage report in `htmlcov/index.html`.

python_batchtools.egg-info/SOURCES.txt

@@ -0,0 +1,28 @@
+README.md
+pyproject.toml
+batchtools/__init__.py
+batchtools/basecommand.py
+batchtools/batchtools.py
+batchtools/bd.py
+batchtools/bj.py
+batchtools/bl.py
+batchtools/bp.py
+batchtools/bps.py
+batchtools/bq.py
+batchtools/br.py
+batchtools/build_yaml.py
+batchtools/file_setup.py
+batchtools/helpers.py
+python_batchtools.egg-info/PKG-INFO
+python_batchtools.egg-info/SOURCES.txt
+python_batchtools.egg-info/dependency_links.txt
+python_batchtools.egg-info/entry_points.txt
+python_batchtools.egg-info/requires.txt
+python_batchtools.egg-info/top_level.txt
+tests/test_batchtools.py
+tests/test_bd.py
+tests/test_bj.py
+tests/test_bl.py
+tests/test_bp.py
+tests/test_bps.py
+tests/test_br.py

python_batchtools.egg-info/dependency_links.txt

@@ -0,0 +1,2 @@
+[console_scripts]
+batchtools = batchtools.batchtools:main

python_batchtools.egg-info/entry_points.txt

@@ -0,0 +1,2 @@
+openshift-client>=2.0.5
+typing-extensions>=4.15.0

python_batchtools.egg-info/requires.txt

@@ -0,0 +1 @@
+batchtools