Skip to content

Commit deeadff

Browse files
authored
Update windows-msvc.yml
minor updates to expected failures
1 parent d28f9fa commit deeadff

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

.github/workflows/windows-msvc.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,8 @@ jobs:
177177
sed 's/x64\/Debug/${{ env.ARCHDIR }}\/${{ matrix.target }}/g' atlocal_win > atlocal
178178
autom4te --lang=autotest -I ./testsuite.src ./testsuite.at -o ./testsuite
179179
180+
# Fail tests that behave differently under MSVC Debug
181+
# - Internal storage: different memory layout leading to different error
180182
- name: Adjust testsuite
181183
shell: C:\shells\msys2bash.cmd {0}
182184
run: |
@@ -186,11 +188,16 @@ jobs:
186188
# Fail tests that behave differently under MSVC Debug
187189
# - System routine CBL_GC_HOSTED: fails because libcob is linked with the debug version
188190
# of the C runtime while the generated module is linked with the release version
191+
# CHECKME: cobc should use cl.exe /MTd and therefore all should use the debug runtime
192+
# - Internal storage: runtime checks abort before signal handler
193+
# - COB_SIGNAL_REGIME: runtime checks abort before signal handler
189194
- name: Adjust testsuite for Debug target
190195
if: ${{ matrix.target == 'Debug' }}
191196
shell: C:\shells\msys2bash.cmd {0}
192197
run: |
193198
sed -i '/run_extensions/{N;/System routine CBL_GC_HOSTED/{N;s/at_xfail=no/at_xfail=yes/;}}' tests/testsuite
199+
sed -i '/run_misc/{N;/write to internal storage (1)/{N;N;N;N;s/traceon/traceon; echo "workflow:1">"$at_check_line_file"; at_fn_check_skip 77/;}}' tests/testsuite
200+
sed -i '/run_misc/{N;/COB_SIGNAL_REGIME/{N;s/at_xfail=no/at_xfail=yes/;}}' tests/testsuite
194201
195202
- name: Run testsuite
196203
run: |

0 commit comments

Comments
 (0)