Skip to content

Commit 2a74dee

Browse files
authored
Merge pull request #33 from nberth/check-old-code-version-in-ci
Run tests with old versions of VSCode in the CI
2 parents b169ad3 + 4a035d2 commit 2a74dee

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

.github/workflows/ci.yml

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,14 @@ jobs:
1818
- windows-latest
1919
node:
2020
- 20
21+
code-version:
22+
- stable
23+
- 1.66.0
2124
include:
22-
- { os: ubuntu-latest, node: 22 }
23-
- { os: ubuntu-latest, node: 24 }
25+
- { os: ubuntu-latest, node: 22, code-version: stable }
26+
- { os: ubuntu-latest, node: 24, code-version: stable }
2427
runs-on: ${{ matrix.os }}
25-
name: Test with Node ${{ matrix.node }} on ${{ matrix.os }}
28+
name: Test with Node ${{ matrix.node }} and VSCode ${{ matrix.code-version }} on ${{ matrix.os }}
2629
steps:
2730
- name: Checkout code
2831
uses: actions/checkout@v2
@@ -33,22 +36,22 @@ jobs:
3336
node-version: ${{ matrix.node }}
3437
# node-version-file: 'package.json'
3538

36-
- name: Cache VSCode test directory
37-
uses: actions/cache@v4
38-
with:
39-
path: .vscode-test
40-
key: ${{ runner.os }}-${{ matrix.node }}-vscode-test-${{ hashFiles('package-lock.json') }}
41-
4239
- name: Install dependencies
4340
run: npm install
4441

4542
- name: Compile
4643
run: npm run compile
4744

45+
- name: Cache VSCode test directory
46+
uses: actions/cache@v4
47+
with:
48+
path: .vscode-test
49+
key: ${{ runner.os }}-${{ matrix.node }}-${{ matrix.code-version }}-vscode-test-${{ hashFiles('package-lock.json') }}
50+
4851
- name: Run tests
49-
run: xvfb-run -a npm test
52+
run: xvfb-run -a npm test -- --code-version ${{ matrix.code-version }}
5053
if: runner.os == 'Linux'
5154

5255
- name: Run tests
53-
run: npm test
56+
run: npm test -- --code-version ${{ matrix.code-version }}
5457
if: runner.os != 'Linux'

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"license": "GPL-3.0",
2525
"icon": "icon.png",
2626
"engines": {
27-
"vscode": "^1.44.0",
27+
"vscode": "^1.66.0",
2828
"node": ">=20"
2929
},
3030
"main": "./out/src/extension",
@@ -261,7 +261,7 @@
261261
"prepare": "tsc -p ./",
262262
"compile": "tsc -p ./",
263263
"watch": "tsc -w -p ./",
264-
"test": "npm run compile && npm exec vscode-test",
264+
"test": "npm run compile && vscode-test",
265265
"lint": "eslint -c .eslintrc.js --ext .ts ./"
266266
},
267267
"devDependencies": {

0 commit comments

Comments
 (0)