Skip to content

Fix discrete adjoint when there are extra time steps #426

@albangossard

Description

@albangossard

It seems that there is an issue in the discrete adjoint when we use extra time steps as what is needed to compute the adjoint.

Surprisingly the discrete adjoint has a higher error when we use LossH and tV_ref isn't empty. A store argument was added in #420 to mitigate this so that (i) we don't compute the solution where it's not needed and (ii) the discrete adjoint has a better accuracy when we use only LossH (see this thread #420 (comment)).
Obviously this doesn't fix the underlying bug and we should address it properly

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggradientGradient computation related topicsmath

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions