Skip to content

Improve performance for a fast run #150

@facusapienza21

Description

@facusapienza21

@JordiBolibar if we want people to use this tool, we need to make it fast! I made changes in the organization of SphereUDE (similar to what we have in ODINN) and it would be great to make this code faster so we can run a good regression in a few minutes.

I think having custom Adjoints will definitively help, but I wonder where else in the code we can improve performance. Some notes I took from the SciML style documentation are

  • Out-Of-Place and Immutability is preferred when sufficient performant
  • Avoid globals variables
  • Closures should be avoided whenever possible
  • Avoid bounds check removal, and if done, add appropriate manual checks
  • I am sure I am missing other things, but it would be nice to take a look at the code and see where we can get a significant boost in performance. Notice we have benchmark/run.jl to test runtime/memory use of the different AD methods we use.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions