update based on review comments

ElizabethOkerio · ElizabethOkerio · commit 4369f21a860f · 2023-09-05T11:56:44.000+03:00
diff --git a/src/Microsoft.AspNetCore.OData/Query/Expressions/SelectExpandBinder.cs b/src/Microsoft.AspNetCore.OData/Query/Expressions/SelectExpandBinder.cs
@@ -487,10 +487,7 @@ private static Expression RemoveNonStructucalProperties(QueryBinderContext conte
                         }
                         else if (isPropertyNullable)
                         {
-                            propertyValue = Expression.Condition(
-                               test: Expression.Equal(propertyValue, Expression.Constant(value: null)),
-                               ifTrue: Expression.Constant(value: null, type: nullablePropertyType),
-                               ifFalse: nullablePropertyValue);
+                            propertyValue = nullablePropertyValue;
                         }
 
                         bindings.Add(Expression.Bind(prop, propertyValue));

Original file line number	Diff line number	Diff line change
`@@ -487,10 +487,7 @@ private static Expression RemoveNonStructucalProperties(QueryBinderContext conte`
`487`	`487`	`}`
`488`	`488`	`else if (isPropertyNullable)`
`489`	`489`	`{`
`490`		`- propertyValue = Expression.Condition(`
`491`		`- test: Expression.Equal(propertyValue, Expression.Constant(value: null)),`
`492`		`- ifTrue: Expression.Constant(value: null, type: nullablePropertyType),`
`493`		`- ifFalse: nullablePropertyValue);`
	`490`	`+ propertyValue = nullablePropertyValue;`
`494`	`491`	`}`
`495`	`492`
`496`	`493`	`bindings.Add(Expression.Bind(prop, propertyValue));`