-
Notifications
You must be signed in to change notification settings - Fork 131
Closed
Description
The Achilles README file currently states that Achilles is part of HADES, but this is not (yet) the case. There are several important requirements that need to before we can add Achilles to HADES (which I would very much like to see):
- HADES packages can only depend on packages in CRAN, and on other HADES packages. That is because both have clearly defined release conventions, so we can always get the lastest version, or some specified historic version. Achilles depends on Castor, which is in neither CRAN nor HADES. Either move the code required by Achilles into Achilles (my preference), or go through the process of adding Castor to HADES.
- The head of the master branch should be the latest released version, so
remotes::install_github()installs the latest released version, not the latest develop version as is currently the case. - GitHub actions should be in place to run R check, and automatically create releases when there's a push to master. (see other HADES packages).
- Unit tests should be added / restored (there used to be unit tests against the OHDSI database testing servers)
- The documentation website should adhere to the HADES style (see other HADES repos).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels