Skip to content

Commit b3d6130

Browse files
committed
Better handle missing indicationId
1 parent 1482916 commit b3d6130

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

inst/sql/sql_server/getCmMetaEstimationV6.sql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ SELECT ev.evidence_synthesis_description AS database_name
22
,r.analysis_id
33
,a.description
44
,c1.cohort_name AS target_name
5-
,r.target_id
5+
,tc.target_id
66
,c2.cohort_name AS comparator_name
7-
,r.comparator_id
7+
,tc.comparator_id
88
,c4.cohort_name AS indication_name
99
,tc.nesting_cohort_id AS indication_id
1010
,c3.cohort_name AS outcome_name
@@ -31,12 +31,12 @@ INNER JOIN @schema.@cm_table_prefixtarget_comparator_outcome AS tco ON r.target_
3131
INNER JOIN @schema.@es_table_prefixcm_diagnostics_summary AS unblind ON r.analysis_id = unblind.analysis_id
3232
AND r.target_comparator_id = unblind.target_comparator_id
3333
AND r.outcome_id = unblind.outcome_id
34-
INNER JOIN @schema.@cg_table_prefixcohort_definition AS c1 ON c1.cohort_definition_id = r.target_id
35-
INNER JOIN @schema.@cg_table_prefixcohort_definition AS c2 ON c2.cohort_definition_id = r.comparator_id
34+
INNER JOIN @schema.@cg_table_prefixcohort_definition AS c1 ON c1.cohort_definition_id = tc.target_id
35+
INNER JOIN @schema.@cg_table_prefixcohort_definition AS c2 ON c2.cohort_definition_id = tc.comparator_id
3636
INNER JOIN @schema.@cg_table_prefixcohort_definition AS c3 ON c3.cohort_definition_id = r.outcome_id
3737
LEFT JOIN @schema.@cg_table_prefixcohort_definition AS c4 ON c4.cohort_definition_id = tc.nesting_cohort_id
3838
INNER JOIN @schema.@cm_table_prefixanalysis AS a ON a.analysis_id = r.analysis_id
3939
INNER JOIN @schema.@es_table_prefixanalysis AS ev ON ev.evidence_synthesis_analysis_id = r.evidence_synthesis_analysis_id
4040
WHERE r.calibrated_rr != 0
4141
AND tco.outcome_of_interest = 1
42-
AND unblind.unblind = 1 {@include_target}?{and r.target_id IN (@target_id) } {@include_outcome}?{and r.outcome_id IN (@outcome_id) } {@include_comparator}?{and r.comparator_id IN (@comparator_id) };
42+
AND unblind.unblind = 1 {@include_target}?{and tc.target_id IN (@target_id) } {@include_outcome}?{and r.outcome_id IN (@outcome_id) } {@include_comparator}?{and tc.comparator_id IN (@comparator_id) };

inst/sql/sql_server/getCmNegativeControlEstimatesV6.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ INNER JOIN @schema.@cm_table_prefixdiagnostics_summary ds ON ds.target_comparato
99
AND ds.analysis_id = cmr.analysis_id
1010
AND ds.database_id = cmr.database_id
1111
AND ds.outcome_id = cmr.outcome_id
12-
WHERE cmtco.outcome_of_interest != 1 {@exclude_positive_controls}?{AND cmtco.true_effect_size = 1 } {@use_target}?{AND tc.target_id IN (@target_ids) } {@use_comparator}?{AND tc.comparator_id IN (@comparator_ids) } {@use_indication}?{AND tc.nesting_cohort_id IN (@indication_ids) } {@use_analysis}?{AND cmr.analysis_id IN (@analysis_ids) } {@use_database}?{AND cmr.database_id IN (@database_ids) };
12+
WHERE cmtco.outcome_of_interest != 1 {@exclude_positive_controls}?{AND cmtco.true_effect_size = 1 } {@use_target}?{AND tc.target_id IN (@target_ids) } {@use_comparator}?{AND tc.comparator_id IN (@comparator_ids) } {@use_indication}?{AND tc.nesting_cohort_id IN (@indication_ids) }:{and tc.nesting_cohort_id IS NULL} {@use_analysis}?{AND cmr.analysis_id IN (@analysis_ids) } {@use_database}?{AND cmr.database_id IN (@database_ids) };

inst/sql/sql_server/getCmPropensityModelV6.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ FROM (
1616
JOIN @schema.@cm_table_prefixpropensity_model cmpm ON cmc.covariate_id = cmpm.covariate_id
1717
JOIN @schema.@cm_table_prefixtarget_comparator tc ON tc.target_comparator_id = cmpm.target_comparator_id
1818
WHERE tc.target_id = @target_id
19-
AND tc.comparator_id = @comparator_id {@use_indication}?{AND tc.nesting_cohort_id = @indication_id}
19+
AND tc.comparator_id = @comparator_id {@use_indication}?{AND tc.nesting_cohort_id = @indication_id}:{and tc.nesting_cohort_id IS NULL}
2020
AND cmpm.analysis_id = @analysis_id
2121
AND cmpm.database_id = '@database_id';

inst/sql/sql_server/getCmTableV6.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ INNER JOIN @schema.@cg_table_prefixcohort_definition AS c3 ON c3.cohort_definiti
1717
LEFT JOIN @schema.@cg_table_prefixcohort_definition AS c4 ON c4.cohort_definition_id = tc.nesting_cohort_id
1818
INNER JOIN @schema.@cm_table_prefixanalysis AS a ON a.analysis_id = tab.analysis_id
1919
INNER JOIN @schema.@database_table AS dmd ON dmd.database_id = tab.database_id
20-
WHERE 1 = 1 {@include_target}?{and tc.target_id IN (@target_id) } {@include_outcome}?{and tab.outcome_id IN (@outcome_id) } {@include_indication}?{and tc.nesting_cohort_id IN (@indication_id) } {@include_comparator}?{and tc.comparator_id IN (@comparator_id) } {@include_database}?{and tab.database_id IN (@database_id) } {@include_analyses}?{and tab.analysis_id IN (@analysis_id) };
20+
WHERE 1 = 1 {@include_target}?{and tc.target_id IN (@target_id) } {@include_outcome}?{and tab.outcome_id IN (@outcome_id) } {@include_indication}?{and tc.nesting_cohort_id IN (@indication_id) }:{and tc.nesting_cohort_id IS NULL} {@include_comparator}?{and tc.comparator_id IN (@comparator_id) } {@include_database}?{and tab.database_id IN (@database_id) } {@include_analyses}?{and tab.analysis_id IN (@analysis_id) };

0 commit comments

Comments
 (0)