Skip to content

Commit ceec1d7

Browse files
authored
Update language labeller regex to include country or region segment (#3497)
Account for the optional country, region, or script segment on the language codes to support: - de-CH - pt-BR - sr-Latn - zh-CN - zh-HK - zh-TW
1 parent 9f125eb commit ceec1d7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/backfill_labels.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
const owner = context.repo.owner;
2121
const repo = context.repo.repo;
2222
23-
const LanguageFileRegex = /(?<section>sentences|responses|tests)\/(?<language_code>[a-z]{2})\/(?<intent>.+)\.yaml/;
23+
const LanguageFileRegex = /(?<section>sentences|responses|tests)\/(?<language_code>[a-z]{2}(-[a-zA-Z]{2,4})?)\/(?<intent>.+)\.yaml/;
2424
2525
async function ensureLabelExists(label) {
2626
try {
@@ -66,7 +66,7 @@ jobs:
6666
const langs = new Set();
6767
for (const path of files) {
6868
const m = LanguageFileRegex.exec(path);
69-
if (m?.groups?.language_code) langs.add(m.groups.language_code);
69+
if (m?.groups?.language_code) langs.add(m.groups.language_code.toLowerCase());
7070
}
7171
const desired = new Set([...langs].map(code => `lang: ${code}`));
7272

.github/workflows/ci_lang_labels.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
}
3434
3535
// Your regex
36-
const LanguageFileRegex = /(?<section>sentences|responses|tests)\/(?<language_code>[a-z]{2})\/(?<intent>.+)\.yaml/;
36+
const LanguageFileRegex = /(?<section>sentences|responses|tests)\/(?<language_code>[a-z]{2}(-[a-zA-Z]{2,4})?)\/(?<intent>.+)\.yaml/;
3737
3838
// Collect changed files (no checkout required)
3939
const files = [];
@@ -48,7 +48,7 @@ jobs:
4848
const langs = new Set();
4949
for (const path of files) {
5050
const m = LanguageFileRegex.exec(path);
51-
if (m?.groups?.language_code) langs.add(m.groups.language_code);
51+
if (m?.groups?.language_code) langs.add(m.groups.language_code.toLowerCase());
5252
}
5353
if (langs.size === 0) {
5454
core.info(`No language-specific files detected for PR #${prNumber}`);

0 commit comments

Comments
 (0)