Fix pluginmanager shading overriding provided services with defaults

Author: qqndrew

API/pom.xml

@@ -31,7 +31,7 @@
     <parent>
         <groupId>org.ohnlp.backbone</groupId>
         <artifactId>backbone-parent</artifactId>
-        <version>3.0.23</version>
+        <version>3.0.24</version>
     </parent>
 
     <artifactId>api</artifactId>

Core/pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>org.ohnlp.backbone</groupId>
         <artifactId>backbone-parent</artifactId>
-        <version>3.0.23</version>
+        <version>3.0.24</version>
     </parent>
 
     <artifactId>core</artifactId>

Example-Backbone-Configs/pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>org.ohnlp.backbone</groupId>
         <artifactId>backbone-parent</artifactId>
-        <version>3.0.23</version>
+        <version>3.0.24</version>
     </parent>
 
     <artifactId>example-backbone-configs</artifactId>

IO/pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>org.ohnlp.backbone</groupId>
         <artifactId>backbone-parent</artifactId>
-        <version>3.0.23</version>
+        <version>3.0.24</version>
     </parent>
 
     <groupId>org.ohnlp.backbone.io</groupId>

Plugin-Manager/pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>org.ohnlp.backbone</groupId>
         <artifactId>backbone-parent</artifactId>
-        <version>3.0.23</version>
+        <version>3.0.24</version>
     </parent>
 
     <artifactId>plugin-manager</artifactId>

Plugin-Manager/src/main/java/org/ohnlp/backbone/pluginmanager/PluginManager.java

@@ -137,6 +137,10 @@ public FileVisitResult visitFile(Path path, BasicFileAttributes attrs) throws IO
                                     return FileVisitResult.CONTINUE;
                                 }
                                 Path tgtPath = fs.getPath(path.toString());
+                                if (tgtPath.toString().contains("META-INF/services") && Files.exists(tgtPath)) {
+                                    // This is a service that already exists. Short-circuit for now as we do not support append
+                                    return FileVisitResult.CONTINUE;
+                                }
                                 Files.createDirectories(tgtPath.getParent());
                                 Files.copy(path, tgtPath, StandardCopyOption.REPLACE_EXISTING);
                                 return FileVisitResult.CONTINUE;

Transforms/pom.xml

@@ -7,7 +7,7 @@
     <parent>
         <groupId>org.ohnlp.backbone</groupId>
         <artifactId>backbone-parent</artifactId>
-        <version>3.0.23</version>
+        <version>3.0.24</version>
     </parent>
 
     <groupId>org.ohnlp.backbone.transforms</groupId>

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>org.ohnlp.backbone</groupId>
     <artifactId>backbone-parent</artifactId>
-    <version>3.0.23</version>
+    <version>3.0.24</version>
 
 
     <properties>