Skip to content

Commit 3ba96fd

Browse files
committed
Merge pull request 'fix bug 75222' (#352) from fix/bug-75222 into hotfix/v9.0.4
2 parents 17c7722 + 3a321e5 commit 3ba96fd

File tree

2 files changed

+30
-35
lines changed

2 files changed

+30
-35
lines changed

common/loginpage/src/css/styles.less

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1921,7 +1921,7 @@ li.menu-item {
19211921
}
19221922
.search-icon {
19231923
position: absolute;
1924-
top: 55%;
1924+
top: 50%;
19251925
left: 10px;
19261926
transform: translateY(-50%);
19271927
width: 24px;
@@ -1937,7 +1937,7 @@ li.menu-item {
19371937

19381938
.tool.close {
19391939
position: absolute;
1940-
top: 55%;
1940+
top: 50%;
19411941
right: 10px;
19421942
transform: translateY(-50%);
19431943
width: 16px;
@@ -2087,8 +2087,8 @@ li.menu-item {
20872087
}
20882088

20892089
.cloud-icon {
2090-
width: 16px;
2091-
height: 16px;
2090+
width: 20px;
2091+
height: 20px;
20922092
background-size: contain;
20932093
}
20942094
}

common/loginpage/src/paneltemplates.js

Lines changed: 26 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@
9393
<use id="idx-nothing-found-dark" href="#nothing-found-dark"></use>
9494
</svg>
9595
</div>
96-
<p class="no-results-title">${_lang.tplNoResultsTitle}</p>
97-
<p class="no-results-text">${_lang.tplNoResultsText}</p>
96+
<p class="no-results-title" l10n>${_lang.tplNoResultsTitle}</p>
97+
<p class="no-results-text" l10n>${_lang.tplNoResultsText}</p>
9898
</div>
9999
<section class='themed-sroll' panel='all'>
100100
<div class='table-box flex-fill'>
@@ -146,9 +146,7 @@
146146
});
147147

148148
utils.fn.extend(ControllerTemplates.prototype, (function() {
149-
let _page_num = 0,
150-
isLoading = false,
151-
totalPages = null;
149+
let isCloudTmplsLoading = false;
152150

153151
const _on_nav_item_click = function(e) {
154152
$('.nav-item', this.view.$panel).removeClass('selected');
@@ -353,26 +351,30 @@
353351
$('#search-no-results', $panel).toggle(matchCount === 0);
354352
};
355353

356-
const _loadTemplates = function() {
357-
if (isLoading || (totalPages !== null && _page_num >= totalPages)) return;
354+
const _loadTemplates = function(nl, page_num = 0) {
355+
const locale = nl ? nl.split('_')[0].toLowerCase() : 'en';
356+
if (isCloudTmplsLoading) return;
358357

359-
_page_num++;
360-
isLoading = true;
358+
page_num++;
359+
isCloudTmplsLoading = true;
361360

362361
const _domain = localStorage.templatesdomain ? localStorage.templatesdomain : 'https://oforms.onlyoffice.com'; // https://oforms.teamlab.info
363-
const _url = `${_domain}/dashboard/api/oforms?populate=*&locale=en&pagination[page]=${_page_num}`;
362+
const _url = `${_domain}/dashboard/api/oforms?populate=*&locale=${locale}&pagination[page]=${page_num}`;
364363
fetch(_url)
365364
.then(r => r.json())
366365
.then(d => {
367-
isLoading = false;
368-
if (d.data) {
366+
isCloudTmplsLoading = false;
367+
if (d.data && d.data.length > 0) {
369368
_on_add_cloud_templates.call(this, d.data);
370-
totalPages = d.meta.pagination.pageCount;
369+
const totalPages = d.meta.pagination.pageCount;
371370

372-
if (_page_num < totalPages) {
373-
_loadTemplates.call(this);
371+
if (page_num + 1 <= totalPages) {
372+
_loadTemplates.call(this, nl, page_num);
374373
}
375-
}
374+
} else if (d.data && d.data.length === 0 && locale !== 'en') {
375+
_resetPagination.call(this);
376+
_loadTemplates.call(this, 'en', 0);
377+
}
376378
})
377379
.catch (function (err) {
378380
console.error(err);
@@ -382,19 +384,9 @@
382384
})
383385
};
384386

385-
const loadAllPages = function() {
386-
if (isLoading) return;
387-
388-
_page_num = 0;
389-
const self = this;
390-
const loadNext = () => {
391-
if (_page_num < totalPages || totalPages === null) {
392-
_loadTemplates.call(self);
393-
setTimeout(loadNext, 150);
394-
}
395-
};
396-
397-
loadNext();
387+
const _resetPagination = function() {
388+
isCloudTmplsLoading = false;
389+
this.templates.empty();
398390
};
399391

400392
return {
@@ -438,13 +430,16 @@
438430
ls.push("en-US","en_US","en");
439431
window.sdk.LocalFileTemplates(ls);
440432
};
441-
_reload_templates(utils.Lang.id);
442433

443434
CommonEvents.on('lang:changed', (ol, nl) => {
435+
_resetPagination.call(this);
444436
_reload_templates(nl);
437+
_loadTemplates.call(this, nl);
438+
$('#template-search', this.view.$panel).attr('placeholder', utils.Lang.tplSearch);
445439
});
446440

447-
loadAllPages.call(this);
441+
_reload_templates(utils.Lang.id);
442+
_loadTemplates.call(this, utils.Lang.id);
448443

449444
return this;
450445
}

0 commit comments

Comments
 (0)