Skip to content

Syntax error when open file on owncloud web #492

@ltkhanh

Description

@ltkhanh

Hello, I have been used the integration of onlyoffice to owncloud for a year. After making an upgrade of the integration to version 9.12.1, I cannot open office file on my owncloud web (my owncloud version is 10.2.0.5). The message from system log is:

"message": "Exception: {
			"Exception":"ParseError",
			"Message":"syntax error, unexpected ')'",
			"Code":0,
			"Trace":"#0 [internal function]: OCAutoloader->load('OCAOnlyoffice...')
				n#1 /var/www/owncloud/apps/onlyoffice/appinfo/application.php(231): spl_autoload_call('OCAOnlyoffice...')
				n#2 /var/www/owncloud/lib/composer/pimple/pimple/src/Pimple/Container.php(118): OCAOnlyofficeAppInfoApplication->OCAOnlyofficeAppInfo{closure}(Object(OCAppFrameworkDependencyInjectionDIContainer))
				n#3 /var/www/owncloud/lib/private/AppFramework/Utility/SimpleContainer.php(108): PimpleContainer->offsetGet('EditorControlle...')
				n#4 /var/www/owncloud/lib/private/AppFramework/App.php(77): OCAppFrameworkUtilitySimpleContainer->query('EditorControlle...')
				n#5 /var/www/owncloud/lib/private/AppFramework/Routing/RouteActionHandler.php(46): OCAppFrameworkApp::main('EditorControlle...', 'index', Object(OCAppFrameworkDependencyInjectionDIContainer), Array)
				n#6 /var/www/owncloud/lib/private/Route/Router.php(342): OCAppFrameworkRoutingRouteActionHandler->__invoke(Array)
				n#7 /var/www/owncloud/lib/base.php(909): OCRouteRouter->match('/apps/onlyoffic...')
				n#8 /var/www/owncloud/index.php(54): OC::handleRequest()
				n#9 {main}",
			"File":"/var/www/owncloud/apps/onlyoffice/controller/editorcontroller.php",
			"Line":1332
			}"

After checking the file editorcontroller.php, I see the error on line 1331. The original code from line 1323 to 1332 is:

		try {
			$response = $documentService->sendRequestToConvertService(
				$fileUrl,
				$ext,
				$toExtension,
				$key,
				false,
				false,
				$thumbnail,
			);

It should be fixed as the following:

		try {
			$response = $documentService->sendRequestToConvertService(
				$fileUrl,
				$ext,
				$toExtension,
				$key,
				false,
				false,
				$thumbnail
			);

Just remove the comma at the end of the line 1331 then the integration works well.
Best regards.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions