Working android impl

Author: ospfranco

.gitignore

@@ -82,5 +82,3 @@ lib/
 ios/generated
 android/generated
 
-# React Native Nitro Modules
-nitrogen/

android/CMakeLists.txt

@@ -0,0 +1,41 @@
+project(OPServer)
+cmake_minimum_required(VERSION 3.9.0)
+
+set (PACKAGE_NAME "op-server")
+
+file(GLOB_RECURSE shared_files RELATIVE ${CMAKE_SOURCE_DIR}
+     "../cpp/**.cpp"
+)
+file(GLOB_RECURSE android_files RELATIVE ${CMAKE_SOURCE_DIR}
+     "src/main/cpp/**.cpp"
+)
+
+add_library(
+  ${PACKAGE_NAME}
+  SHARED
+  ${shared_files}
+  ${android_files}
+)
+
+include_directories(
+  ../cpp
+  # Android-specific C++ includes
+  src/main/cpp/core
+  src/main/cpp/registry
+  src/main/cpp/turbomodule
+  src/main/cpp/platform
+  src/main/cpp/utils
+  src/main/cpp/views
+)
+
+find_package(ReactAndroid REQUIRED CONFIG)
+find_package(fbjni REQUIRED CONFIG)
+find_library(LOG_LIB log)
+
+target_link_libraries(
+  ${PACKAGE_NAME}
+  ${LOG_LIB}
+  ReactAndroid::reactnative
+  ReactAndroid::jsi
+  fbjni::fbjni
+)

android/build.gradle

@@ -33,10 +33,55 @@ android {
   defaultConfig {
     minSdkVersion getExtOrIntegerDefault("minSdkVersion")
     targetSdkVersion getExtOrIntegerDefault("targetSdkVersion")
+
+    externalNativeBuild {
+      cmake {
+        cppFlags "-frtti -fexceptions -Wall -Wextra -fstack-protector-all"
+        arguments "-DANDROID_STL=c++_shared", "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON"
+
+        buildTypes {
+          debug {
+            cppFlags "-O1 -g"
+          }
+          release {
+            cppFlags "-O2"
+          }
+        }
+      }
+    }
+  }
+
+  externalNativeBuild {
+    cmake {
+      path "CMakeLists.txt"
+    }
   }
 
   buildFeatures {
     buildConfig true
+    prefab true
+    prefabPublishing true
+  }
+
+  packagingOptions {
+    excludes = [
+            "META-INF",
+            "META-INF/**",
+            "**/libc++_shared.so",
+            "**/libfbjni.so",
+            "**/libjsi.so",
+            "**/libfolly_json.so",
+            "**/libfolly_runtime.so",
+            "**/libglog.so",
+            "**/libhermes.so",
+            "**/libhermes-executor-debug.so",
+            "**/libhermes_executor.so",
+            "**/libreactnative.so",
+            "**/libreactnativejni.so",
+            "**/libturbomodulejsijni.so",
+            "**/libreact_nativemodule_core.so",
+            "**/libjscexecutor.so"
+    ]
   }
 
   buildTypes {

android/src/main/cpp/JNIOnLoad.cpp

@@ -0,0 +1,8 @@
+#include "OPServer.hpp"
+#include <fbjni/fbjni.h>
+#include <jni.h>
+
+JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void *) {
+  return facebook::jni::initialize(
+      vm, [] { opserver::JOPServer::registerNatives(); });
+}

android/src/main/cpp/OPServer.cpp

@@ -0,0 +1,35 @@
+#include "OPServer.hpp"
+#include "../cpp/bindings.hpp"
+
+#include <exception>
+
+namespace opserver {
+
+using namespace facebook;
+
+void JOPServer::install(
+    jni::alias_ref<jni::JClass>, jlong runtimePointer,
+    jni::alias_ref<react::CallInvokerHolder::javaobject> callInvokerHolder) {
+  auto runtime = reinterpret_cast<jsi::Runtime *>(runtimePointer);
+  if (runtime == nullptr) {
+    throw std::invalid_argument("jsi::Runtime was null!");
+  }
+
+  if (callInvokerHolder == nullptr) {
+    throw std::invalid_argument("CallInvokerHolder was null!");
+  }
+  auto callInvoker = callInvokerHolder->cthis()->getCallInvoker();
+  if (callInvoker == nullptr) {
+    throw std::invalid_argument("CallInvoker was null!");
+  }
+
+  opserver::install(*runtime, callInvoker);
+}
+
+void JOPServer::registerNatives() {
+  javaClassStatic()->registerNatives({
+      makeNativeMethod("install", JOPServer::install),
+  });
+}
+
+} // namespace opserver

android/src/main/cpp/OPServer.hpp

@@ -0,0 +1,28 @@
+#pragma once
+
+#include <ReactCommon/CallInvoker.h>
+#include <ReactCommon/CallInvokerHolder.h>
+#include <fbjni/fbjni.h>
+#include <jsi/jsi.h>
+
+namespace opserver {
+
+using namespace facebook;
+
+class JOPServer final : public jni::HybridClass<JOPServer> {
+public:
+  static auto constexpr kJavaDescriptor =
+      "Lcom/opengineering/opserver/OpServerModule;";
+  static constexpr auto TAG = "OpServerModule";
+
+  static void registerNatives();
+
+  static void install(
+      jni::alias_ref<jni::JClass>, jlong runtimePointer,
+      jni::alias_ref<react::CallInvokerHolder::javaobject> callInvokerHolder);
+
+private:
+  explicit JOPServer() = default;
+};
+
+} // namespace opserver

android/src/main/java/com/opengineering/opserver/OpServerModule.kt

@@ -1,23 +1,57 @@
 package com.opengineering.opserver
 
+import androidx.annotation.Keep
+import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.ReactApplicationContext
-import com.facebook.react.module.annotations.ReactModule
+import com.facebook.react.bridge.ReactMethod
+import com.facebook.react.common.annotations.FrameworkAPI
+import com.facebook.react.turbomodule.core.CallInvokerHolderImpl
+import android.util.Log;
 
-@ReactModule(name = OpServerModule.NAME)
-class OpServerModule(reactContext: ReactApplicationContext) :
-  NativeOpServerSpec(reactContext) {
+@DoNotStrip
+@Keep
+@OptIn(FrameworkAPI::class)
+@Suppress("KotlinJniMissingFunction")
+class OpServerModule(val context: ReactApplicationContext) :
+  NativeOpServerSpec(context) {
 
   override fun getName(): String {
     return NAME
   }
 
-  // Example method
-  // See https://reactnative.dev/docs/native-modules-android
-  override fun multiply(a: Double, b: Double): Double {
-    return a * b
+  @ReactMethod(isBlockingSynchronousMethod = true)
+  override fun install(): Boolean {
+    try {
+      val jsContext =
+        context.javaScriptContextHolder
+          ?: return false
+
+      val callInvokerHolder =
+        context.jsCallInvokerHolder as? CallInvokerHolderImpl
+          ?: return false
+
+      install(jsContext.get(), callInvokerHolder)
+
+      return true
+    } catch (e: Throwable) {
+      return false
+    }
   }
 
+  private external fun install(
+    jsRuntimePointer: Long,
+    callInvokerHolder: CallInvokerHolderImpl,
+  )
+
   companion object {
     const val NAME = "OpServer"
+
+    @JvmStatic
+    var applicationContext: ReactApplicationContext? = null
+
+    init {
+      System.loadLibrary("op-server");
+      Log.i("OPServer", "Successfully loaded C++ library!");
+    }
   }
 }

src/index.tsx

@@ -36,14 +36,14 @@ if (global.__OPServerProxy == null) {
   const installed = OpServer.install();
   if (!installed) {
     throw new Error(
-      `Failed to install op-sqlite: The native OPSQLite Module could not be installed! Looks like something went wrong when installing JSI bindings, check the native logs for more info`
+      `Failed to install op-server: The Native Module could not be installed! Looks like something went wrong when installing JSI bindings, check the native logs for more info`
     );
   }
 
   // Check again if the constructor now exists. If not, throw an error.
   if (global.__OPServerProxy == null) {
     throw new Error(
-      'OPSqlite native object is not available. Something is wrong. Check the native logs for more information.'
+      'OP Server native object is not available. Something is wrong. Check the native logs for more information.'
     );
   }
 }