Fix misc. build issues and warnings (#2908)

mregen · web-flow · commit 9a434b860c15 · 2024-12-13T17:41:14.000+01:00
- Fix errors and warnings on stricter build systems.
- Some Linux distri do not support brainpool, detect if tests can be run.
diff --git a/.editorconfig b/.editorconfig
@@ -12,6 +12,7 @@ root = true
 # All files
 [*]
 indent_style = space
+tab_width    = 4
 
 # Code files
 [*.{cs,csx,vb,vbx}]
diff --git a/Applications/Quickstarts.Servers/Alarms/AlarmHolders/AlarmConditionTypeHolder.cs b/Applications/Quickstarts.Servers/Alarms/AlarmHolders/AlarmConditionTypeHolder.cs
@@ -28,7 +28,7 @@
  * ======================================================================*/
 
 using System;
-
+using System.Globalization;
 using Opc.Ua;
 
 #pragma warning disable CS1591
@@ -272,7 +272,7 @@ private ServiceResult OnShelve(
                 }
                 else
                 {
-                    dueTo = " due to TimedShelve of " + shelvingTime.ToString();
+                    dueTo = " due to TimedShelve of " + shelvingTime.ToString(CultureInfo.InvariantCulture);
                 }
             }
             else
diff --git a/Applications/Quickstarts.Servers/Alarms/AlarmHolders/DiscreteHolder.cs b/Applications/Quickstarts.Servers/Alarms/AlarmHolders/DiscreteHolder.cs
@@ -28,7 +28,7 @@
  * ======================================================================*/
 
 using System;
-
+using System.Globalization;
 using Opc.Ua;
 
 #pragma warning disable CS0219
@@ -85,7 +85,7 @@ public override void SetValue(string message = "")
 
             if (message.Length == 0)
             {
-                message = "Discrete Alarm analog value = " + value.ToString() + ", active = " + active.ToString();
+                message = "Discrete Alarm analog value = " + value.ToString(CultureInfo.InvariantCulture) + ", active = " + active.ToString();
             }
 
             base.SetValue(message);
diff --git a/Applications/Quickstarts.Servers/MemoryBuffer/MemoryBufferNodeManager.cs b/Applications/Quickstarts.Servers/MemoryBuffer/MemoryBufferNodeManager.cs
@@ -38,6 +38,7 @@
 using Opc.Ua.Server;
 using Opc.Ua.Sample;
 using System.Reflection;
+using System.Globalization;
 
 namespace MemoryBuffer
 {
@@ -234,7 +235,7 @@ protected override object GetManagerHandle(ISystemContext context, NodeId nodeId
                     }
 
                     // check range on offset.
-                    uint offset = Convert.ToUInt32(offsetText);
+                    uint offset = Convert.ToUInt32(offsetText, CultureInfo.InvariantCulture);
 
                     if (offset >= buffer.SizeInBytes.Value)
                     {
diff --git a/Libraries/Opc.Ua.Client.ComplexTypes/Opc.Ua.Client.ComplexTypes.csproj b/Libraries/Opc.Ua.Client.ComplexTypes/Opc.Ua.Client.ComplexTypes.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.Client.ComplexTypes</AssemblyName>
     <TargetFrameworks>$(LibxTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Client.ComplexTypes</PackageId>
     <RootNameSpace>Opc.Ua.Client.ComplexTypes</RootNameSpace>
     <Description>OPC UA Complex Types Client Class Library</Description>
     <IsPackable>true</IsPackable>
diff --git a/Libraries/Opc.Ua.Client/Opc.Ua.Client.csproj b/Libraries/Opc.Ua.Client/Opc.Ua.Client.csproj
@@ -4,7 +4,7 @@
     <DefineConstants>$(DefineConstants);CLIENT_ASYNC</DefineConstants>
     <AssemblyName>Opc.Ua.Client</AssemblyName>
     <TargetFrameworks>$(LibTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Client</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Client</PackageId>
     <RootNamespace>Opc.Ua.Client</RootNamespace>
     <Description>OPC UA Client Class Library</Description>
     <IsPackable>true</IsPackable>
diff --git a/Libraries/Opc.Ua.Client/Session/TraceableSession.cs b/Libraries/Opc.Ua.Client/Session/TraceableSession.cs
@@ -287,7 +287,7 @@ public int OperationTimeout
 
         /// <inheritdoc/>
         public bool CheckDomain => m_session.CheckDomain;
-        
+
         /// <inheritdoc/>
         public ContinuationPointPolicy ContinuationPointPolicy
         {
@@ -661,7 +661,7 @@ public void ReadValues(IList<NodeId> variableIds, IList<Type> expectedTypes, out
                 m_session.ReadValues(variableIds, expectedTypes, out values, out errors);
             }
         }
-        
+
         /// <inheritdoc/>
         public byte[] ReadByteStringInChunks(NodeId nodeId)
         {
@@ -671,8 +671,8 @@ public byte[] ReadByteStringInChunks(NodeId nodeId)
             }
         }
 
-            /// <inheritdoc/>
-            public void ReadDisplayName(IList<NodeId> nodeIds, out IList<string> displayNames, out IList<ServiceResult> errors)
+        /// <inheritdoc/>
+        public void ReadDisplayName(IList<NodeId> nodeIds, out IList<string> displayNames, out IList<ServiceResult> errors)
         {
             using (Activity activity = ActivitySource.StartActivity())
             {
@@ -1289,18 +1289,17 @@ public void ManagedBrowse(RequestHeader requestHeader, ViewDescription view, ILi
             {
                 m_session.ManagedBrowse(requestHeader, view, nodesToBrowse, maxResultsToReturn, browseDirection, referenceTypeId, includeSubtypes, nodeClassMask, out result, out errors);
             }
-
         }
 
         /// <inheritdoc/>        
-        public async Task<(
+        public Task<(
             IList<ReferenceDescriptionCollection>,
             IList<ServiceResult>
             )> ManagedBrowseAsync(RequestHeader requestHeader, ViewDescription view, IList<NodeId> nodesToBrowse, uint maxResultsToReturn, BrowseDirection browseDirection, NodeId referenceTypeId, bool includeSubtypes, uint nodeClassMask, CancellationToken ct = default)
         {
             using (Activity activity = ActivitySource.StartActivity())
             {
-                return await m_session.ManagedBrowseAsync(requestHeader, view, nodesToBrowse, maxResultsToReturn, browseDirection, referenceTypeId, includeSubtypes, nodeClassMask, ct);
+                return m_session.ManagedBrowseAsync(requestHeader, view, nodesToBrowse, maxResultsToReturn, browseDirection, referenceTypeId, includeSubtypes, nodeClassMask, ct);
             }
         }
 
diff --git a/Libraries/Opc.Ua.Configuration/Opc.Ua.Configuration.csproj b/Libraries/Opc.Ua.Configuration/Opc.Ua.Configuration.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.Configuration</AssemblyName>
     <TargetFrameworks>$(LibTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Configuration</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Configuration</PackageId>
     <RootNamespace>Opc.Ua.Configuration</RootNamespace>
     <Description>OPC UA Configuration Class Library</Description>
     <IsPackable>true</IsPackable>
diff --git a/Libraries/Opc.Ua.Gds.Client.Common/Opc.Ua.Gds.Client.Common.csproj b/Libraries/Opc.Ua.Gds.Client.Common/Opc.Ua.Gds.Client.Common.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.Gds.Client.Common</AssemblyName>
     <TargetFrameworks>$(LibTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Gds.Client.Common</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Gds.Client.Common</PackageId>
     <RootNamespace>Opc.Ua.Gds.Client</RootNamespace>
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <Description>OPC UA GDS Client Class Library</Description>
diff --git a/Libraries/Opc.Ua.Gds.Server.Common/Opc.Ua.Gds.Server.Common.csproj b/Libraries/Opc.Ua.Gds.Server.Common/Opc.Ua.Gds.Server.Common.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.Gds.Server.Common</AssemblyName>
     <TargetFrameworks>$(LibTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Gds.Server.Common</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Gds.Server.Common</PackageId>
     <RootNamespace>Opc.Ua.Gds.Server</RootNamespace>
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <Description>OPC UA GDS Server Class Library</Description>
diff --git a/Libraries/Opc.Ua.PubSub/Opc.Ua.PubSub.csproj b/Libraries/Opc.Ua.PubSub/Opc.Ua.PubSub.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.PubSub</AssemblyName>
     <TargetFrameworks>$(LibxTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.PubSub</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.PubSub</PackageId>
     <RootNamespace>Opc.Ua.PubSub</RootNamespace>
     <Description>OPC UA PubSub Class Library</Description>
     <IsPackable>true</IsPackable>
diff --git a/Libraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj b/Libraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.Security.Certificates</AssemblyName>
     <TargetFrameworks>$(LibCoreTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Security.Certificates</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Security.Certificates</PackageId>
     <RootNamespace>Opc.Ua.Security.Certificates</RootNamespace>
     <Description>OPC UA Security X509 Certificates Class Library</Description>
     <IsPackable>true</IsPackable>
diff --git a/Libraries/Opc.Ua.Server/Opc.Ua.Server.csproj b/Libraries/Opc.Ua.Server/Opc.Ua.Server.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <AssemblyName>Opc.Ua.Server</AssemblyName>
     <TargetFrameworks>$(LibTargetFrameworks)</TargetFrameworks>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Server</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Server</PackageId>
     <RootNamespace>Opc.Ua.Server</RootNamespace>
     <Description>OPC UA Server Class Library</Description>
     <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
diff --git a/Stack/Opc.Ua.Bindings.Https/Opc.Ua.Bindings.Https.csproj b/Stack/Opc.Ua.Bindings.Https/Opc.Ua.Bindings.Https.csproj
@@ -4,7 +4,7 @@
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
     <TargetFrameworks>$(HttpsTargetFrameworks)</TargetFrameworks>
     <AssemblyName>Opc.Ua.Bindings.Https</AssemblyName>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Bindings.Https</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Bindings.Https</PackageId>
     <RootNamespace>Opc.Ua.Bindings</RootNamespace>
     <Description>OPC UA Https Binding Library for a Opc.Ua.Server.</Description>
     <IsPackable>true</IsPackable>
diff --git a/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj b/Stack/Opc.Ua.Core/Opc.Ua.Core.csproj
@@ -4,7 +4,7 @@
     <DefineConstants>$(DefineConstants);NET_STANDARD;NET_STANDARD_ASYNC</DefineConstants>
     <TargetFrameworks>$(LibCoreTargetFrameworks)</TargetFrameworks>
     <AssemblyName>Opc.Ua.Core</AssemblyName>
-    <PackageId>OPCFoundation.NetStandard.Opc.Ua.Core</PackageId>
+    <PackageId>$(PackagePrefix).Opc.Ua.Core</PackageId>
     <RootNamespace>Opc.Ua</RootNamespace>
     <Description>OPC UA Core Class Library</Description>
     <IsPackable>true</IsPackable>
diff --git a/Stack/Opc.Ua.Core/Security/Certificates/CertificateValidator.cs b/Stack/Opc.Ua.Core/Security/Certificates/CertificateValidator.cs
@@ -1120,6 +1120,7 @@ await GetIssuerNoExceptionAsync(certificate, explicitList, certificateStore, che
         /// <param name="endpoint">The endpoint for domain validation.</param>
         /// <param name="ct">The cancellation token.</param>
         /// <exception cref="ServiceResultException">If certificate[0] cannot be accepted</exception>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Roslynanalyzer", "IA5352:Do not set X509RevocationMode.NoCheck", Justification = "Revocation is already checked.")]
         protected virtual async Task InternalValidateAsync(X509Certificate2Collection certificates, ConfiguredEndpoint endpoint, CancellationToken ct = default)
         {
             X509Certificate2 certificate = certificates[0];
diff --git a/Stack/Opc.Ua.Core/Stack/Configuration/SecurityConfigurationManager.cs b/Stack/Opc.Ua.Core/Stack/Configuration/SecurityConfigurationManager.cs
@@ -88,11 +88,17 @@ public SecuredApplication ReadConfiguration(string filePath)
             {
                 FileStream reader = File.Open(configFilePath, FileMode.Open, FileAccess.Read, FileShare.Read);
 
-
                 try
                 {
                     byte[] data = new byte[reader.Length];
-                    reader.Read(data, 0, (int)reader.Length);
+                    int bytesRead = reader.Read(data, 0, (int)reader.Length);
+                    if (reader.Length != bytesRead)
+                    {
+                        throw ServiceResultException.Create(
+                            StatusCodes.BadNotReadable,
+                            "Cannot read all bytes of the configuration file: {0}<{1}",
+                            bytesRead, reader.Length);
+                    }
 
                     // find the SecuredApplication element in the file.
                     if (data.ToString().Contains("SecuredApplication"))
diff --git a/Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs b/Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs
@@ -14,6 +14,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Globalization;
 using System.Linq;
 using System.Net;
 using System.Net.Sockets;
@@ -413,7 +414,7 @@ public void UpdateChannelLastActiveTime(string globalChannelId)
             try
             {
                 var channelIdString = globalChannelId.Substring(ListenerId.Length + 1);
-                var channelId = Convert.ToUInt32(channelIdString);
+                var channelId = Convert.ToUInt32(channelIdString, CultureInfo.InvariantCulture);
 
                 TcpListenerChannel channel = null;
                 if (channelId > 0 &&
diff --git a/Tests/Opc.Ua.Client.Tests/ContinuationPointInBatchTest.cs b/Tests/Opc.Ua.Client.Tests/ContinuationPointInBatchTest.cs
@@ -1073,7 +1073,7 @@ private void VerifyExpectedResults(List<string> memoryLogPass,
                 // get the part of the error message after the time stamp:
                 string msg = s.Substring(s.IndexOf("ManagedBrowse"));
                 // create error message from expected results
-                String expectedString = String.Format(
+                String expectedString = Utils.Format(
                     "ManagedBrowse: in pass {0}, {1} {2} occured with a status code {3}.",
                     pass,
                     expectedResults.ExpectedNumberOfBadNoCPSCs[pass],
diff --git a/Tests/Opc.Ua.Core.Tests/Stack/Buffers/ArraySegmentStreamTests.cs b/Tests/Opc.Ua.Core.Tests/Stack/Buffers/ArraySegmentStreamTests.cs
@@ -205,6 +205,7 @@ public void ArraySegmentStreamWrite(
                         Assert.That(position, Is.EqualTo(chunkSize * i));
                     }
 
+                    int bytesRead;
                     switch (random.Next(3))
                     {
                         case 0:
@@ -215,15 +216,17 @@ public void ArraySegmentStreamWrite(
                             break;
                         default:
 #if NET5_0_OR_GREATER
-                            writer.Read(buffer.AsSpan(0, chunkSize));
+                            bytesRead = writer.Read(buffer.AsSpan(0, chunkSize));
+                            Assert.That(chunkSize, Is.EqualTo(bytesRead));
                             for (int v = 0; v < chunkSize; v++)
                             {
                                 Assert.That(buffer[v], Is.EqualTo((byte)i));
                             }
                             break;
 #endif
                         case 1:
-                            writer.Read(buffer, 0, chunkSize);
+                            bytesRead = writer.Read(buffer, 0, chunkSize);
+                            Assert.That(chunkSize, Is.EqualTo(bytesRead));
                             for (int v = 0; v < chunkSize; v++)
                             {
                                 Assert.That(buffer[v], Is.EqualTo((byte)i));
diff --git a/Tests/Opc.Ua.Core.Tests/Types/Utils/UtilsIsEqualTests.cs b/Tests/Opc.Ua.Core.Tests/Types/Utils/UtilsIsEqualTests.cs
@@ -54,7 +54,7 @@ public class UtilsIsEqualTests
         [Params(32, 128, 1024, 4096, 65536)]
         public int PayLoadSize { get; set; } = 1024;
 
-        private bool _windows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
+        private bool m_windows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
 
         /// <summary>
         /// Test IsEqual using the generic IsEqual from previous versions.
@@ -134,7 +134,7 @@ public bool ForLoopBinaryCompare()
         [Benchmark]
         public bool MemCmpByteArrayCompare()
         {
-            if (_windows)
+            if (m_windows)
             {
                 // Validate buffers are the same length.
                 // This also ensures that the count does not exceed the length of either buffer.  
diff --git a/Tests/Opc.Ua.PubSub.Tests/Encoding/MessagesHelper.cs b/Tests/Opc.Ua.PubSub.Tests/Encoding/MessagesHelper.cs
@@ -35,6 +35,7 @@
 using System.ComponentModel;
 using System.Threading;
 using Opc.Ua.PubSub.PublishedData;
+using System.Globalization;
 
 namespace Opc.Ua.PubSub.Tests.Encoding
 {
@@ -2841,21 +2842,21 @@ public static void UpdateSnapshotData(UaPubSubApplication pubSubApplication, UIn
             DataValue boolToggle = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("BoolToggle", namespaceIndexAllTypes), Attributes.Value);
             if (boolToggle.Value is bool)
             {
-                bool boolVal = Convert.ToBoolean(boolToggle.Value);
+                bool boolVal = Convert.ToBoolean(boolToggle.Value, CultureInfo.InvariantCulture);
                 boolToggle.Value = !boolVal;
                 pubSubApplication.DataStore.WritePublishedDataItem(new NodeId("BoolToggle", namespaceIndexAllTypes), Attributes.Value, boolToggle);
             }
             DataValue byteValue = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("Byte", namespaceIndexAllTypes), Attributes.Value);
             if (byteValue.Value is byte)
             {
-                byte byteVal = Convert.ToByte(byteValue.Value);
+                byte byteVal = Convert.ToByte(byteValue.Value, CultureInfo.InvariantCulture);
                 byteValue.Value = ++byteVal;
                 pubSubApplication.DataStore.WritePublishedDataItem(new NodeId("Byte", namespaceIndexAllTypes), Attributes.Value, byteValue);
             }
             DataValue int16Value = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("Int16", namespaceIndexAllTypes), Attributes.Value);
             if (int16Value.Value is Int16)
             {
-                Int16 int16Val = Convert.ToInt16(int16Value.Value);
+                Int16 int16Val = Convert.ToInt16(int16Value.Value, CultureInfo.InvariantCulture);
                 int intIdentifier = int16Val;
                 Interlocked.CompareExchange(ref intIdentifier, 0, Int16.MaxValue);
                 int16Value.Value = (Int16)Interlocked.Increment(ref intIdentifier);
@@ -2864,7 +2865,7 @@ public static void UpdateSnapshotData(UaPubSubApplication pubSubApplication, UIn
             DataValue int32Value = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("Int32", namespaceIndexAllTypes), Attributes.Value);
             if (int32Value.Value is Int32)
             {
-                Int32 int32Val = Convert.ToInt32(int16Value.Value);
+                Int32 int32Val = Convert.ToInt32(int16Value.Value, CultureInfo.InvariantCulture);
                 int intIdentifier = int32Val;
                 Interlocked.CompareExchange(ref intIdentifier, 0, Int32.MaxValue);
                 int32Value.Value = (Int32)Interlocked.Increment(ref intIdentifier);
@@ -2873,7 +2874,7 @@ public static void UpdateSnapshotData(UaPubSubApplication pubSubApplication, UIn
             DataValue uInt16Value = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("UInt16", namespaceIndexAllTypes), Attributes.Value);
             if (uInt16Value.Value is UInt16)
             {
-                UInt16 uInt16Val = Convert.ToUInt16(uInt16Value.Value);
+                UInt16 uInt16Val = Convert.ToUInt16(uInt16Value.Value, CultureInfo.InvariantCulture);
                 int intIdentifier = uInt16Val;
                 Interlocked.CompareExchange(ref intIdentifier, 0, UInt16.MaxValue);
                 uInt16Value.Value = (UInt16)Interlocked.Increment(ref intIdentifier);
@@ -2882,7 +2883,7 @@ public static void UpdateSnapshotData(UaPubSubApplication pubSubApplication, UIn
             DataValue uInt32Value = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("UInt32", namespaceIndexAllTypes), Attributes.Value);
             if (uInt32Value.Value is UInt32)
             {
-                UInt32 uInt32Val = Convert.ToUInt32(uInt32Value.Value);
+                UInt32 uInt32Val = Convert.ToUInt32(uInt32Value.Value, CultureInfo.InvariantCulture);
                 long longIdentifier = uInt32Val;
                 Interlocked.CompareExchange(ref longIdentifier, 0, UInt32.MaxValue);
                 uInt32Value.Value = (UInt32)Interlocked.Increment(ref longIdentifier);
@@ -2891,7 +2892,7 @@ public static void UpdateSnapshotData(UaPubSubApplication pubSubApplication, UIn
             DataValue doubleValue = pubSubApplication.DataStore.ReadPublishedDataItem(new NodeId("Double", namespaceIndexAllTypes), Attributes.Value);
             if (doubleValue.Value is double)
             {
-                double doubleVal = Convert.ToDouble(doubleValue.Value);
+                double doubleVal = Convert.ToDouble(doubleValue.Value, CultureInfo.InvariantCulture);
                 Interlocked.CompareExchange(ref doubleVal, 0, double.MaxValue);
                 doubleValue.Value = ++doubleVal;
                 pubSubApplication.DataStore.WritePublishedDataItem(new NodeId("Double", namespaceIndexAllTypes), Attributes.Value, doubleValue);
diff --git a/Tests/Opc.Ua.PubSub.Tests/Transport/MqttPubSubConnectionTests.cs b/Tests/Opc.Ua.PubSub.Tests/Transport/MqttPubSubConnectionTests.cs
diff --git a/Tests/Opc.Ua.Security.Certificates.Tests/CertificateTestsForECDsa.cs b/Tests/Opc.Ua.Security.Certificates.Tests/CertificateTestsForECDsa.cs
diff --git a/common.props b/common.props

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@`
`28`	`28`	`* ======================================================================*/`
`29`	`29`
`30`	`30`	`using System;`
`31`		`-`
	`31`	`+using System.Globalization;`
`32`	`32`	`using Opc.Ua;`
`33`	`33`
`34`	`34`	`#pragma warning disable CS1591`
`@@ -272,7 +272,7 @@ private ServiceResult OnShelve(`
`272`	`272`	`}`
`273`	`273`	`else`
`274`	`274`	`{`
`275`		`- dueTo = " due to TimedShelve of " + shelvingTime.ToString();`
	`275`	`+ dueTo = " due to TimedShelve of " + shelvingTime.ToString(CultureInfo.InvariantCulture);`
`276`	`276`	`}`
`277`	`277`	`}`
`278`	`278`	`else`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@`
`38`	`38`	`using Opc.Ua.Server;`
`39`	`39`	`using Opc.Ua.Sample;`
`40`	`40`	`using System.Reflection;`
	`41`	`+using System.Globalization;`
`41`	`42`
`42`	`43`	`namespace MemoryBuffer`
`43`	`44`	`{`
`@@ -234,7 +235,7 @@ protected override object GetManagerHandle(ISystemContext context, NodeId nodeId`
`234`	`235`	`}`
`235`	`236`
`236`	`237`	`// check range on offset.`
`237`		`- uint offset = Convert.ToUInt32(offsetText);`
	`238`	`+ uint offset = Convert.ToUInt32(offsetText, CultureInfo.InvariantCulture);`
`238`	`239`
`239`	`240`	`if (offset >= buffer.SizeInBytes.Value)`
`240`	`241`	`{`
Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ public int OperationTimeout`
`287`	`287`
`288`	`288`	`/// <inheritdoc/>`
`289`	`289`	`public bool CheckDomain => m_session.CheckDomain;`
`290`		`-`
	`290`	`+`
`291`	`291`	`/// <inheritdoc/>`
`292`	`292`	`public ContinuationPointPolicy ContinuationPointPolicy`
`293`	`293`	`{`
`@@ -661,7 +661,7 @@ public void ReadValues(IList<NodeId> variableIds, IList<Type> expectedTypes, out`
`661`	`661`	`m_session.ReadValues(variableIds, expectedTypes, out values, out errors);`
`662`	`662`	`}`
`663`	`663`	`}`
`664`		`-`
	`664`	`+`
`665`	`665`	`/// <inheritdoc/>`
`666`	`666`	`public byte[] ReadByteStringInChunks(NodeId nodeId)`
`667`	`667`	`{`
`@@ -671,8 +671,8 @@ public byte[] ReadByteStringInChunks(NodeId nodeId)`
`671`	`671`	`}`
`672`	`672`	`}`
`673`	`673`
`674`		`- /// <inheritdoc/>`
`675`		`- public void ReadDisplayName(IList<NodeId> nodeIds, out IList<string> displayNames, out IList<ServiceResult> errors)`
	`674`	`+ /// <inheritdoc/>`
	`675`	`+ public void ReadDisplayName(IList<NodeId> nodeIds, out IList<string> displayNames, out IList<ServiceResult> errors)`
`676`	`676`	`{`
`677`	`677`	`using (Activity activity = ActivitySource.StartActivity())`
`678`	`678`	`{`
`@@ -1289,18 +1289,17 @@ public void ManagedBrowse(RequestHeader requestHeader, ViewDescription view, ILi`
`1289`	`1289`	`{`
`1290`	`1290`	`m_session.ManagedBrowse(requestHeader, view, nodesToBrowse, maxResultsToReturn, browseDirection, referenceTypeId, includeSubtypes, nodeClassMask, out result, out errors);`
`1291`	`1291`	`}`
`1292`		`-`
`1293`	`1292`	`}`
`1294`	`1293`
`1295`	`1294`	`/// <inheritdoc/>`
`1296`		`- public async Task<(`
	`1295`	`+ public Task<(`
`1297`	`1296`	`IList<ReferenceDescriptionCollection>,`
`1298`	`1297`	`IList<ServiceResult>`
`1299`	`1298`	`)> ManagedBrowseAsync(RequestHeader requestHeader, ViewDescription view, IList<NodeId> nodesToBrowse, uint maxResultsToReturn, BrowseDirection browseDirection, NodeId referenceTypeId, bool includeSubtypes, uint nodeClassMask, CancellationToken ct = default)`
`1300`	`1299`	`{`
`1301`	`1300`	`using (Activity activity = ActivitySource.StartActivity())`
`1302`	`1301`	`{`
`1303`		`- return await m_session.ManagedBrowseAsync(requestHeader, view, nodesToBrowse, maxResultsToReturn, browseDirection, referenceTypeId, includeSubtypes, nodeClassMask, ct);`
	`1302`	`+ return m_session.ManagedBrowseAsync(requestHeader, view, nodesToBrowse, maxResultsToReturn, browseDirection, referenceTypeId, includeSubtypes, nodeClassMask, ct);`
`1304`	`1303`	`}`
`1305`	`1304`	`}`
`1306`	`1305`