Skip to content

OperationLimits remark does not match FetchOperationLimitsAsync functionality #3501

@Daniel-Alblas-VFI

Description

@Daniel-Alblas-VFI

Type of issue

  • Bug
  • Enhancement
  • Compliance
  • Question
  • Help wanted

Current Behavior

With the changes in #3303 FetchOperationLimitsAsync in Libraries/Opc.Ua.Client/Session/Session.cs always sets the operation limits to those of the server.

Expected Behavior

Prior to the changes in #3303 it seems that operation limits were set to the ones of the client, except if the value was 0 or the respective server value was smaller through FetchOperationLimitsAsync in Libraries/Opc.Ua.Client/Session/Session.cs. This seems to almost follows the remark in Stack/Opc.Ua.Core/Schema/ApplicationConfiguration.cs": Values not equal to zero are overwritten with smaller values set by the server." I expect either the prior functionality or the one described in the remark.

Steps To Reproduce

  1. Open up Libraries/Opc.Ua.Client/Session/Session.cs before and after Refactor client state persistence and add more tests #3303
  2. Open up Stack/Opc.Ua.Core/Schema/ApplicationConfiguration.cs and read the remark on OperationLimits

Environment

Anything else?

No response

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions