Skip to content

refactor: remove dead code.#1888

Open
JoshuaSBrown wants to merge 1 commit intodevelfrom
1887-DAPS-refactor-repo-remove-dead-code
Open

refactor: remove dead code.#1888
JoshuaSBrown wants to merge 1 commit intodevelfrom
1887-DAPS-refactor-repo-remove-dead-code

Conversation

@JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Mar 10, 2026

Ticket

Description

How Has This Been Tested?

Artifacts (if appropriate):

Tasks

  • - A description of the PR has been provided, and a diagram included if it is a new feature.
  • - Formatter has been run
  • - CHANGELOG comment has been added
  • - Labels have been assigned to the pr
  • - A reviwer has been added
  • - A user has been assigned to work on the pr
  • - If new feature a unit test has been added

Summary by Sourcery

Enhancements:

  • Clean up repository by deleting unused FUSE-based filesystem code and its CMake configuration.

@JoshuaSBrown JoshuaSBrown added the Component: Repository Relates to repository service label Mar 10, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes an unused filesystem FUSE integration module and its associated build configuration by deleting the filesys CMake entry and the fusemain implementation file.

File-Level Changes

Change Details Files
Remove obsolete filesys FUSE integration from the codebase and build.
  • Delete the filesys CMake configuration to stop building the FUSE filesystem component
  • Remove the FUSE entrypoint/implementation source file that is no longer used or referenced
repository/filesys/CMakeLists.txt
repository/filesys/fusemain.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@JoshuaSBrown JoshuaSBrown linked an issue Mar 10, 2026 that may be closed by this pull request
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since repository/filesys/CMakeLists.txt is removed, double-check and clean up any references to this directory or target from parent CMakeLists or build configuration to avoid dangling build entries.
  • If fusemain.cpp was previously wired into any runtime configuration (e.g., feature flags, config files, or startup wiring), consider removing those references as well so there are no leftover knobs for a now-absent feature.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `repository/filesys/CMakeLists.txt` is removed, double-check and clean up any references to this directory or target from parent CMakeLists or build configuration to avoid dangling build entries.
- If `fusemain.cpp` was previously wired into any runtime configuration (e.g., feature flags, config files, or startup wiring), consider removing those references as well so there are no leftover knobs for a now-absent feature.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@JoshuaSBrown
Copy link
Collaborator Author

@par-hermes format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Repository Relates to repository service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] - Repo facility code is stale

1 participant