set default to relative residual

Author: shakedregev

resolve/LinSolverIterative.cpp

@@ -57,17 +57,6 @@ namespace ReSolve
     return maxit_;
   }
 
-  int LinSolverIterative::setConvergenceCondition(index_type conv_cond)
-  {
-    if (conv_cond < 0 || conv_cond > 2)
-    {
-      out::error() << "Convergence condition must be 0, 1, or 2.\n";
-      return 1;
-    }
-    this->conv_cond_ = conv_cond;
-    return 0;
-  }
-
   int LinSolverIterative::setOrthogonalization(GramSchmidt* /* gs */)
   {
     out::error() << "Solver does not implement setting orthogonalization.\n";

resolve/LinSolverIterative.hpp

@@ -36,16 +36,13 @@ namespace ReSolve
     real_type  getTol() const;
     index_type getMaxit() const;
 
-    int setConvergenceCondition(index_type conv_cond);
-
     void setTol(real_type new_tol);
     void setMaxit(index_type new_maxit);
 
   protected:
     real_type  initial_residual_norm_;
     real_type  final_residual_norm_;
     index_type total_iters_;
-    index_type conv_cond_{0}; ///< Convergence condition (0: absolute, 1: relative to tol, 2: relative to rhs norm)
 
     // Parameters common for all iterative solvers
     real_type  tol_{1e-14}; ///< Solver tolerance

resolve/LinSolverIterativeFGMRES.hpp

@@ -83,7 +83,7 @@ namespace ReSolve
     };
 
     index_type restart_{10};    ///< GMRES restart
-    index_type conv_cond_{0};   ///< GMRES convergence condition
+    index_type conv_cond_{2};   ///< GMRES convergence condition
     bool       flexible_{true}; ///< If using flexible GMRES (FGMRES) algorithm
 
   private:

resolve/LinSolverIterativeRandFGMRES.hpp

@@ -98,7 +98,7 @@ namespace ReSolve
     };
 
     index_type restart_{10};    ///< GMRES restart
-    index_type conv_cond_{0};   ///< GMRES convergence condition
+    index_type conv_cond_{2};   ///< GMRES convergence condition
     bool       flexible_{true}; ///< If using flexible GMRES (FGMRES) algorithm
 
   private:

tests/functionality/testSysRefactor.cpp

@@ -133,14 +133,13 @@ static int runTest(int argc, char* argv[], std::string backend)
                                refactor, // refactorization
                                refactor, // triangular solve
                                "none",   // preconditioner (always 'none' here)
-                               "none");  // iterative refinement
+                               "none");   // iterative refinement
 
   // Configure solver (CUDA-based solver needs slightly different
   // settings than HIP-based one)
   solver.setRefinementMethod("fgmres", "cgs2");
   solver.getIterativeSolver().setCliParam("restart", "100");
   solver.getIterativeSolver().setTol(ReSolve::constants::MACHINE_EPSILON);
-  solver.getIterativeSolver().setConvergenceCondition(2); // relative residual norm
   if (backend == "hip")
   {
     solver.getIterativeSolver().setMaxit(200);