shaked debugging

Author: shakedregev

resolve/hykkt/cholesky/CholeskySolverCpu.cpp

@@ -77,7 +77,7 @@ namespace ReSolve
                                         (size_t) A->getNumColumns(),
                                         (size_t) A->getNnz(),
                                         1,
-                                        1,
+                                        0,
                                         1,
                                         CHOLMOD_REAL,
                                         &Common_);

resolve/hykkt/cholesky/CholeskySolverHip.cpp

@@ -88,17 +88,23 @@ namespace ReSolve
                          static_cast<real_type*>(L_chol_tr->x),
                          memory::HOST,
                          memory::DEVICE);
-        // L_->syncData(memory::HOST);
-        // L_->print(std::cout);
+        L_->syncData(memory::HOST);
+        L_->print(std::cout);
         // Store fill-in reducing permutation.
         // Within HyKKT, this will be the identity permutation because the Permutation class will permute the matrix.
         mem_.allocateArrayOnDevice(&Q_, A_->getNumRows());
         mem_.copyArrayHostToDevice(Q_, static_cast<index_type*>(factorization_->Perm), A_->getNumRows());
-
+        // print Q
+        // std::cout << "Q_: ";
+        for (size_t i = 0; i < A_->getNumRows(); ++i)
+        {
+          std::cout << static_cast<index_type*>(factorization_->Perm)[i] << " ";
+        }
+        A_->print(std::cout);
         // Store analysis in rfinfo_
         rocblas_status status = rocsolver_dcsrrf_analysis(handle_,
                                                           A_->getNumRows(),
-                                                          0,
+                                                          1,
                                                           A_->getNnz(),
                                                           A_->getRowData(memory::DEVICE),
                                                           A_->getColData(memory::DEVICE),
@@ -107,11 +113,12 @@ namespace ReSolve
                                                           L_->getRowData(memory::DEVICE),
                                                           L_->getColData(memory::DEVICE),
                                                           L_->getValues(memory::DEVICE),
-                                                          nullptr,
                                                           Q_,
-                                                          nullptr,
+                                                          Q_,
+                                                          L_->getValues(memory::DEVICE),
                                                           A_->getNumRows(),
                                                           rfinfo_);
+        std::cout << status << std::endl;
         if (status != rocblas_status_success)
         {
           out::error() << "Analysis step failed with status: " << status << "\n";
@@ -152,14 +159,24 @@ namespace ReSolve
       // std::cout << Q_ << "\n";
       // std::cout << x->getSize() << "\n";
       // std::cout << rfinfo_ << "\n";
+      // L_->syncData(memory::HOST);
+      // L_->setUpdated(memory::DEVICE);
+      // L_->syncData(memory::HOST);
+      // L_->print();
+      // x->syncData(memory::HOST);
+      // for (size_t i = 0; i < x->getSize(); ++i)
+      // {
+      //   std::cout << "x[" << i << "] = " << x->getData(memory::HOST)[i] << "\n";
+      // }
+      
       rocblas_status status = rocsolver_dcsrrf_solve(handle_,
                                                      L_->getNumRows(),
                                                      1,
                                                      L_->getNnz(),
                                                      L_->getRowData(memory::DEVICE),
                                                      L_->getColData(memory::DEVICE),
                                                      L_->getValues(memory::DEVICE),
-                                                     nullptr,
+                                                     Q_,
                                                      Q_,
                                                      x->getData(memory::DEVICE),
                                                      x->getSize(),

tests/unit/hykkt/HykktCholeskyTests.hpp

@@ -57,7 +57,7 @@ namespace ReSolve
         {
           A->syncData(memory::DEVICE);
         }
-
+        std::cout << "Matrix A:" << std::endl;
         ReSolve::hykkt::CholeskySolver solver(memspace_);
         solver.addMatrixInfo(A);
         solver.symbolicAnalysis();
@@ -72,6 +72,7 @@ namespace ReSolve
 
         if (memspace_ == memory::DEVICE)
         {
+          x->setDataUpdated(memory::DEVICE);
           x->syncData(memory::HOST);
         }