Skip to content

Commit 592ddd1

Browse files
committed
Merge commit 'eecb47a101ea651f749c7f1bce1ea7313ae3cdce' into f/OS-110
* commit 'eecb47a101ea651f749c7f1bce1ea7313ae3cdce': OS-175 package version on status page Releasing 4.0.0 Updated CHANGELOG Update os2web_audit OS-115 Skipping address with empty matrikelnummer phpcs fix OS-115 Skipping address with empty matrikelnummer
2 parents 0db0714 + eecb47a commit 592ddd1

File tree

4 files changed

+35
-13
lines changed

4 files changed

+35
-13
lines changed

CHANGELOG.md

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,18 @@ before starting to add changes. Use example [placed in the end of the page](#exa
1111

1212
## [Unreleased]
1313

14+
- Updating the display of os2forms package on the status page
15+
16+
## [4.0.0] 2025-03-06
17+
18+
- This is an alias for for 3.22.2. Major change is the module removal, which can lead to lack of backward support.
19+
See full release note here:
20+
https://github.com/OS2Forms/os2forms_docs/blob/master/docs/releases/2024-Q4-Release-notes.md
21+
22+
## [3.22.2] 2025-02-28
23+
24+
- Updated `os2web_audit`.
25+
1426
## [3.22.1] 2025-02-10
1527

1628
- Updated `os2forms_fbs_handler` to include and correct set phone number [#161](https://github.com/OS2Forms/os2forms/pull/161)
@@ -77,6 +89,13 @@ before starting to add changes. Use example [placed in the end of the page](#exa
7789

7890
## [3.16.0-beta1] 2024-08-27
7991

92+
## [3.16.0] 2024-08-27
93+
94+
f/OS-115_dawa_address
95+
- [OS-115] Skipping empty maktrikula objects
96+
97+
98+
8099
[#110](https://github.com/OS2Forms/os2forms/pull/110)
81100

82101
- Obsolete module removing - os2forms_consent
@@ -342,7 +361,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa
342361
- Security in case of vulnerabilities.
343362
```
344363

345-
[Unreleased]: https://github.com/OS2Forms/os2forms/compare/3.22.1...HEAD
364+
[Unreleased]: https://github.com/OS2Forms/os2forms/compare/3.22.2...HEAD
365+
[3.22.2]: https://github.com/OS2Forms/os2forms/compare/3.22.1...3.22.2
346366
[3.22.1]: https://github.com/OS2Forms/os2forms/compare/3.22.0...3.22.1
347367
[3.22.0]: https://github.com/OS2Forms/os2forms/compare/3.21.2...3.22.0
348368
[3.21.2]: https://github.com/OS2Forms/os2forms/compare/3.21.1...3.21.2

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"http-interop/http-factory-guzzle": "^1.0.0",
6969
"itk-dev/beskedfordeler-drupal": "^1.0",
7070
"itk-dev/serviceplatformen": "^1.5",
71-
"os2web/os2web_audit": "^0.1.6",
71+
"os2web/os2web_audit": "^1.0",
7272
"os2web/os2web_datalookup": "^2.0",
7373
"os2web/os2web_nemlogin": "^1.0",
7474
"os2web/os2web_simplesaml": "dev-master",

modules/os2forms_dawa/src/Plugin/os2web/DataLookup/DatafordelerDataLookup.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,12 @@ public function getMatrikulaEntries(string $matrikulaId) : array {
9999
if (NestedArray::keyExists($jsonDecoded, ['features', 0, 'properties', 'jordstykke'])) {
100100
$jordstykker = NestedArray::getValue($jsonDecoded, ['features', 0, 'properties', 'jordstykke']);
101101
foreach ($jordstykker as $jordstyk) {
102-
$matrikulaEntries[] = new DatafordelerMatrikula($jordstyk);
102+
try {
103+
$matrikulaEntries[] = new DatafordelerMatrikula($jordstyk);
104+
}
105+
catch (\TypeError $e) {
106+
// Could not create matrikula object.
107+
}
103108
}
104109
}
105110
}

os2forms.install

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* Install file for OS2Forms module.
66
*/
77

8+
use Composer\InstalledVersions;
89
use Drupal\field\Entity\FieldConfig;
910
use Drupal\field\Entity\FieldStorageConfig;
1011
use Drupal\taxonomy\Entity\Term;
@@ -63,21 +64,17 @@ function os2forms_requirements($phase) {
6364
'value' => $messages,
6465
];
6566

66-
$commit_sha = exec('git rev-parse HEAD');
67-
$tag = exec("git describe --tags --abbrev=0");
68-
$remote = exec('git config --get remote.origin.url');
67+
$reference = InstalledVersions::getReference("os2forms/os2forms");
68+
$version = InstalledVersions::getPrettyVersion("os2forms/os2forms");
6969

7070
$version_messages = [
7171
'#prefix' => t('OS2Forms version'),
7272
'#theme' => 'item_list',
7373
'#items' => [
74-
0 => t('tag <strong>@tag</strong> (commit: <strong>@commit</strong>)', [
75-
'@tag' => $tag,
76-
'@commit' => $commit_sha,
77-
]),
78-
1 => t('remote: <strong>@remote</strong>', [
79-
'@remote' => $remote,
80-
]),
74+
0 => t('version <strong>@version</strong> (commit: <strong>@reference</strong>)', [
75+
'@version' => $version,
76+
'@reference' => $reference,
77+
])
8178
],
8279
];
8380

0 commit comments

Comments
 (0)