Simplified validation

Author: jeppekroghitk

modules/os2forms_fbs_handler/src/Client/Fbs.php

@@ -118,9 +118,9 @@ public function createPatronWithGuardian(Patron $patron, Guardian $guardian) {
       'pincode' => $patron->pincode,
       'preferredPickupBranch' => $patron->preferredPickupBranch,
       'name' => 'Unknown Name',
-      'emailAddresses' => isset($patron->emailAddresses) && $patron->emailAddresses ? $patron->emailAddresses : [],
+      'emailAddresses' => $patron->emailAddresses ?? [],
       'guardian' => $guardian->toArray(),
-      'phoneNumbers' => isset($patron->phoneNumber) && $patron->phoneNumber ? [
+      'phoneNumbers' => $patron->phoneNumber ? [
         [
           'receiveNotification' => TRUE,
           'phoneNumber' => $patron->phoneNumber,
@@ -192,10 +192,10 @@ public function updatePatron(Patron $patron): bool {
     $payload = [
       'patron' => [
         'preferredPickupBranch' => $patron->preferredPickupBranch,
-        'emailAddresses' => isset($patron->emailAddresses) && $patron->emailAddresses ? $patron->emailAddresses : [],
+        'emailAddresses' => $patron->emailAddresses ?? [],
         'guardianVisibility' => $patron->guardianVisibility,
         'receivePostalMail' => $patron->receiveEmail,
-        'phoneNumbers' => isset($patron->phoneNumber) && $patron->phoneNumber ? [
+        'phoneNumbers' => $patron->phoneNumber ? [
           [
             'receiveNotification' => TRUE,
             'phoneNumber' => $patron->phoneNumber,