Coder review.

Author: andersbryrup

js/os2web_cp_service.js

@@ -1,4 +1,8 @@
-/* os2web_cp_service.js */
+/**
+ * @file
+ * os2web_cp_service.js
+ */
+
 jQuery(document).ready(function($) {
 	$( "a.qtip-this[title]" ).qtip({
 		style: {

os2web_cp_service.info

@@ -16,7 +16,7 @@ dependencies[] = list
 dependencies[] = node
 dependencies[] = number
 dependencies[] = options
-dependencies[] = os2web_esdh_provider
+dependencies[] = os2web_acadre_esdh
 dependencies[] = page_manager
 dependencies[] = panels
 dependencies[] = pathauto

os2web_cp_service.install

@@ -8,14 +8,14 @@
  * Imlpements hook_install().
  */
 function os2web_cp_service_install() {
-	// Quick way to have default approved rules
-	$approved_rules = array('Byggesager', 'Emnesager', 'Postliste');
+  // Quick way to have default approved rules.
+  // $approved_rules = array('Byggesager', 'Emnesager', 'Postliste');
 
-	$rules_vocabulary = taxonomy_vocabulary_machine_name_load('os2web_cp_service_tax_approved_rules');
-	foreach ($approved_rules as $name) {
-		$term = new stdClass();
-		$term->vid = $rules_vocabulary->vid;
-		$term->name = $name;
-		taxonomy_term_save($term);
-	}
+  // $rules_vocabulary = taxonomy_vocabulary_machine_name_load('os2web_cp_service_tax_approved_rules');
+  // foreach ($approved_rules as $name) {
+  //  $term = new stdClass();
+  //  $term->vid = $rules_vocabulary->vid;
+  //  $term->name = $name;
+  //  taxonomy_term_save($term);
+  // }
 }

os2web_cp_service.make

@@ -4,11 +4,11 @@ core = 7.x
 ;; OS2Web projects:
 
 ; OS2Web Modules
-projects[os2web_esdh_provider][type] = "module"
-projects[os2web_esdh_provider][download][type] = "git"
-;projects[os2web_esdh_provider][download][tag] = "1.10"
-projects[os2web_esdh_provider][download][branch] = "master"
-projects[os2web_esdh_provider][download][url] = "git://github.com/OS2web/os2web_esdh_provider.git"
+projects[os2web_acadre_esdh][type] = "module"
+projects[os2web_acadre_esdh][download][type] = "git"
+;projects[os2web_acadre_esdh][download][tag] = "1.10"
+projects[os2web_acadre_esdh][download][branch] = "master"
+projects[os2web_acadre_esdh][download][url] = "git://github.com/OS2web/os2web_acadre_esdh.git"
 
 ;; Contrib modules below:
 

os2web_cp_service.module

@@ -76,7 +76,7 @@ function os2web_gf_service_handler($file_id) {
         drupal_add_http_header('Content-Type', $header['content_type']);
         drupal_add_http_header('Content-Length', $header['download_content_length']);
         drupal_add_http_header('Cache-Control', 'must-revalidate, post-check=0, pre-check=0');
-        drupal_add_http_header('Cache-Control', 'private',false);
+        drupal_add_http_header('Cache-Control', 'private', FALSE);
         drupal_add_http_header('Connection', 'close');
         drupal_add_http_header('Expires', '0');