Issue/47 frontend delete devices when deleting application (#123)

* Deleting application now also deletes LoRaWAN devices in ChirpStack
* Removed unused imports in application.service.ts

Author: GufCab

src/services/device-management/application.service.ts

@@ -1,7 +1,7 @@
+import { LoRaWANDevice } from '@entities/lorawan-device.entity';
 import { Inject, Injectable, forwardRef, ConflictException } from "@nestjs/common";
 import { InjectRepository } from "@nestjs/typeorm";
 import { DeleteResult, getManager, In, QueryBuilder, Repository } from "typeorm";
-
 import { CreateApplicationDto } from "@dto/create-application.dto";
 import { ListAllApplicationsResponseDto } from "@dto/list-all-applications-response.dto";
 import { ListAllEntitiesDto } from "@dto/list-all-entities.dto";
@@ -14,7 +14,6 @@ import { IoTDeviceType } from "@enum/device-type.enum";
 import { LoRaWANDeviceWithChirpstackDataDto } from "@dto/lorawan-device-with-chirpstack-data.dto";
 import { CreateLoRaWANSettingsDto } from "@dto/create-lorawan-settings.dto";
 import { PermissionService } from "@services/user-management/permission.service";
-import { ListAllPaginated } from "@dto/list-all-paginated.dto";
 import { ErrorCodes } from "@enum/error-codes.enum";
 import { IoTDevice } from "@entities/iot-device.entity";
 import { ListAllIoTDevicesResponseDto } from "@dto/list-all-iot-devices-response.dto";
@@ -25,11 +24,11 @@ export class ApplicationService {
         @InjectRepository(Application)
         private applicationRepository: Repository<Application>,
         @Inject(forwardRef(() => OrganizationService))
-        private organizationService: OrganizationService,
+        private organizationService: OrganizationService,        
         private chirpstackDeviceService: ChirpstackDeviceService,
         @Inject(forwardRef(() => PermissionService))
         private permissionService: PermissionService
-    ) {}
+    ) { }
 
     async findAndCountInList(
         query?: ListAllEntitiesDto,
@@ -63,9 +62,9 @@ export class ApplicationService {
             where:
                 organizationIds.length > 0
                     ? [
-                          { id: In(allowedApplications) },
-                          { belongsTo: In(organizationIds) },
-                      ]
+                        { id: In(allowedApplications) },
+                        { belongsTo: In(organizationIds) },
+                    ]
                     : { id: In(allowedApplications) },
             take: query.limit,
             skip: query.offset,
@@ -237,12 +236,12 @@ export class ApplicationService {
     }
 
     async delete(id: number): Promise<DeleteResult> {
-        // Don't allow delete if this application contains any sigfox devices.
         const application = await this.applicationRepository.findOne({
             where: { id: id },
             relations: ["iotDevices"],
         });
 
+        // Don't allow delete if this application contains any sigfox devices.
         if (
             application.iotDevices.some(iotDevice => {
                 return iotDevice.type == IoTDeviceType.SigFox;
@@ -251,6 +250,15 @@ export class ApplicationService {
             throw new ConflictException(ErrorCodes.DeleteNotAllowedHasSigfoxDevice);
         }
 
+        // Delete all LoRaWAN devices in ChirpStack
+        const loRaWANDevices = application.iotDevices
+            .filter(device => device.type === IoTDeviceType.LoRaWAN);
+
+        for (let device of loRaWANDevices) {
+            const lwDevice = device as LoRaWANDevice;            
+            await this.chirpstackDeviceService.deleteDevice(lwDevice.deviceEUI);            
+        }
+
         return this.applicationRepository.delete(id);
     }