Feature/iot 1610 oddk feedback (#288)

* Change name of data directory key

* More feedback to oddk

Author: fcv-iteratorIt

src/entities/dto/open-data-dk-dcat.dto.ts

@@ -38,8 +38,8 @@ export class Dataset {
   spatial: string;
   theme: string[];
   documentation: string;
-  frequency: string | undefined;
-  dataDirectory: boolean;
+  update_frequency: string | undefined;
+  data_directory: boolean;
 }
 
 export class DCATRootObject {

src/migration/1766044800140-theme-migrator.ts

@@ -0,0 +1,50 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class ThemeMigrator1766044800140 implements MigrationInterface {
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    const datatargets = await queryRunner.query(`SELECT * FROM "open_data_dk_dataset" where "keywords" is not null`);
+    datatargets.forEach(async (dataTarget: any) => {
+      dataTarget.keywords = dataTarget.keywords.map((k: string) => themes.get(k));
+
+      await queryRunner.query(`UPDATE "open_data_dk_dataset" SET "keywords" = $1 WHERE "id" = $2`, [
+        dataTarget.keywords,
+        dataTarget.id,
+      ]);
+    });
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    const datatargets = await queryRunner.query(`SELECT * FROM "open_data_dk_dataset" where "keywords" is not null`);
+    datatargets.forEach(async (dataTarget: any) => {
+      dataTarget.keywords = dataTarget.keywords.map((k: string) => getByValue(themes, k));
+
+      await queryRunner.query(`UPDATE "open_data_dk_dataset" SET "keywords" = $1 WHERE "id" = $2`, [
+        dataTarget.keywords,
+        dataTarget.id,
+      ]);
+    });
+  }
+}
+
+const themes = new Map([
+  ["Befolkning og samfund", "SOCI"],
+  ["Energi", "ENER"],
+  ["Internationale spørgsmål", "INTR"],
+  ["Landbrug, fiskeri, skovbrug og fødevarer", "AGRI"],
+  ["Midlertidige data", "OP_DATPRO"],
+  ["Miljø", "ENVI"],
+  ["Regeringen og den offentlige sektor", "GOVE"],
+  ["Regioner og byer", "REGI"],
+  ["Retfærdighed, retssystem og offentlig sikkerhed", "JUST"],
+  ["Sundhed", "HEAL"],
+  ["Transport", "TRAN"],
+  ["Uddannelse, kultur og sport", "EDUC"],
+  ["Videnskab og teknologi", "TECH"],
+  ["Økonomi og finanser", "ECON"],
+]);
+
+function getByValue(map: Map<string, string>, searchValue: string) {
+  for (let [key, value] of map.entries()) {
+    if (value === searchValue) return key;
+  }
+}

src/services/data-management/open-data-dk-sharing.service.ts

@@ -157,9 +157,12 @@ export class OpenDataDkSharingService {
     ds.contactPoint["@type"] = "vcard:Contact";
     ds.contactPoint.fn = dataset.authorName;
     ds.contactPoint.hasEmail = `mailto:${dataset.authorEmail}`;
-    ds.documentation = dataset.documentationUrl;
-    ds.frequency = dataset.updateFrequency;
-    ds.dataDirectory = dataset.dataDirectory;
+    ds.documentation =
+      !dataset.documentationUrl || dataset.documentationUrl?.startsWith("https://")
+        ? dataset.documentationUrl
+        : `https://${dataset.documentationUrl}`;
+    ds.update_frequency = dataset.updateFrequency;
+    ds.data_directory = dataset.dataDirectory;
 
     ds.distribution = [this.mapDistribution(organization, dataset)];