Minor snack changes and check if devices is included before sending downlink

Author: AugustHA-Iterator

src/app/applications/multicast/multicast-detail/multicast-detail.component.ts

@@ -91,27 +91,17 @@ export class MulticastDetailComponent implements OnInit {
             .delete(this.multicast.id)
             .subscribe((response) => {
               if (response.status !== 0) {
-                this.showDeletedSnack();
+                this.snackService.showDeletedSnack();
                 this.location.back();
               } else {
-                this.showFailSnack();
+                this.snackService.showFailSnack();
               }
             });
         } else {
         }
       });
   }
 
-  showDeletedSnack(): void {
-    this.snackService.showDeletedSnack();
-  }
-
-  showFailSnack(): void {
-    this.snackService.showFailSnack();
-  }
-  showQueueSnack(): void {
-    this.snackService.showInQueueSnack();
-  }
   keyPressHexadecimal(event) {
     // make sure only hexadecimal can be typed in input with adresses.
     keyPressedHex(event);
@@ -124,16 +114,20 @@ export class MulticastDetailComponent implements OnInit {
   }
 
   clickDownlink() {
-    if (this.validateHex(this.downlink.data)) {
-      this.multicastService
-        .multicastGet(this.multicast.id)
-        .subscribe((response: any) => {
-          if (response.totalCount > 0) {
-            this.openDownlinkDialog();
-          } else {
-            this.startDownlink();
-          }
-        });
+    if (this.multicast.iotDevices.length > 0) {
+      if (this.validateHex(this.downlink.data)) {
+        this.multicastService
+          .multicastGet(this.multicast.id)
+          .subscribe((response: any) => {
+            if (response.totalCount > 0) {
+              this.openDownlinkDialog();
+            } else {
+              this.startDownlink();
+            }
+          });
+      }
+    } else {
+      this.snackService.showSendDownlinkFailNoDevices();
     }
   }
   openDownlinkDialog() {
@@ -152,7 +146,7 @@ export class MulticastDetailComponent implements OnInit {
       .multicastPost(this.downlink, this.multicast.id)
       .subscribe(
         () => {
-          this.showQueueSnack();
+          this.snackService.showInQueueSnack();
         },
         (error) => {
           this.handleError(error);

src/app/applications/multicast/multicast-edit/multicast-edit.component.ts

@@ -143,11 +143,11 @@ export class MulticastEditComponent implements OnInit {
 
     this.multicastService.update(this.multicast).subscribe(
       () => {
-        this.showUpdatedSnack();
+        this.snackService.showUpdatedSnack();
         this.routeBack();
       },
       (error: HttpErrorResponse) => {
-        this.showFailSnack();
+        this.snackService.showFailSnack();
         this.handleError(error);
         this.formFailedSubmit = true;
       }
@@ -159,11 +159,11 @@ export class MulticastEditComponent implements OnInit {
 
     this.multicastService.create(this.multicast).subscribe(
       () => {
-        this.showSavedSnack();
+        this.snackService.showSavedSnack();
         this.routeBack();
       },
       (error: HttpErrorResponse) => {
-        this.showFailSnack();
+        this.snackService.showFailSnack();
         this.handleError(error);
         this.formFailedSubmit = true;
       }
@@ -186,15 +186,6 @@ export class MulticastEditComponent implements OnInit {
   routeBack(): void {
     this.router.navigate(['applications', this.applicationId.toString()]);
   }
-  showSavedSnack() {
-    this.snackService.showSavedSnack();
-  }
-  showFailSnack() {
-    this.snackService.showFailSnack();
-  }
-  showUpdatedSnack() {
-    this.snackService.showUpdatedSnack();
-  }
   keyPressHexadecimal(event) {
     keyPressedHex(event);
   }

src/app/applications/multicast/multicast-table/multicast-table.component.ts

@@ -69,11 +69,13 @@ export class MulticastTableComponent
             this.sort.active,
             this.sort.direction
           );
-          //TODO::: Snack here
           return multicasts;
         }),
         map((data) => {
           // Flip flag to show that loading has finished.
+          if (data.ok === false) {
+            this.snackService.showLoadFailSnack();
+          }
           this.isLoadingResults = false;
           this.resultsLength = data.count;
 

src/app/shared/services/snack.service.ts

@@ -41,4 +41,9 @@ export class SnackService {
       duration: 10000,
     });
   }
+  public showSendDownlinkFailNoDevices(){
+    this.snackBar.open(this.translate.instant('SNACK.NODEVICES'), this.translate.instant('SNACK.CLOSE'), {
+      duration: 10000,
+    });
+  }
 }

src/assets/i18n/da.json

@@ -53,7 +53,8 @@
     "FAIL": "Fejl - aktion ikke fuldført",
     "LOADFAIL": "Fejl - kunne ikke loade",
     "QUEUE": "Element sat i kø",
-    "CLOSE": "Luk"
+    "CLOSE": "Luk",
+    "NODEVICES": "Kan ikke sende downlink - der er ingen devices!"
   },
   "SEARCH": {
     "ICON": "",