Updated Chirpstack from V3 to V4 (#152)

* Fixed routing of gateway list + fixed memory leak by unsubscribing properly from gateway fetches

* Fixed routing errors in gateway list

* Changed mqtt datatarget topic placeholder + added tooltip

* Added additional text changes from Product Owner

* Removed maxLenght from device AND gateway EUI, now removes non-hex digits on submit

* Gateway upgrades to get data from v4.

* Added sticky to name column on gateway status table

* Implemented application table column selection

* Removed unused controller name from select

* Moved column selector to own component + implemented column selection on iot-device table

* Changed datastructure of gateway to match database + Column administration on gateway-status-table

* Changed column selector for a cog icon button

* Chirpstack updates.

* small fixes after merge

* Spinner for device profiles

* changed printhWidth to match backend

* fresh package-lock

* updated to node-version 18 on github

* First set of pr changes

* some PR changes before merge

* PR changes and added prettier from backend so it can match with frontend (both are nodejs, so shouldn't it be the same?)

* Updated package-lock and bumped monaco-editor down to 0.33

* Fixes

* da.json addition

---------

Co-authored-by: Frederik Christ Vestergaard <[email protected]>
Co-authored-by: August Andersen <[email protected]>

Author: 3 people

.github/workflows/on-push-pr.action.yml

@@ -32,7 +32,7 @@ jobs:
       - uses: actions/setup-node@v3
         name: Set NodeJS version
         with:
-          node-version: 14
+          node-version: 18
       - name: Install packages
         run: "npm ci"
       - name: Build source

.prettierrc

@@ -0,0 +1,11 @@
+module.exports = {
+  trailingComma: "es5",
+  tabWidth: 4,
+  printWidth: 120,
+  semi: true,
+  singleQuote: false,
+  useTabs: false,
+  bracketSpacing: true,
+  arrowParens: "avoid",
+  endOfLine: "auto",
+};

.prettierrc.js

@@ -41,7 +41,7 @@
     "jwt-decode": "^3.1.2",
     "leaflet": "^1.7.1",
     "moment": "^2.29.4",
-    "monaco-editor": "^0.44.0",
+    "monaco-editor": "^0.33.0",
     "ng": "0.0.0",
     "ng-inline-svg": "^11.0.0",
     "ngx-monaco-editor-v2": "^14.0.4",

package-lock.json

@@ -16,7 +16,6 @@
     <table mat-table [dataSource]="data" class="example-table" matSort matSortActive="name" matSortDisableClear
            matSortDirection="asc">
 
-      <!-- Name Column -->
       <ng-container matColumnDef="name">
         <th mat-header-cell *matHeaderCellDef mat-sort-header class="col-2">
           {{ 'APPLICATION-TABLE.NAME' | translate }}
@@ -45,7 +44,6 @@
         </td>
       </ng-container>
 
-      <!-- Devices Column -->
       <ng-container matColumnDef="devices">
         <th mat-header-cell *matHeaderCellDef mat-sort-header class="col-2">
           {{ 'APPLICATION-TABLE.IOT-DEVICES' | translate }}</th>
@@ -136,7 +134,6 @@
         </td>
       </ng-container>
 
-      <!-- Menu Column -->
       <ng-container matColumnDef="menu">
         <th mat-header-cell *matHeaderCellDef class="col-1"></th>
         <td mat-cell *matCellDef="let element">

package.json

@@ -36,9 +36,6 @@ export class BulkMapping {
       applicationSessionKey: data.applicationSessionKey
         ? data.applicationSessionKey
         : undefined,
-      serviceProfileID: data.serviceProfileID
-        ? data.serviceProfileID
-        : undefined,
       deviceProfileID: data.deviceProfileID ? data.deviceProfileID : undefined,
       fCntUp: data.fCntUp ? +data.fCntUp : undefined,
       nFCntDown: data.nFCntDown ? +data.nFCntDown : undefined,

src/app/applications/applications-list/applications-table/applications-table.component.html

@@ -55,7 +55,7 @@ export class DownlinkComponent implements OnInit {
     if (error?.error?.chirpstackError?.error == "f_port must be > 0") {
       this.errorMessages = ["port must be > 0"]
       return;
-    } 
+    }
     this.errorMessages = this.errorMessageService.handleErrorMessage(error);
   }
 

src/app/applications/bulk-import/bulk-mapping.ts

@@ -1,5 +1,4 @@
 <p><strong>{{ 'IOTDEVICE.LORA.DEVEUI' | translate }}</strong>{{device.lorawanSettings.devEUI}}</p>
-<p><strong>{{ 'IOTDEVICE.LORA.SERVICEPROFILE' | translate }}</strong>{{serviceProfileName}}</p>
 <p><strong>{{ 'IOTDEVICE.LORA.DEVICEPROFILE' | translate }}</strong>{{deviceProfileName}}</p>
 <ng-container *ngIf="OTAA">
     <p><strong>{{ 'IOTDEVICE.LORA.OTAAAPPLICATIONKEY' | translate }}</strong>{{device.lorawanSettings?.OTAAapplicationKey}}
@@ -15,4 +14,4 @@
     <p><strong>{{ 'IOTDEVICE.LORA.NFCNTDOWN' | translate }}</strong>{{device.lorawanSettings?.nFCntDown }}</p>
 </ng-container>
 <p><strong>{{ 'IOTDEVICE.LORA.SKIPFCNTCHECK' | translate }}</strong>{{device.lorawanSettings?.skipFCntCheck | yesNo}}
-</p>
+</p>

src/app/applications/iot-devices/iot-device-detail/downlink/downlink.component.ts

@@ -1,9 +1,7 @@
 import { Component, Input, OnInit } from '@angular/core';
 import { IotDevice } from '@applications/iot-devices/iot-device.model';
 import { DeviceProfileService } from '@profiles/device-profiles/device-profile.service';
-import { ServiceProfileResponseOne } from '@profiles/service-profiles/service-profile.model';
-import { ServiceProfileService } from '@profiles/service-profiles/service-profile.service';
-import { Subscribable, Subscription } from 'rxjs';
+import { Subscription } from 'rxjs';
 
 @Component({
   selector: 'app-iot-device-detail-lorawan',
@@ -16,16 +14,13 @@ export class IotDeviceDetailLorawanComponent implements OnInit {
   deviceProfileSubscription: Subscription;
   public OTAA: boolean;
   public deviceProfileName: string;
-  public serviceProfileName: string;
 
   constructor(
     private deviceProfileService: DeviceProfileService,
-    private serviceProfileService: ServiceProfileService
   ) { }
 
   ngOnInit(): void {
     this.getDeviceProfil();
-    this.getServiceProfil();
   }
 
   getDeviceProfil() {
@@ -35,12 +30,4 @@ export class IotDeviceDetailLorawanComponent implements OnInit {
             this.deviceProfileName = response.deviceProfile.name;
         });
   }
-
-  getServiceProfil() {
-    this.deviceProfileSubscription = this.serviceProfileService.getOne(this.device.lorawanSettings?.serviceProfileID)
-        .subscribe((response: ServiceProfileResponseOne) => {
-            this.serviceProfileName = response.serviceProfile.name;
-        });
-  }
-
 }