Skip to content

Commit e5f340f

Browse files
PR changes.
1 parent c36e3f9 commit e5f340f

File tree

3 files changed

+9
-38
lines changed

3 files changed

+9
-38
lines changed

src/app/admin/permission/permission.service.ts

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -75,34 +75,13 @@ export class PermissionService {
7575
}
7676
}
7777

78-
getPermissionsWithoutUsers(
79-
limit: number = 1000,
80-
offset: number = 0,
81-
orderByColumn?: string,
82-
orderByDirection?: string,
83-
userId?: number,
84-
organisationId?: number,
85-
ignoreGlobalAdmin?: boolean
86-
): Observable<PermissionGetManyResponse> {
87-
if (userId || organisationId) {
88-
return this.restService.get(this.endpoint + "/getAllPermissionsWithoutUsers", {
89-
limit: limit,
90-
offset: offset,
91-
orderOn: orderByColumn,
92-
sort: orderByDirection,
93-
userId: userId,
94-
organisationId: organisationId,
95-
ignoreGlobalAdmin: ignoreGlobalAdmin,
96-
});
97-
} else {
98-
return this.restService.get(this.endpoint + "/getAllPermissionsWithoutUsers", {
99-
limit: limit,
100-
offset: offset,
101-
orderOn: orderByColumn,
102-
sort: orderByDirection,
103-
ignoreGlobalAdmin: ignoreGlobalAdmin,
104-
});
105-
}
78+
getPermissionsWithoutUsers(userId?: number): Observable<PermissionGetManyResponse> {
79+
return this.restService.get(this.endpoint + "/getAllPermissionsWithoutUsers", {
80+
limit: 1000,
81+
offset: 0,
82+
userId: userId ?? undefined,
83+
ignoreGlobalAdmin: true,
84+
});
10685
}
10786

10887
deletePermission(id: number) {

src/app/admin/users/user-edit/user-edit.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080

8181
<div class="row mb-5">
8282
<div class="form-group mt-3 col-12">
83-
<label class="form-label" for="permissions">{{ "QUESTION.PERMISSION.SELECT-PERMISSION" | translate }}</label
83+
<label class="form-label" id="permissions" for="permissions">{{ "QUESTION.PERMISSION.SELECT-PERMISSION" | translate }}</label
8484
>*
8585
<mat-select
8686
class="form-control"

src/app/admin/users/user-edit/user-edit.component.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,7 @@ export class UserEditComponent implements OnInit, OnDestroy {
145145

146146
private getPermissions(userId: number) {
147147
this.permissionsSubscription = this.permissionService
148-
.getPermissionsWithoutUsers(
149-
1000,
150-
0,
151-
undefined,
152-
undefined,
153-
this.meService.hasGlobalAdmin() ? undefined : userId,
154-
undefined,
155-
true
156-
)
148+
.getPermissionsWithoutUsers(this.meService.hasGlobalAdmin() ? undefined : userId)
157149
.subscribe(res => {
158150
this.permissions = res.data.sort((a, b) => a.name.localeCompare(b.name, "da-DK", { numeric: true }));
159151
if (!this.id) {

0 commit comments

Comments
 (0)