Skip to content

Commit f54feae

Browse files
committed
Finished implementing new flow for sending ODDK-registration-mails directly from OS2IoT, instead of having to go through users mail-client..
1 parent 533b062 commit f54feae

18 files changed

+330
-267
lines changed

src/app/admin/organisation/organisation.model.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export interface OrganisationResponse {
1616
createdByName: string;
1717
updatedByName: string;
1818
name: string;
19+
openDataDkRegistered: boolean;
1920

2021
payloadDecoders: PayloadDecoder[];
2122
applications: Application[];

src/app/applications/datatarget/datatarget.model.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,10 @@ export class DatatargetTypeDescriptor {
4444
readMoreUrl: string;
4545
provider: string;
4646
}
47+
48+
export class OddkMailInfo {
49+
organizationId?: number;
50+
organizationOddkAlias: string;
51+
comment?: string;
52+
sharingUrl?: string
53+
}

src/app/applications/datatarget/datatarget.module.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ import { DatatargetEditTypeSelectorDirective } from './datatarget-edit/datatarge
2424
import { MqttEditComponent } from './mqtt-edit/mqtt-edit.component';
2525
import { MqttDetailComponent } from './mqtt-detail/mqtt-detail.component';
2626
import { DatatargetTabComponent } from './datatarget-tab/datatarget-tab.component';
27+
import { OpenDataDkMailDialogComponent } from './opendatadk/opendatadk-edit/opendatadk-mail-dialog/opendatadk-mail-dialog';
28+
import { OpenDataDkWarningDialogComponent } from './opendatadk/opendatadk-edit/opendatadk-warning-dialog/opendatadk-warning-dialog';
2729

2830
@NgModule({
2931
declarations: [
@@ -38,11 +40,14 @@ import { DatatargetTabComponent } from './datatarget-tab/datatarget-tab.componen
3840
OpendatadkComponent,
3941
OpendatadkEditComponent,
4042
OpendatadkDetailComponent,
43+
OpenDataDkMailDialogComponent,
44+
OpenDataDkWarningDialogComponent,
4145
MqttDetailComponent,
4246
MqttEditComponent,
4347
DatatargetDetailTypeSelectorDirective,
4448
DatatargetEditTypeSelectorDirective,
45-
DatatargetTabComponent],
49+
DatatargetTabComponent,
50+
],
4651
imports: [
4752
CommonModule,
4853
RouterModule,
@@ -64,7 +69,7 @@ import { DatatargetTabComponent } from './datatarget-tab/datatarget-tab.componen
6469
FiwareEditComponent,
6570
HttppushDetailComponent,
6671
HttppushEditComponent,
67-
NGMaterialModule
68-
]
72+
NGMaterialModule,
73+
],
6974
})
70-
export class DatatargetModule { }
75+
export class DatatargetModule {}

src/app/applications/datatarget/datatarget.service.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Injectable } from '@angular/core';
22
import { Observable } from 'rxjs';
33
import { DatatargetResponse } from '@applications/datatarget/datatarget-response.model';
44
import { RestService } from '@shared/services/rest.service';
5-
import { DatatargetData, Datatarget } from './datatarget.model';
5+
import { DatatargetData, Datatarget, OddkMailInfo } from './datatarget.model';
66
import { map } from 'rxjs/operators';
77
import { OpenDataDkDataset } from './opendatadk/opendatadk-dataset.model';
88
import { SharedVariableService } from '@shared/shared-variable/shared-variable.service';
@@ -116,4 +116,14 @@ export class DatatargetService {
116116
return this.restService.createResourceUrl('open-data-dk-sharing', this.sharedVariableService.getSelectedOrganisationId());
117117
}
118118

119+
getOpenDataDkRegistered(organizationId: number): Observable<boolean> {
120+
return this.restService.get(this.dataTargetURL + '/getOpenDataDkRegistered', undefined, organizationId);
121+
}
122+
updateOpenDataDkRegistered(organizationId: number): Observable<boolean> {
123+
return this.restService.put(this.dataTargetURL + '/updateOpenDataDkRegistered', undefined, organizationId);
124+
}
125+
sendOpenDataDkMail(mailDto: OddkMailInfo): Observable<boolean> {
126+
mailDto.sharingUrl = this.getOpendataSharingApiUrl();
127+
return this.restService.post(this.dataTargetURL + '/sendOpenDataDkMail', mailDto);
128+
}
119129
}

src/app/applications/datatarget/opendatadk/opendatadk-edit/opendatadk-edit.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@
287287
<h6 *ngIf="datatargetId === 0" class="mt-3">{{ 'QUESTION.DATATARGET.RELATIONS' | translate }}</h6>
288288

289289
<!-- For existing data-targets, we show list of payload-decoders and button etc. for adding new -->
290-
<!-- TODO: Seems we have the exact same thing on HTTP, OpenDataDK, Fireware and MQTT... Why not make it a separate component!? -->
290+
<!-- TODO: Seems we have the exact same thing on HTTP, OpenDataDK, Fireware and MQTT... Why not make it a separate, re-usable component!? -->
291291
<div *ngIf="datatargetId > 0" class="container row" class="mt-3">
292292
<a (click)="addRow()" class="btn btn-secondary my-2 mb-3 mt-3">
293293
{{'QUESTION.ADD-RELATIONS' | translate}}
@@ -377,7 +377,7 @@ <h6 *ngIf="datatargetId === 0" class="mt-3">{{ 'QUESTION.DATATARGET.RELATIONS' |
377377
<button (click)="routeToDatatargets()" class="btn btn-light" type="button">
378378
{{ 'GEN.BACK' | translate }}
379379
</button>
380-
<button [disabled]="disableSaveButton()" class="btn btn-primary ml-2" type="submit">
380+
<button [disabled]="!datatarget?.openDataDkDataset?.acceptTerms" class="btn btn-primary ml-2" type="submit">
381381
{{ 'DATATARGET.SAVE' | translate }}
382382
</button>
383383
</div>

0 commit comments

Comments
 (0)