Skip to content

Commit 78ffb54

Browse files
committed
Add some TODO comments for possible future improvements
1 parent 0146dfe commit 78ffb54

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/components/element_info.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ function ElementInfo({ changeset, action, token, setHighlight }) {
3333
actionPhrase = 'deleted';
3434
}
3535

36+
// Get a 'lon' or 'lat' (the key argument specifies which) representing position
37+
// of the selected feature/action.
38+
// TODO: it would be more correct to convert the feature to GeoJSON and then
39+
// find its centroid or bounding box center.
3640
const getCoord = key => {
3741
return (
3842
action.new?.[key] || // point
@@ -134,6 +138,10 @@ function OpenInDropdown({ id, lat, lng }) {
134138
}
135139
];
136140

141+
// TODO: for now we've added Mapillary and Panoramax to the "Open In" list,
142+
// but this is a bit confusing since really it's just viewing the location of
143+
// the feature (not editing the feature, like the other options). We should
144+
// split this out into a separate menu - maybe "View in" and "Edit in".
137145
if (lat && lng) {
138146
options = [
139147
...options,

0 commit comments

Comments
 (0)