Skip to content

Ship-track example contains errorΒ #77

@tkeffer

Description

@tkeffer

The ship-track example retains leftover bins while computing MVBS. Unfortunately, there is a typo that prevents the leftover data from actually being used. The variable leftover_bin_Sv should actually be leftover_ds_Sv:

@@ -377,7 +377,7 @@
     "    complete_bins_Sv = concat_ds_Sv.isel(ping_time=slice(0, cutoff_index))\n",
     "\n",
     "    # Keep remaining data for next iteration\n",
-    "    leftover_bin_Sv = concat_ds_Sv.isel(ping_time=slice(cutoff_index, -1))\n",
+    "    leftover_ds_Sv = concat_ds_Sv.isel(ping_time=slice(cutoff_index, -1))\n",
     "\n",
     "    # Compute MVBS on current subset\n",
     "    ds_MVBS = ep.commongrid.compute_MVBS(\n",

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions