-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Feature Request
The ._get_missing_input_dataframes(...) method is meant to align the input_data with the config file data. It will add empty dataframes if the user has not supplied data. However, the method ReadStrrategy._compare_read_to_expected(...) is often called before ._get_missing_input_dataframes(...) in the concrete classes. ._compare_read_to_expected(...) will raise a OtooleNameMismatchError if the input data and config data do not match (which is not entirely clear from the name OtooleNameMismatchError).
Is your feature related to a bug?
Suggested Solution
I guess we could:
- Get rid of the
._compare_read_to_expected(...)method, and just raise a warning if the input data and config data dont match - Change the error handling to a flag option (see issue [FEATURE]: Change checking of names to a flag option #169)
- Get rid of the
._get_missing_input_dataframes(...)method and strictly enforce data consistency (which may be tedious for legacy models)
Additional Info
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request